submit-social-housing-lettings-and-sales-data

Submit social housing lettings and sales data (CORE)

core

natdeanlewissoftwire 9e4bcfdcc2 CLDC-2034 Skip fixed term tenancy length question when teancy type is other (#1403 ) * feat: skip fixed term tenancy length question when tenancy is other * CLDC-2006 Add 23/24 collection year LAs (#1392) * Update LAs for 23/24 sales questions * Update LAs for 23/24 lettings questions * Update LAs for 23/24 location * Remove redundant assignments * Update question files to use the local authorities from db * Update locations to use local authorities from db * Rebase changes * Replace hardcoded date * Add PaperTrail to OrganisationRelationship (#1406) * CLDC-1838 update copy for both offered questions (#1401) * ensure copy is changed for both questions relating to how many times a property has been offered extract to en.yml so that both questions keep identical copy in the future * minor typo caught in code review * copy change for LA (#1407) * CLDC-1997 Infer new LAs for post 2023 logs (#1398) * Infer new LAs after year 2023 * Test * Run CSV export before XML export to CDS (#1393) - The XML export mutates the `LogsExport` table which determines the period in which logs are exported. - The CSV export does not change this table, so if the CSV gets ran at the same time as the XML log it could skip records. * CLDC-1998 Correctly infer 22/23 las if a NEW one is returned by postcodes.io (#1397) * feat: correctly infer las for 22/23 logs * feat: copy changes to sales log * feat: don't reset las when clash with postcode to make tests pass * feat: align with similar PR for 23/24 * feat: tidying and add test * refactor: lint * refactor: use unless * CLDC-1919 Add 23/24 rent ranges (#1405) * feat: add 23/24 rent ranges csv * fix: use new 2023/24 rent ranges after duplicates removed * test: update seeds test to use new rent ranges count * fix: resave 2023 CSV as not UTF-8 (#1411) * CLDC-1820 Update reason for leaving domestic abuse answer options (non-renewal only) (#1391) * feat: change domestic abuse answer opts * test: add test for reason question * CLDC-1808 add previous tenure question for buyer two (#1354) * create and run migration for new columns related to buyer two previous tenure * a little refactoring for readability * create new pages, questions, associated tests and a couple of boolean methods on sales log for depends_on readability * add new pages to subsection and amend tests to reflect this change * make new pages only visible for new collection year, rename filesamend tests * some copy changes and alterations of readability after code review * CLDC-1816 add hint text to tenancy type options (#1341) * add hint text to several options on tenancy type, rename question class and a few others to make them pascal case and write test files for all changed questions * update some depends on for readability and write test files for page classes * change the condition to avoid conflicts with 2034 and cover that ticket in this one * also add hints to other tenancy question * add new answer options to nationality, rename question, write test file (#1339) * CLDC-2014 remove text field for buyer 1 nationality other (#1388) * remove question no longer needed and associated test file * amend page and the other question in that page that determined whether the deleted question should be shown update associated test files * createa a migration to remove the column for the deleted question * update test broken by changes * fix test broken by changes * CLDC-1886 Add sales paper form download (#1408) * Add sales paper form download * Rename download path * Add 22/23 sales log download * Update lettings log form download (#1409) * Run tests in parallel (#1412) * Run tests in parallel * Failing test * Add parallel tests to prod pipeline * Remove failing test * Add PARALLEL_TEST_PROCESSORS env var * CLDC-1925 ask for buyer 2 nationality when joint purchase (#1390) * create migration for new column * create page class and add to household characteristics * create question for buyer 2 nationality and associated test file * fix failing test after added page * rename method after code review * add question number for the new question to allow CLDC-1864 to progress with fewer conflicts/complications * fix: get real validation messages for rent range validations (#1413) * CLDC-1826 lettings log codes only download (#1268) * update seeds to add self in review env, change spec to reflect this, update config yml to allow csv exports in review * update interface of relevant methods EmailCsvJob, LettingsLog.to_csv and LettingsLogCsvService consume codes_only flag * update tests including adding a new csv file to test against * update LettingsLogCsvService to output codes only csv * correct minor error and linting * enable codes only download in UI - add link on lettings log index page - pass codes_only flag through params in relevant links and methods - convert flag to boolean in controller methods * ensure link displayed successfully for all renderings of logs_list and params passed through relevant methods in organisations controller * fix existing tests * correct linting thing * correct linting error * update tests for lettings log controller * correct linting errors * update organisations controller tests * make minor changes after code review * remove changes made for testing on review app * make codes only download visible to support users only * change variable names throughout after info on rauby/rails naming conventions, update tests for change in who can view codes only download link * rework csv service for readability, remove delegating methods from lettings log to keep all code to do with mapping between our domain and desired export format in one place * update test name * correct a small typo and remove a duplicated method after clever git merge conflict suggestion * point review app at staging csv bucket for csv download * change variables named codes_only_export to codes_only to avoid inconsistency * write tests to ensure that differetn user roles have the correct permissions around csv download * ensure that non support users may not download codes only exports * correct a small error in a previous commit * correct minor linting error * Make tests less dependant (#1415) * Seed the test db before tests and reset forms after tests * Update rails * Remove redundant FormHandler reinitialise --------- Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com> Co-authored-by: James Rose <james@jbpr.net> Co-authored-by: Arthur Campbell <51094020+arfacamble@users.noreply.github.com> Co-authored-by: Phil Lee <asmega@users.noreply.github.com> Co-authored-by: SamSeed-Softwire <63662292+SamSeed-Softwire@users.noreply.github.com>		3 years ago
..
schema	CLDC-1627 Enable multiple inferred answers (#1077 )	3 years ago
2021_2022.json	CLDC-1828 amend copy on soft validation screen for rent value (#1251 )	3 years ago
2022_2023.json	CLDC-2034 Skip fixed term tenancy length question when teancy type is other (#1403 )	3 years ago