submit-social-housing-lettings-and-sales-data

Submit social housing lettings and sales data (CORE)

core

Rachael Booth 636e40fc9d CLDC-3505: Fix tests for hard year end part 4 (#2509 An error occurred ) * Add in past end dates for testing * Temporarily disable test marked to delete at year end * Remove one off reinfer_local_authority task * Update validator_spec * Set 2024 date in form_handler_spec to be during crossover period as needed * Use bulk_upload.year_combo for comparison in request tests to avoid year dependancy * Update BU log creator specs for 2024 * Use year combo function in bulk upload mailer tests * Refactor lettings validator_spec * More fixes * More work on bu validator specs - mostly sales * Remove pre 2023 test * More use of bulk_upload.year_combo in request tests * Fix lint * Tweak bulk upload error row component tests for year changes * Further fixes * Fix 2023 lettings row parser spec * Sales log to csv fix * Refactor BU processor tests * Fix field number row identifier * Fix linting * More years in request spec * fix * Don't use db unnecessarily in financial validations spec * Fix sale date changing 2024 -> 2023 test * Add tests for bulk_upload.year_combo * Update bu factory year specification * Refactoring * Linting * Don't use helper in factory * Remove new 2023 specific test * Remove dummy end dates	8 months ago
..
lettings_log_to_csv.rb	CLDC-3505: Fix tests for hard year end part 4 (#2509 An error occurred )	8 months ago
sales_log_to_csv.rb	CLDC-3505: Fix tests for hard year end part 4 (#2509 An error occurred )	8 months ago

CLDC-3505: Fix tests for hard year end part 4 (#2509)

* Add in past end dates for testing

* Temporarily disable test marked to delete at year end

* Remove one off reinfer_local_authority task

* Update validator_spec

* Set 2024 date in form_handler_spec to be during crossover period as needed

* Use bulk_upload.year_combo for comparison in request tests to avoid year dependancy

* Update BU log creator specs for 2024

* Use year combo function in bulk upload mailer tests

* Refactor lettings validator_spec

* More fixes

* More work on bu validator specs - mostly sales

* Remove pre 2023 test

* More use of bulk_upload.year_combo in request tests

* Fix lint

* Tweak bulk upload error row component tests for year changes

* Further fixes

* Fix 2023 lettings row parser spec

* Sales log to csv fix

* Refactor BU processor tests

* Fix field number row identifier

* Fix linting

* More years in request spec

* fix

* Don't use db unnecessarily in financial validations spec

* Fix sale date changing 2024 -> 2023 test

* Add tests for bulk_upload.year_combo

* Update bu factory year specification

* Refactoring

* Linting

* Don't use helper in factory

* Remove new 2023 specific test

* Remove dummy end dates

lettings_log_to_csv.rb

CLDC-3505: Fix tests for hard year end part 4 (#2509)

sales_log_to_csv.rb

CLDC-3505: Fix tests for hard year end part 4 (#2509)