submit-social-housing-lettings-and-sales-data

Submit social housing lettings and sales data (CORE)

core

Phil Lee 903cf81749 CLDC-2305 Bulk upload setup fields validations (#1633 An error occurred ) # Context - https://digital.dclg.gov.uk/jira/browse/CLDC-2305 - This is rework to add missing validations for sales setup fields for bulk upload # Changes - There is code that clears log fields if they are not a valid option. in order to generate errors for these we check certain fields for content prior to `log.valid?` being called. Unfortunately there does not appear to be an easy way to access to valid options therefore these values have been hard coded - Privacy notice must be accepted other considered a setup error - The `type` question can actually be one of three questions with the same identifier. these are excluded as part of `validate_valid_radio_option` and instead validated with a different mechanism. The rationale being that `log.valid?` will clear data before we get there - Remove tests associated to upload threshold which are no longer required	2 years ago
..
devise.en.yml	Fix sign in validation error copy (#831 An error occurred )	3 years ago
en.yml	CLDC-2305 Bulk upload setup fields validations (#1633 An error occurred )	2 years ago

CLDC-2305 Bulk upload setup fields validations (#1633)

# Context

- https://digital.dclg.gov.uk/jira/browse/CLDC-2305
- This is rework to add missing validations for sales setup fields for bulk upload

# Changes

- There is code that clears log fields if they are not a valid option. in order to generate errors for these we check certain fields for content prior to `log.valid?` being called. Unfortunately there does not appear to be an easy way to access to valid options therefore these values have been hard coded
- Privacy notice must be accepted other considered a setup error
- The `type` question can actually be one of three questions with the same identifier. these are excluded as part of `validate_valid_radio_option` and instead validated with a different mechanism. The rationale being that `log.valid?` will clear data before we get there
- Remove tests associated to upload threshold which are no longer required

devise.en.yml

Fix sign in validation error copy (#831)

en.yml

CLDC-2305 Bulk upload setup fields validations (#1633)