Browse Source

explicitly write out years for clarity

pull/3074/head
Samuel 4 months ago
parent
commit
0066a2a712
  1. 4
      app/models/form/sales/questions/managing_organisation.rb
  2. 2
      app/models/form/sales/questions/owning_organisation_id.rb
  3. 2
      app/models/form/sales/questions/sale_date.rb

4
app/models/form/sales/questions/managing_organisation.rb

@ -4,7 +4,7 @@ class Form::Sales::Questions::ManagingOrganisation < ::Form::Question
@id = "managing_organisation_id" @id = "managing_organisation_id"
@derived = true @derived = true
@type = "select" @type = "select"
@question_number = 2 @question_number = QUESTION_NUMBER_FROM_YEAR[form.start_date.year] || QUESTION_NUMBER_FROM_YEAR[QUESTION_NUMBER_FROM_YEAR.keys.max]
end end
def answer_options(log = nil, user = nil) def answer_options(log = nil, user = nil)
@ -71,4 +71,6 @@ private
def selected_answer_option_is_derived?(_log) def selected_answer_option_is_derived?(_log)
true true
end end
QUESTION_NUMBER_FROM_YEAR = { 2024 => 2, 2025 => 2 }.freeze
end end

2
app/models/form/sales/questions/owning_organisation_id.rb

@ -93,5 +93,5 @@ private
"#{name} (inactive as of #{merge_date.to_fs(:govuk_date)})" "#{name} (inactive as of #{merge_date.to_fs(:govuk_date)})"
end end
QUESTION_NUMBER_FROM_YEAR = { 2023 => nil, 2024 => 1 }.freeze QUESTION_NUMBER_FROM_YEAR = { 2023 => nil, 2024 => 1, 2025 => 1 }.freeze
end end

2
app/models/form/sales/questions/sale_date.rb

@ -6,5 +6,5 @@ class Form::Sales::Questions::SaleDate < ::Form::Question
@question_number = QUESTION_NUMBER_FROM_YEAR[form.start_date.year] || QUESTION_NUMBER_FROM_YEAR[QUESTION_NUMBER_FROM_YEAR.keys.max] @question_number = QUESTION_NUMBER_FROM_YEAR[form.start_date.year] || QUESTION_NUMBER_FROM_YEAR[QUESTION_NUMBER_FROM_YEAR.keys.max]
end end
QUESTION_NUMBER_FROM_YEAR = { 2023 => 1, 2024 => 3 }.freeze QUESTION_NUMBER_FROM_YEAR = { 2023 => 1, 2024 => 3, 2025 => 3 }.freeze
end end

Loading…
Cancel
Save