Browse Source

feat: add postcode and location to fields which determine duplicates

bulk-upload-duplicates-bkup
Sam Seed 2 years ago
parent
commit
1ba43dfe85
  1. 6
      app/services/bulk_upload/lettings/row_parser.rb
  2. 3
      spec/services/bulk_upload/lettings/row_parser_spec.rb

6
app/services/bulk_upload/lettings/row_parser.rb

@ -242,6 +242,8 @@ private
owning_organisation
tcharge
propcode
postcode_full
location
]
end
@ -453,6 +455,8 @@ private
if log_already_exists?
error_message = "This is a duplicate log"
errors.add(:field_5, error_message) # location
errors.add(:field_12, error_message) # age1
errors.add(:field_20, error_message) # sex1
errors.add(:field_35, error_message) # ecstat1
@ -464,6 +468,8 @@ private
errors.add(:field_98, error_message) # startdate
errors.add(:field_100, error_message) # propcode
errors.add(:field_108, error_message) # postcode_full
errors.add(:field_109, error_message) # postcode_full
errors.add(:field_111, error_message) # owning_organisation
end
end

3
spec/services/bulk_upload/lettings/row_parser_spec.rb

@ -225,6 +225,7 @@ RSpec.describe BulkUpload::Lettings::RowParser do
error_message = "This is a duplicate log"
expected_errors = {
field_5: [error_message], # location
field_12: [error_message], # age1
field_20: [error_message], # sex1
field_35: [error_message], # ecstat1
@ -233,6 +234,8 @@ RSpec.describe BulkUpload::Lettings::RowParser do
field_97: [error_message], # startdate
field_98: [error_message], # startdate
field_100: [error_message], # propcode
field_108: [error_message], # postcode_full
field_109: [error_message], # postcode_full
field_111: [error_message], # owning_organisation
}
expect(parser.errors.as_json).to eq(expected_errors)

Loading…
Cancel
Save