Browse Source

fix bulk upload summary error ordering (#1562)

pull/1566/head
Phil Lee 2 years ago committed by GitHub
parent
commit
210a25eaf5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      app/views/bulk_upload_lettings_results/summary.html.erb
  2. 20
      spec/views/bulk_upload_lettings_results/summary.html.erb_spec.rb

2
app/views/bulk_upload_lettings_results/summary.html.erb

@ -20,7 +20,7 @@
<% end %> <% end %>
<% c.with_tab(label: "Full error report") do %> <% c.with_tab(label: "Full error report") do %>
<% @bulk_upload.bulk_upload_errors.group_by(&:row).each do |_row, errors_for_row| %> <% @bulk_upload.bulk_upload_errors.order_by_cell.group_by(&:row).each do |_row, errors_for_row| %>
<%= render BulkUploadErrorRowComponent.new(bulk_upload_errors: errors_for_row) %> <%= render BulkUploadErrorRowComponent.new(bulk_upload_errors: errors_for_row) %>
<% end %> <% end %>
<% end %> <% end %>

20
spec/views/bulk_upload_lettings_results/summary.html.erb_spec.rb

@ -0,0 +1,20 @@
require "rails_helper"
RSpec.describe "bulk_upload_lettings_results/summary.html.erb" do
let(:bulk_upload) { create(:bulk_upload, :lettings) }
before do
create(:bulk_upload_error, bulk_upload:, cell: "AA100", row: "100", col: "AA")
create(:bulk_upload_error, bulk_upload:, cell: "Z100", row: "100", col: "Z")
end
it "renders errors ordered by cell" do
assign(:bulk_upload, bulk_upload)
render
fragment = Capybara::Node::Simple.new(rendered)
expect(fragment.find_css("table tbody th").map(&:inner_text)).to eql(%w[Z100 AA100])
end
end
Loading…
Cancel
Save