Browse Source

Remove illness_type_0 from lettings log (#1170)

pull/1172/head
Jack 2 years ago committed by GitHub
parent
commit
23e311721f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 1
      app/services/imports/lettings_logs_import_service.rb
  2. 3
      config/forms/2021_2022.json
  3. 3
      config/forms/2022_2023.json
  4. 1
      spec/fixtures/complete_lettings_log.json
  5. 2
      spec/services/csv/lettings_log_csv_service_spec.rb

1
app/services/imports/lettings_logs_import_service.rb

@ -126,7 +126,6 @@ module Imports
(1..10).each do |index|
attributes["illness_type_#{index}"] = illness_type(xml_doc, index, attributes["illness"])
end
attributes["illness_type_0"] = 1 if (1..10).all? { |idx| attributes["illness_type_#{idx}"].nil? || attributes["illness_type_#{idx}"].zero? }
attributes["prevten"] = unsafe_string_as_integer(xml_doc, "Q11")
attributes["prevloc"] = string_or_nil(xml_doc, "Q12aONS")

3
config/forms/2021_2022.json

@ -6047,9 +6047,6 @@
},
"illness_type_10": {
"value": "Other"
},
"illness_type_0": {
"value": "Tenant prefers not to say"
}
}
}

3
config/forms/2022_2023.json

@ -6049,9 +6049,6 @@
},
"illness_type_10": {
"value": "Other"
},
"illness_type_0": {
"value": "Tenant prefers not to say"
}
}
}

1
spec/fixtures/complete_lettings_log.json vendored

@ -166,7 +166,6 @@
"old_id": null,
"joint": null,
"created_by_id": 2,
"illness_type_0":null,
"retirement_value_check": null,
"tshortfall_known": null,
"sheltered": null,

2
spec/services/csv/lettings_log_csv_service_spec.rb

@ -121,7 +121,6 @@ RSpec.describe Csv::LettingsLogCsvService do
illness_type_8
illness_type_1
illness_type_10
illness_type_0
layear
waityear
reason
@ -197,6 +196,7 @@ RSpec.describe Csv::LettingsLogCsvService do
irproduct
old_id
joint
illness_type_0
hhtype
new_old
vacdays

Loading…
Cancel
Save