Browse Source

Update request tests

pull/2924/head
Manny Dinssa 2 months ago
parent
commit
24562a2826
  1. 1
      app/models/derived_variables/lettings_log_variables.rb
  2. 3
      app/models/log.rb
  3. 2
      spec/factories/lettings_log.rb
  4. 2
      spec/requests/address_search_controller_spec.rb

1
app/models/derived_variables/lettings_log_variables.rb

@ -116,6 +116,7 @@ module DerivedVariables::LettingsLogVariables
if manual_address_entry_selected if manual_address_entry_selected
self.uprn_known = 0 self.uprn_known = 0
self.uprn_selection = nil self.uprn_selection = nil
self.uprn_confirmed = nil
else else
self.uprn_confirmed = 1 if uprn.present? self.uprn_confirmed = 1 if uprn.present?
self.uprn_known = 1 if uprn.present? self.uprn_known = 1 if uprn.present?

3
app/models/log.rb

@ -75,8 +75,7 @@ class Log < ApplicationRecord
presenter = UprnDataPresenter.new(service.result) presenter = UprnDataPresenter.new(service.result)
self.uprn_known = 1 self.uprn_known = 1
# self.uprn_confirmed = nil unless skip_update_uprn_confirmed TODO: REMOVE self.uprn_selection = uprn
self.uprn_selection = nil
self.address_line1 = presenter.address_line1 self.address_line1 = presenter.address_line1
self.address_line2 = presenter.address_line2 self.address_line2 = presenter.address_line2
self.town_or_city = presenter.town_or_city self.town_or_city = presenter.town_or_city

2
spec/factories/lettings_log.rb

@ -173,7 +173,7 @@ FactoryBot.define do
log.postcode_full_input = log.postcode_full log.postcode_full_input = log.postcode_full
log.nationality_all_group = 826 log.nationality_all_group = 826
log.uprn = evaluator.uprn || "10033558653" log.uprn = evaluator.uprn || "10033558653"
log.uprn_selection = evaluator.uprn_selection || "1" log.uprn_selection = evaluator.uprn_selection || "10033558653"
end end
end end
end end

2
spec/requests/address_search_controller_spec.rb

@ -50,7 +50,7 @@ RSpec.describe AddressSearchController, type: :request do
expect(lettings_log.uprn_known).to eq(1) expect(lettings_log.uprn_known).to eq(1)
expect(lettings_log.uprn).to eq("10033558653") expect(lettings_log.uprn).to eq("10033558653")
expect(lettings_log.uprn_confirmed).to eq(1) expect(lettings_log.uprn_confirmed).to eq(1)
expect(lettings_log.uprn_selection).to eq(nil) expect(lettings_log.uprn_selection).to eq("10033558653")
expect(lettings_log.postcode_known).to eq(1) expect(lettings_log.postcode_known).to eq(1)
expect(lettings_log.postcode_full).to eq("SW1A 1AA") expect(lettings_log.postcode_full).to eq("SW1A 1AA")
expect(lettings_log.address_line1).to eq("The Mall, City Of Westminster") expect(lettings_log.address_line1).to eq("The Mall, City Of Westminster")

Loading…
Cancel
Save