Browse Source

remove unused variable

pull/2995/head
Carolyn 2 months ago
parent
commit
2e3730c597
  1. 4
      app/models/validations/setup_validations.rb
  2. 2
      app/models/validations/shared_validations.rb

4
app/models/validations/setup_validations.rb

@ -102,7 +102,7 @@ module Validations::SetupValidations
location_inactive_status = inactive_status(record.startdate, record.location)
if location_inactive_status.present?
date, scope, deactivation_date = location_inactive_status.values_at(:date, :scope, :deactivation_date)
date, scope = location_inactive_status.values_at(:date, :scope)
record.errors.add :startdate, :not_active, message: I18n.t("validations.lettings.setup.startdate.location.#{scope}.startdate", postcode: record.location.postcode, date:, deactivation_date:)
record.errors.add :location_id, :not_active, message: I18n.t("validations.lettings.setup.startdate.location.#{scope}.location_id", postcode: record.location.postcode, date:, deactivation_date:)
record.errors.add :scheme_id, :not_active, message: I18n.t("validations.lettings.setup.startdate.location.#{scope}.location_id", postcode: record.location.postcode, date:, deactivation_date:)
@ -115,7 +115,7 @@ module Validations::SetupValidations
scheme_inactive_status = inactive_status(record.startdate, record.scheme)
if scheme_inactive_status.present?
date, scope, deactivation_date = scheme_inactive_status.values_at(:date, :scope, :deactivation_date)
date, scope = scheme_inactive_status.values_at(:date, :scope)
record.errors.add :startdate, I18n.t("validations.lettings.setup.startdate.scheme.#{scope}.startdate", name: record.scheme.service_name, date:, deactivation_date:)
record.errors.add :scheme_id, I18n.t("validations.lettings.setup.startdate.scheme.#{scope}.scheme_id", name: record.scheme.service_name, date:, deactivation_date:)
end

2
app/models/validations/shared_validations.rb

@ -86,7 +86,7 @@ module Validations::SharedValidations
when :deactivated then open_deactivation.deactivation_date
end
{ scope: status, date: date&.to_formatted_s(:govuk_date), deactivation_date: closest_reactivation&.deactivation_date&.to_formatted_s(:govuk_date) }
{ scope: status, date: date&.to_formatted_s(:govuk_date) }
end
def date_valid?(question, record)

Loading…
Cancel
Save