Browse Source

CLDC-1058: fix landmark semantic errors

pull/366/head
kiddhustle 3 years ago
parent
commit
2fdd4667be
  1. 6
      app/views/case_logs/_log_list.html.erb
  2. 3
      app/views/layouts/application.html.erb

6
app/views/case_logs/_log_list.html.erb

@ -1,8 +1,8 @@
<figure class="app-figure"> <figure class="app-figure">
<figcaption id="<%= title.dasherize %>" class="app-figure__caption"> <figcaption id="<%= title.dasherize %>" class="app-figure__caption">
<b><%= case_logs.size %></b> <%= title.downcase %> <strong><%= case_logs.size %></strong> <%= title.downcase %>
</figcaption> </figcaption>
<div class="app-table-group" tabindex="0" aria-labelledby="<%= title.dasherize %>"> <section class="app-table-group" tabindex="0" aria-labelledby="<%= title.dasherize %>">
<table class="govuk-table"> <table class="govuk-table">
<thead class="govuk-table__head"> <thead class="govuk-table__head">
<tr class="govuk-table__row"> <tr class="govuk-table__row">
@ -42,5 +42,5 @@
<% end %> <% end %>
</tbody> </tbody>
</table> </table>
</div> </section>
</figure> </figure>

3
app/views/layouts/application.html.erb

@ -52,13 +52,14 @@
%> %>
<div class="govuk-width-container"> <div class="govuk-width-container">
<aside>
<%= govuk_phase_banner( <%= govuk_phase_banner(
tag: { text: 'Beta' }, tag: { text: 'Beta' },
text: "This is a new service – #{govuk_mail_to("submitcoredata@levellingup.gov.uk", "give feedback or report a problem", subject: "Feedback about #{t('service_name')}")}".html_safe text: "This is a new service – #{govuk_mail_to("submitcoredata@levellingup.gov.uk", "give feedback or report a problem", subject: "Feedback about #{t('service_name')}")}".html_safe
) %> ) %>
<%= content_for(:breadcrumbs) %> <%= content_for(:breadcrumbs) %>
<%= content_for(:before_content) %> <%= content_for(:before_content) %>
</aside>
<main class="govuk-main-wrapper" id="main-content" role="main"> <main class="govuk-main-wrapper" id="main-content" role="main">
<% if flash.notice && !flash.notice.include?('translation missing') %> <% if flash.notice && !flash.notice.include?('translation missing') %>

Loading…
Cancel
Save