Browse Source

feat: update tests

CLDC-2632.2-set-uprn-known-no
natdeanlewissoftwire 1 year ago
parent
commit
3c14f8448c
  1. 6
      app/models/derived_variables/lettings_log_variables.rb
  2. 4
      spec/models/form/lettings/questions/uprn_spec.rb

6
app/models/derived_variables/lettings_log_variables.rb

@ -95,7 +95,7 @@ module DerivedVariables::LettingsLogVariables
set_housingneeds_fields if housingneeds? set_housingneeds_fields if housingneeds?
self.uprn_known = 0 if address_answered? self.uprn_known = 0 if address_answered_without_uprn?
if uprn_known&.zero? if uprn_known&.zero?
self.uprn = nil self.uprn = nil
@ -312,8 +312,8 @@ private
self.county = nil self.county = nil
end end
def address_answered? def address_answered_without_uprn?
[address_line1, town_or_city].all?(&:present?) [address_line1, town_or_city].all?(&:present?) && uprn.nil?
end end
def get_lar def get_lar

4
spec/models/form/lettings/questions/uprn_spec.rb

@ -62,11 +62,13 @@ RSpec.describe Form::Lettings::Questions::Uprn, type: :model do
postcode_full: "AA1 1AA", postcode_full: "AA1 1AA",
la: "E09000003", la: "E09000003",
uprn_known:, uprn_known:,
uprn:,
) )
end end
context "when uprn known nil" do context "when uprn known nil" do
let(:uprn_known) { nil } let(:uprn_known) { nil }
let(:uprn) { nil }
it "returns formatted value" do it "returns formatted value" do
expect(question.get_extra_check_answer_value(log)).to be_nil expect(question.get_extra_check_answer_value(log)).to be_nil
@ -75,6 +77,7 @@ RSpec.describe Form::Lettings::Questions::Uprn, type: :model do
context "when uprn known" do context "when uprn known" do
let(:uprn_known) { 1 } let(:uprn_known) { 1 }
let(:uprn) { 123456789 }
it "returns formatted value" do it "returns formatted value" do
expect(question.get_extra_check_answer_value(log)).to eq( expect(question.get_extra_check_answer_value(log)).to eq(
@ -85,6 +88,7 @@ RSpec.describe Form::Lettings::Questions::Uprn, type: :model do
context "when uprn not known" do context "when uprn not known" do
let(:uprn_known) { 0 } let(:uprn_known) { 0 }
let(:uprn) { nil }
it "returns formatted value" do it "returns formatted value" do
expect(question.get_extra_check_answer_value(log)).to be_nil expect(question.get_extra_check_answer_value(log)).to be_nil

Loading…
Cancel
Save