Browse Source

PR accessibility comments

pull/215/head
baarkerlounger 3 years ago
parent
commit
47f28a4a55
  1. 2
      app/helpers/tasklist_helper.rb
  2. 7
      app/views/case_logs/_tasklist.html.erb

2
app/helpers/tasklist_helper.rb

@ -37,7 +37,7 @@ module TasklistHelper
def subsection_link(subsection, case_log) def subsection_link(subsection, case_log)
if subsection.status(case_log) != :cannot_start_yet if subsection.status(case_log) != :cannot_start_yet
next_page_path = first_page_or_check_answers(subsection, case_log).to_s next_page_path = first_page_or_check_answers(subsection, case_log).to_s
govuk_link_to(subsection.label, next_page_path.dasherize, class: "task-name") govuk_link_to(subsection.label, next_page_path.dasherize, aria: { describedby: subsection.id.dasherize })
else else
subsection.label subsection.label
end end

7
app/views/case_logs/_tasklist.html.erb

@ -8,10 +8,13 @@
</h2> </h2>
<ul class="app-task-list__items"> <ul class="app-task-list__items">
<% section.subsections.map do |subsection| %> <% section.subsections.map do |subsection| %>
<li class="app-task-list__item" id=<%= subsection.id %>>
<% subsection_status = subsection.status(@case_log) %> <% subsection_status = subsection.status(@case_log) %>
<li class="app-task-list__item">
<span class="app-task-list__task-name">
<%= subsection_link(subsection, @case_log) %> <%= subsection_link(subsection, @case_log) %>
<strong class="govuk-tag app-task-list__tag <%= TasklistHelper::STYLES[subsection_status] %>"> </span>
<strong class="govuk-tag app-task-list__tag <%= TasklistHelper::STYLES[subsection_status] %>"
id=<%= subsection.id.dasherize %>>
<%= TasklistHelper::STATUSES[subsection_status] %> <%= TasklistHelper::STATUSES[subsection_status] %>
</strong> </strong>
</li> </li>

Loading…
Cancel
Save