Browse Source
* remove question no longer needed and associated test file * amend page and the other question in that page that determined whether the deleted question should be shown update associated test files * createa a migration to remove the column for the deleted question * update test broken by changes * fix test broken by changespull/1409/head
Arthur Campbell
2 years ago
committed by
GitHub
10 changed files with 28 additions and 101 deletions
@ -1,10 +0,0 @@
|
||||
class Form::Sales::Questions::OtherNationality1 < ::Form::Question |
||||
def initialize(id, hsh, page) |
||||
super |
||||
@id = "othernational" |
||||
@check_answer_label = "Buyer 1’s nationality" |
||||
@header = "Nationality" |
||||
@type = "text" |
||||
@check_answers_card_number = 1 |
||||
end |
||||
end |
@ -0,0 +1,5 @@
|
||||
class RemoveOthernationalFromSalesLogs < ActiveRecord::Migration[7.0] |
||||
def change |
||||
remove_column :sales_logs, :othernational, :string |
||||
end |
||||
end |
@ -1,41 +0,0 @@
|
||||
require "rails_helper" |
||||
|
||||
RSpec.describe Form::Sales::Questions::OtherNationality1, type: :model do |
||||
subject(:question) { described_class.new(question_id, question_definition, page) } |
||||
|
||||
let(:question_id) { nil } |
||||
let(:question_definition) { nil } |
||||
let(:page) { instance_double(Form::Page) } |
||||
|
||||
it "has correct page" do |
||||
expect(question.page).to eq(page) |
||||
end |
||||
|
||||
it "has the correct id" do |
||||
expect(question.id).to eq("othernational") |
||||
end |
||||
|
||||
it "has the correct header" do |
||||
expect(question.header).to eq("Nationality") |
||||
end |
||||
|
||||
it "has the correct check_answer_label" do |
||||
expect(question.check_answer_label).to eq("Buyer 1’s nationality") |
||||
end |
||||
|
||||
it "has the correct type" do |
||||
expect(question.type).to eq("text") |
||||
end |
||||
|
||||
it "is not marked as derived" do |
||||
expect(question.derived?).to be false |
||||
end |
||||
|
||||
it "has the correct hint" do |
||||
expect(question.hint_text).to be_nil |
||||
end |
||||
|
||||
it "has the correct check_answers_card_number" do |
||||
expect(question.check_answers_card_number).to eq(1) |
||||
end |
||||
end |
Loading…
Reference in new issue