Please the cop

app/models/form/question.rb

@@ -121,7 +121,7 @@ class Form::Question
     when "radio"
       RADIO_YES_VALUE[id.to_sym]&.include?(value)
     else
-      value.downcase == "yes"
+      %w[yes].include?(value.downcase)
     end
   end
 
@@ -132,7 +132,7 @@ class Form::Question
     when "radio"
       RADIO_NO_VALUE[id.to_sym]&.include?(value)
     else
-      value.downcase == "no"
+      %w[no].include?(value.downcase)
     end
   end
 

app/models/validations/household_validations.rb

@@ -7,7 +7,7 @@ module Validations::HouseholdValidations
     if record.is_not_homeless? && record.given_reasonable_preference?
       record.errors.add :reasonpref, I18n.t("validations.household.reasonpref.not_homeless")
       record.errors.add :homeless, I18n.t("validations.household.homeless.reasonpref.not_homeless")
-    elsif record.reasonpref == 1
+    elsif !record.given_reasonable_preference?
       if [record.rp_homeless, record.rp_insan_unsat, record.rp_medwel, record.rp_hardship, record.rp_dontknow].any? { |a| a == 1 }
         record.errors.add :reasonable_preference_reason, I18n.t("validations.household.reasonable_preference_reason.reason_not_required")
       end

app/models/validations/property_validations.rb

@@ -55,7 +55,7 @@ module Validations::PropertyValidations
                        E09000032
                        E09000033].freeze
   def validate_la(record)
-    if record.la.present? && !LONDON_BOROUGHS.include?(record.la) && (record.is_london_rent?)
+    if record.la.present? && !LONDON_BOROUGHS.include?(record.la) && record.is_london_rent?
       record.errors.add :la, I18n.t("validations.property.la.london_rent")
     end
 

spec/models/form/question_spec.rb

@@ -46,15 +46,15 @@ RSpec.describe Form::Question, type: :model do
   end
 
   it "has a yes value helper" do
-    expect(question.value_is_yes?("Yes")).to be_truthy
+    expect(question).to be_value_is_yes("Yes")
-    expect(question.value_is_yes?("YES")).to be_truthy
+    expect(question).to be_value_is_yes("YES")
-    expect(question.value_is_yes?("random")).to be_falsey
+    expect(question).not_to be_value_is_yes("random")
   end
 
   it "has a no value helper" do
-    expect(question.value_is_no?("No")).to be_truthy
+    expect(question).to be_value_is_no("No")
-    expect(question.value_is_no?("NO")).to be_truthy
+    expect(question).to be_value_is_no("NO")
-    expect(question.value_is_no?("random")).to be_falsey
+    expect(question).not_to be_value_is_no("random")
   end
 
   context "when type is numeric" do