CLDC-3280: Make read only error report opt-in

this means we can be happy only the touched pages will have a change in behaviour

app/models/forms/bulk_upload_resume/confirm.rb

@@ -20,11 +20,11 @@ module Forms
         send("resume_bulk_upload_#{log_type}_result_path", bulk_upload)
       end
 
-      def error_report_path
+      def error_report_path(read_only: false)
         if BulkUploadErrorSummaryTableComponent.new(bulk_upload:).errors?
-          send("summary_bulk_upload_#{log_type}_result_path", bulk_upload, hide_upload_button: "true")
+          send("summary_bulk_upload_#{log_type}_result_path", bulk_upload, hide_upload_button: read_only ? "true" : nil)
         else
-          send("bulk_upload_#{log_type}_result_path", bulk_upload, hide_upload_button: "true")
+          send("bulk_upload_#{log_type}_result_path", bulk_upload, hide_upload_button: read_only ? "true" : nil)
         end
       end
 

app/models/forms/bulk_upload_resume/fix_choice.rb

@@ -34,11 +34,11 @@ module Forms
         end
       end
 
-      def error_report_path
+      def error_report_path(read_only: false)
         if BulkUploadErrorSummaryTableComponent.new(bulk_upload:).errors?
-          send("summary_bulk_upload_#{log_type}_result_path", bulk_upload, hide_upload_button: "true")
+          send("summary_bulk_upload_#{log_type}_result_path", bulk_upload, hide_upload_button: read_only ? "true" : nil)
         else
-          send("bulk_upload_#{log_type}_result_path", bulk_upload, hide_upload_button: "true")
+          send("bulk_upload_#{log_type}_result_path", bulk_upload, hide_upload_button: read_only ? "true" : nil)
         end
       end
 

app/views/bulk_upload_lettings_resume/confirm.html.erb

@@ -9,7 +9,7 @@
 
     <p class="govuk-body">
       <%= logs_and_errors_warning(@bulk_upload) %>
-      <%= govuk_link_to "View the error report", @form.error_report_path %>
+      <%= govuk_link_to "View the error report", @form.error_report_path(read_only: true) %>
     </p>
 
     <% if unique_answers_to_be_cleared(@bulk_upload).present? %>

app/views/bulk_upload_lettings_resume/fix_choice.html.erb

@@ -19,7 +19,7 @@
       </div>
 
       <div class="govuk-body">
-        <%= govuk_link_to "View the error report", @form.error_report_path %>
+        <%= govuk_link_to "View the error report", @form.error_report_path(read_only: true) %>
       </div>
 
       <%= govuk_details(summary_text: "How to choose between fixing errors on the CORE site or in the CSV") do %>

app/views/bulk_upload_sales_resume/confirm.html.erb

@@ -9,7 +9,7 @@
 
     <p class="govuk-body">
       <%= logs_and_errors_warning(@bulk_upload) %>
-      <%= govuk_link_to "View the error report", @form.error_report_path %>
+      <%= govuk_link_to "View the error report", @form.error_report_path(read_only: true) %>
     </p>
 
     <% if unique_answers_to_be_cleared(@bulk_upload).present? %>

app/views/bulk_upload_sales_resume/fix_choice.html.erb

@@ -19,7 +19,7 @@
       </div>
 
       <div class="govuk-body">
-        <%= govuk_link_to "View the error report", @form.error_report_path %>
+        <%= govuk_link_to "View the error report", @form.error_report_path(read_only: true) %>
       </div>
 
       <%= govuk_details(summary_text: "How to choose between fixing errors on the CORE site or in the CSV") do %>