Cldc 1361 only stock owning orgs see schemes (#838)

* only stock owning orgs see schemes in nav bar

* lint

* added to organisation factory and fixed tests

* removed schemes from secondary navigation bar for non stock owning orgs

* test

* lint

* remove factory la

app/helpers/navigation_items_helper.rb

@@ -26,12 +26,20 @@ module NavigationItemsHelper
   end
 
   def secondary_items(path, current_organisation_id)
-    [
+    if current_user.organisation.holds_own_stock?
-      NavigationItem.new("Logs", "/organisations/#{current_organisation_id}/logs", subnav_logs_path?(path)),
+      [
-      NavigationItem.new("Schemes", "/organisations/#{current_organisation_id}/schemes", subnav_supported_housing_schemes_path?(path)),
+        NavigationItem.new("Logs", "/organisations/#{current_organisation_id}/logs", subnav_logs_path?(path)),
-      NavigationItem.new("Users", "/organisations/#{current_organisation_id}/users", subnav_users_path?(path)),
+        NavigationItem.new("Schemes", "/organisations/#{current_organisation_id}/schemes", subnav_supported_housing_schemes_path?(path)),
-      NavigationItem.new("About this organisation", "/organisations/#{current_organisation_id}", subnav_details_path?(path)),
+        NavigationItem.new("Users", "/organisations/#{current_organisation_id}/users", subnav_users_path?(path)),
-    ]
+        NavigationItem.new("About this organisation", "/organisations/#{current_organisation_id}", subnav_details_path?(path)),
+      ]
+    else
+      [
+        NavigationItem.new("Logs", "/organisations/#{current_organisation_id}/logs", subnav_logs_path?(path)),
+        NavigationItem.new("Users", "/organisations/#{current_organisation_id}/users", subnav_users_path?(path)),
+        NavigationItem.new("About this organisation", "/organisations/#{current_organisation_id}", subnav_details_path?(path)),
+      ]
+    end
   end
 
   def scheme_items(path, current_scheme_id, title)

spec/features/organisation_spec.rb

@@ -61,6 +61,18 @@ RSpec.describe "User Features" do
           expect(page).to have_link("Schemes", href: "/schemes")
         end
       end
+
+      context "when the user is support and the organisation does not hold housing stock" do
+        before do
+          organisation.update!(holds_own_stock: false)
+          user.update!(role: "support")
+        end
+
+        it "does not show schemes in the primary or secondary navigation bar on the organisations page" do
+          visit("/organisations")
+          expect(page).not_to have_link("Schemes", href: "/schemes", count: 2)
+        end
+      end
     end
 
     context "when users are part of organisation" do