update docs

docs/form/form.md

@@ -3,7 +3,7 @@
 The current system is built around a form definition written in JSON. At the top level every form will expect to have the following attributes:
 
 - Form type: this is to define whether the form is a lettings form or a sales form. The questions will differ between the types.
-- Start date: the start of the collection window for the form, this will usually be in April
+- Start date: the start of the collection window for the form, this will usually be in April.
 - End date: the end date of the collection window for the form, this will usually be in July, a year after the start date.
 - Sections: the sections in the form, this block is where the bulk of the form definition will be.
 
@@ -19,7 +19,7 @@ An example of this might look like the following:
 }
 ```
 
-Note that the end date of one form will overlap the start date of another to allow for late submissions. This means that every year there will be a period of time in which two forms are running simultaneously
+Note that the end date of one form will overlap the start date of another to allow for late submissions. This means that every year there will be a period of time in which two forms are running simultaneously.
 
 ### How is the form split up?
 
@@ -32,10 +32,10 @@ A summary of how the form is split up is as follows:
 
 More information about these form elements can be found in the following links:
 
-- Section
-- Subsections
-- Page
-- Question
+- [Section](docs/form/section.md)
+- [Subsection](docs/form/subsection.md)
+- [Page](docs/form/page.md)
+- [Question](docs/form/question.md)
 
 ### The Form Model, Views and Controller
 

docs/form/page.md

@@ -17,12 +17,12 @@ Pages are under the subsection level of the form definition. A example page migh
 }
 ```
 
-In the above example the the subsection has the id `property_postcode`. This id is used for the url of the web page, but the underscore is replaced with a hash, so the url for this page would be `[environment-url]/logs/[log-id]/property-postcode` e.g. on staging this url might look like the following: `https://dluhc-core-staging.london.cloudapps.digital/logs/1234/property-postcode`
+In the above example the the subsection has the id `property_postcode`. This id is used for the url of the web page, but the underscore is replaced with a hash, so the url for this page would be `[environment-url]/logs/[log-id]/property-postcode` e.g. on staging this url might look like the following: `https://dluhc-core-staging.london.cloudapps.digital/logs/1234/property-postcode`.
 
-The header is optional but if provided is used for the heading displayed on the page
+The header is optional but if provided is used for the heading displayed on the page.
 
-The description is optional but if provided is used for a paragraph displayed under the page header
+The description is optional but if provided is used for a paragraph displayed under the page header.
 
 It's worth noting that like subsections a page can also have a `depends_on` which contains the set of conditions that must be met for the section to be accessibile to a data provider. If the conditions are not met then the page is not routed to as part of the form flow. The `depends_on` for a page will usually depend on answers given to questions, most likely to be questions in the setup section. In the above example the page is dependent on the answer to the `needstype` question being `1`, which corresponds to picking `General needs` on that question as displayed to the data provider.
 
-
+Pages can contain one or more questions.

docs/form/question.md

@@ -0,0 +1,82 @@
+## Question
+
+Questions are under the page level of the form definition. A example question might look something like this:
+
+```JSON
+"postcode_known": {
+  "check_answer_label": "Do you know the property postcode?",
+  "header": "Do you know the property’s postcode?",
+  "hint_text": "",
+  "type": "radio",
+  "answer_options": {
+    "1": {
+      "value": "Yes"
+    },
+    "0": {
+      "value": "No"
+    }
+  },
+  "conditional_for": {
+    "postcode_full": [1]
+  },
+  "hidden_in_check_answers": true
+}
+```
+
+In the above example the the question has the id `postcode_known`. 
+
+The `check_answer_label` contains the text that will be displayed in the label of the table on the check answers page.
+
+The header is text that is displayed for the question. 
+
+Hint text is optional, but if provided it sits under the header and is normally given to provide the data inputters with guidance when answering the question, for example it might inform them about terms used in the question.
+
+The type is question type, which is used to determine the view rendered for the question. In the above example the question is a radio type so the `app/views/form/_radio_question.html.erb` partial will be rendered on the page when this question is displayed to the user.
+
+The `conditional_for` contains the value needed to be selected by the data inputter in order to display another question that appears on the same page. In the example above the `postcode_full` question depends on the answer to `postcode_known` being selected as `1` or `Yes`, this would then display the `postcode_full` underneath the `Yes` option on the page, allowing the provide the provide the postcode if they have indicated they know it. If the user has JavaScript enabled then this realtime conditional display is handled by the `app/frontend/controllers/conditional_question_controller.js` file.
+
+the `hidden_in_check_answers` is used to hide a value from displaying on the check answers page. You only need to provide this if you want to set it to true in order to hide the value for some reason e.g. it's one of two questions appearing on a page and the other question is displayed on the check answers page. It's also worth noting that you can declare this as a with a `depends_on` which can be useful for conditionally displaying values on the check answers page. For example: 
+
+```JSON
+"hidden_in_check_answers": {
+  "depends_on": [
+    {
+      "age6_known": 0
+    },
+    {
+      "age6_known": 1
+    }
+  ]
+}
+```
+
+Would mean the question the above is attached to would be hidden in the check answers page if the value of age6_known is either `0` or `1`.
+
+The answer the data inputter provides to some questions allows us to infer the values of other questions we might have asked in the form, allowing us to save the data inputters some time. An example of how this might look is as follows:
+
+```JSON
+"postcode_full": {
+  "check_answer_label": "Postcode",
+  "header": "What is the property’s postcode?",
+  "hint_text": "",
+  "type": "text",
+  "width": 5,
+  "inferred_answers": {
+    "la": {
+      "is_la_inferred": true
+    }
+  },
+  "inferred_check_answers_value": {
+    "condition": {
+      "postcode_known": 0
+    },
+    "value": "Not known"
+  }
+}
+```
+
+In the above example the width is an optional attribute and can be provided for text type questions to determine the width of the text box on the page when when the question is displayed to a user (this allows you to match the width of the text box on the page to that of the design for a question).
+
+The above example links to the first example as both of these questions would be on the same page. The `inferred_check_answers_value` is what should be displayed on the check answers page for this question if we infer it. If the value of `postcode_known` was given as `0` (which is a no), as seen in the condition part of `inferred_check_answers_value`  then we can infer that the data inputter does not know the postcode and so we would display the value of `Not known` on the check answers page for the postcode. 
+
+In the above example the `inferred_answers` refers to a question where we can infer the answer based on the answer of this question. In this case the `la` question can be inferred from the postcode value given by the data inputter as we are able to lookup the local authority based on the postcode given. We then set a property on the case log `is_la_inferred` to true to indicate that this is an answer we've inferred.

docs/form/section.md

@@ -23,4 +23,4 @@ In the above example the section id would be `tenancy_and_property` and its subs
 
 The label contains the text that users will see for that section in the tasklist page of a case log.
 
-Sections can contain one or more subsections. For more information about subsections follow this link.
+Sections can contain one or more subsections.

docs/form_builder.md

@@ -181,6 +181,10 @@ rake form_definition:validate_all
 
 This will validate all forms in directories `["config/forms", "spec/fixtures/forms"]`
 
+## Form models and definition
+
+For information about the form model and related models (section, subsection, page, question) and how these relate to each other follow [this link](docs/form/form.md)
+
 ## Improvements that could be made
 
 - JSON schema definition could be expanded such that we can better automatically validate that a given config is valid and internally consistent