baarkerlounger
/
submit-social-housing-lettings-and-sales-data
mirror of https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

don't block log creation on staircasing date errors

pull/3001/head
Carolyn 2 months ago
parent
13f231eb86
commit
8529932a01
1 changed files with 2 additions and 2 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 4
      app/models/validations/sales/sale_information_validations.rb

4
app/models/validations/sales/sale_information_validations.rb
Unescape View File

@ -44,7 +44,7 @@ module Validations::Sales::SaleInformationValidations
if record.saledate.present? && record.initialpurchase > record.saledate if record.saledate.present? && record.initialpurchase > record.saledate
record.errors.add :initialpurchase, I18n.t("validations.sales.sale_information.initialpurchase.must_be_before_saledate") record.errors.add :initialpurchase, I18n.t("validations.sales.sale_information.initialpurchase.must_be_before_saledate")
record.errors.add :saledate, I18n.t("validations.sales.sale_information.saledate.must_be_after_initial_purchase_date") record.errors.add :saledate, :skip_bu_error, I18n.t("validations.sales.sale_information.saledate.must_be_after_initial_purchase_date")
end end
end end
@ -57,7 +57,7 @@ module Validations::Sales::SaleInformationValidations
if record.saledate.present? && record.lasttransaction > record.saledate if record.saledate.present? && record.lasttransaction > record.saledate
record.errors.add :lasttransaction, I18n.t("validations.sales.sale_information.lasttransaction.must_be_before_saledate") record.errors.add :lasttransaction, I18n.t("validations.sales.sale_information.lasttransaction.must_be_before_saledate")
record.errors.add :saledate, I18n.t("validations.sales.sale_information.saledate.must_be_after_last_transaction_date") record.errors.add :saledate, :skip_bu_error, I18n.t("validations.sales.sale_information.saledate.must_be_after_last_transaction_date")
end end
if record.initialpurchase.present? && record.lasttransaction < record.initialpurchase if record.initialpurchase.present? && record.lasttransaction < record.initialpurchase
record.errors.add :initialpurchase, I18n.t("validations.sales.sale_information.initialpurchase.must_be_before_last_transaction") record.errors.add :initialpurchase, I18n.t("validations.sales.sale_information.initialpurchase.must_be_before_last_transaction")

Write Preview
Loading…
Cancel
Save