Fix remaining uprn

spec/models/form/lettings/questions/uprn_confirmation_spec.rb

@@ -50,7 +50,7 @@ RSpec.describe Form::Lettings::Questions::UprnConfirmation, type: :model do
 
     context "when address is present" do
       it "returns formatted value" do
-        log = create(:lettings_log, address_line1: "1, Test Street", town_or_city: "Test Town", county: "Test County", postcode_full: "AA1 1AA", uprn: "1234")
+        log = create(:lettings_log, address_line1: "1, Test Street", town_or_city: "Test Town", county: "Test County", postcode_full: "AA1 1AA", uprn: "1234", uprn_known: 1)
 
         expect(question.notification_banner(log)).to eq(
           {
@@ -80,9 +80,11 @@ RSpec.describe Form::Lettings::Questions::UprnConfirmation, type: :model do
     end
 
     context "when uprn_known != 1 && uprn_confirmed == 1" do
-      let(:log) { create(:lettings_log, uprn_known: 1, uprn_confirmed: 1) }
+      let(:log) { create(:lettings_log) }
 
       it "returns true" do
+        log.uprn_known = 1
+        log.uprn_confirmed = 1
         expect(question.hidden_in_check_answers?(log)).to eq(true)
       end
     end

spec/models/form/sales/questions/uprn_confirmation_spec.rb

@@ -50,7 +50,7 @@ RSpec.describe Form::Sales::Questions::UprnConfirmation, type: :model do
 
     context "when address is present" do
       it "returns formatted value" do
-        log = create(:sales_log, address_line1: "1, Test Street", town_or_city: "Test Town", county: "Test County", postcode_full: "AA1 1AA", uprn: "1234")
+        log = create(:sales_log, address_line1: "1, Test Street", town_or_city: "Test Town", county: "Test County", postcode_full: "AA1 1AA", uprn: "1234", uprn_known: 1)
 
         expect(question.notification_banner(log)).to eq(
           {
@@ -72,9 +72,12 @@ RSpec.describe Form::Sales::Questions::UprnConfirmation, type: :model do
     end
 
     context "when uprn_known == 1 && uprn_confirmed == nil" do
-      let(:log) { create(:sales_log, uprn_known: 1, uprn: "12345", uprn_confirmed: nil) }
+      let(:log) { create(:sales_log) }
 
       it "returns false" do
+        log.uprn_known = 1
+        log.uprn = "12345"
+        log.uprn_confirmed = nil
         expect(question.hidden_in_check_answers?(log)).to eq(false)
       end
     end

spec/models/form/sales/questions/uprn_spec.rb

@@ -74,9 +74,10 @@ RSpec.describe Form::Sales::Questions::Uprn, type: :model do
 
   describe "has the correct hidden_in_check_answers" do
     context "when uprn_known == 1" do
-      let(:log) { create(:sales_log, uprn_known: 1) }
+      let(:log) { create(:sales_log) }
 
       it "returns false" do
+        log.uprn_known = 1
         expect(question.hidden_in_check_answers?(log)).to eq(false)
       end
     end