Remove organisation_la factory and add test for organisation_relationship child/parent association

spec/factories/organisation.rb

@@ -11,17 +11,15 @@ FactoryBot.define do
     holds_own_stock { true }
   end
 
-  factory :organisation_la do
-    organisation
-    ons_code { "E07000041" }
-    created_at { Time.zone.now }
-    updated_at { Time.zone.now }
-  end
-
   factory :organisation_rent_period do
     organisation
     rent_period { 2 }
     created_at { Time.zone.now }
     updated_at { Time.zone.now }
   end
+
+  factory :organisation_relationship do
+    child_organisation { FactoryBot.create(:organisation) }
+    parent_organisation { FactoryBot.create(:organisation) }
+  end
 end

spec/models/organisation_spec.rb

@@ -27,6 +27,22 @@ RSpec.describe Organisation, type: :model do
         .to raise_error(ActiveRecord::RecordInvalid, "Validation failed: Provider type #{I18n.t('validations.organisation.provider_type_missing')}")
     end
 
+    context "with parent/child association" do
+      let(:child_organisation) { FactoryBot.create(:organisation, name: "DLUHC_Child") }
+
+      before do
+        FactoryBot.create(:organisation_relationship, child_organisation:, parent_organisation: organisation)
+      end
+
+      it "has correct child" do
+        expect(organisation.child_organisations.first).to eq(child_organisation)
+      end
+
+      it "has correct parent" do
+        expect(child_organisation.parent_organisations.first).to eq(organisation)
+      end
+    end
+
     context "with data protection confirmations" do
       before do
         FactoryBot.create(:data_protection_confirmation, organisation:, confirmed: false, created_at: Time.utc(2018, 0o6, 0o5, 10, 36, 49))