Browse Source

make reactivating_soon message refer to the soonest, not most recently created

pull/2995/head
Carolyn 2 months ago
parent
commit
a707cd5834
  1. 4
      app/models/location.rb
  2. 4
      app/models/scheme.rb
  3. 2
      app/models/validations/shared_validations.rb

4
app/models/location.rb

@ -220,8 +220,8 @@ class Location < ApplicationRecord
location_deactivation_periods.deactivations_without_reactivation.first location_deactivation_periods.deactivations_without_reactivation.first
end end
def last_deactivation_before(date) def soonest_reactivation(date)
location_deactivation_periods.where("deactivation_date <= ?", date).order("created_at").last location_deactivation_periods.deactivations_with_reactivation.where(date < reactivation_date).order(reactivation_date).first
end end
def status def status

4
app/models/scheme.rb

@ -315,8 +315,8 @@ class Scheme < ApplicationRecord
scheme_deactivation_periods.deactivations_without_reactivation.first scheme_deactivation_periods.deactivations_without_reactivation.first
end end
def last_deactivation_before(date) def soonest_reactivation(date)
scheme_deactivation_periods.where("deactivation_date <= ?", date).order("created_at").last scheme_deactivation_periods.deactivations_with_reactivation.where(date < reactivation_date).order(reactivation_date).first
end end
def last_deactivation_date def last_deactivation_date

2
app/models/validations/shared_validations.rb

@ -73,7 +73,7 @@ module Validations::SharedValidations
status = resource.status_at(date) status = resource.status_at(date)
return unless %i[reactivating_soon activating_soon deactivated].include?(status) return unless %i[reactivating_soon activating_soon deactivated].include?(status)
closest_reactivation = resource.last_deactivation_before(date) closest_reactivation = resource.soonest_reactivation(date)
open_deactivation = if resource.is_a?(Location) open_deactivation = if resource.is_a?(Location)
resource.open_deactivation || resource.scheme.open_deactivation resource.open_deactivation || resource.scheme.open_deactivation
else else

Loading…
Cancel
Save