Fix address options for address search question

app/models/form/lettings/questions/address_search.rb

@@ -19,7 +19,6 @@ class Form::Lettings::Questions::AddressSearch < ::Form::Question
       answer_opts[log.address_options[i][:uprn]] = { "value" => log.address_options[i][:address] }
     end
 
-    answer_opts["divider"] = { "value" => true }
     answer_opts
   end
 

app/models/form/sales/questions/address_search.rb

@@ -19,7 +19,6 @@ class Form::Sales::Questions::AddressSearch < ::Form::Question
       answer_opts[log.address_options[i][:uprn]] = { "value" => log.address_options[i][:address] }
     end
 
-    answer_opts["divider"] = { "value" => true }
     answer_opts
   end
 

app/models/log.rb

@@ -126,28 +126,37 @@ class Log < ApplicationRecord
   end
 
   def address_options
-    search_query = address_search.presence || address_string
+    if address_search.present?
-    return @address_options if @address_options && @last_searched_address_string == search_query
+      service = UprnClient.new(address_search)
+      service.call
+      if service.result.blank? || service.error.present?
+        @address_options = []
+        return @address_options
+      end
 
-    search_query = address_search.presence || address_string
+      presenter = AddressDataPresenter.new(service.result)
-    return if search_query.blank?
+      @address_options = [{ address: presenter.address, uprn: presenter.uprn }]
+    else
+      return @address_options if @address_options && @last_searched_address_string == address_string
+      return if address_string.blank?
 
-    @last_searched_address_string = search_query
+      @last_searched_address_string = address_string
 
-    service = AddressClient.new(address_string)
+      service = AddressClient.new(address_string)
-    service.call
+      service.call
-    if service.result.blank? || service.error.present?
+      if service.result.blank? || service.error.present?
-      @address_options = []
+        @address_options = []
-      return @answer_options
+        return @address_options
-    end
+      end
 
-    address_opts = []
+      address_opts = []
-    service.result.first(10).each do |result|
+      service.result.first(10).each do |result|
-      presenter = AddressDataPresenter.new(result)
+        presenter = AddressDataPresenter.new(result)
-      address_opts.append({ address: presenter.address, uprn: presenter.uprn })
+        address_opts.append({ address: presenter.address, uprn: presenter.uprn })
-    end
+      end
 
-    @address_options = address_opts
+      @address_options = address_opts
+    end
   end
 
   def collection_start_year