baarkerlounger
/
submit-social-housing-lettings-and-sales-data
mirror of https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

apply new csv syntax

pull/2945/head
Carolyn 1 week ago
parent
bbfe8111f7
commit
b7d44569c9
2 changed files with 15 additions and 15 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 4
      spec/services/bulk_upload/sales/validator_spec.rb
  2. 26
      spec/services/bulk_upload/sales/year2025/csv_parser_spec.rb

4
spec/services/bulk_upload/sales/validator_spec.rb
Unescape View File

@ -63,8 +63,8 @@ RSpec.describe BulkUpload::Sales::Validator do
let(:log) { build(:sales_log, :completed, saledate: Time.zone.local(2024, 10, 10), assigned_to: user) } let(:log) { build(:sales_log, :completed, saledate: Time.zone.local(2024, 10, 10), assigned_to: user) }
before do before do
file.write(log_to_csv.default_2025_field_numbers_row) file.write(log_to_csv.default_field_numbers_row_for_year(2025))
file.write(log_to_csv.to_2025_csv_row) file.write(log_to_csv.to_year_csv_row(2025))
file.rewind file.rewind
end end

26
spec/services/bulk_upload/sales/year2025/csv_parser_spec.rb
Unescape View File

@ -15,8 +15,8 @@ RSpec.describe BulkUpload::Sales::Year2025::CsvParser do
file.write("Can be empty?\n") file.write("Can be empty?\n")
file.write("Type of letting the question applies to\n") file.write("Type of letting the question applies to\n")
file.write("Duplicate check field?\n") file.write("Duplicate check field?\n")
file.write(BulkUpload::SalesLogToCsv.new(log:).default_2025_field_numbers_row) file.write(BulkUpload::SalesLogToCsv.new(log:).default_field_numbers_row_for_year(2025))
file.write(BulkUpload::SalesLogToCsv.new(log:).to_2025_csv_row) file.write(BulkUpload::SalesLogToCsv.new(log:).to_year_csv_row(2025))
file.write("\n") file.write("\n")
file.rewind file.rewind
end end
@ -47,8 +47,8 @@ RSpec.describe BulkUpload::Sales::Year2025::CsvParser do
file.write("\n") file.write("\n")
file.write("Type of letting the question applies to\n") file.write("Type of letting the question applies to\n")
file.write("Duplicate check field?\n") file.write("Duplicate check field?\n")
file.write(BulkUpload::SalesLogToCsv.new(log:).default_2025_field_numbers_row) file.write(BulkUpload::SalesLogToCsv.new(log:).default_field_numbers_row_for_year(2025))
file.write(BulkUpload::SalesLogToCsv.new(log:).to_2025_csv_row) file.write(BulkUpload::SalesLogToCsv.new(log:).to_year_csv_row(2025))
file.write("\n") file.write("\n")
file.rewind file.rewind
end end
@ -81,8 +81,8 @@ RSpec.describe BulkUpload::Sales::Year2025::CsvParser do
file.write("Can be empty?\n") file.write("Can be empty?\n")
file.write("Type of letting the question applies to\n") file.write("Type of letting the question applies to\n")
file.write("Duplicate check field?\n") file.write("Duplicate check field?\n")
file.write(BulkUpload::SalesLogToCsv.new(log:).default_2025_field_numbers_row(seed:)) file.write(BulkUpload::SalesLogToCsv.new(log:).default_field_numbers_row_for_year(2025, seed:))
file.write(BulkUpload::SalesLogToCsv.new(log:).to_2025_csv_row(seed:)) file.write(BulkUpload::SalesLogToCsv.new(log:).to_year_csv_row(2025, seed:))
file.rewind file.rewind
end end
@ -102,7 +102,7 @@ RSpec.describe BulkUpload::Sales::Year2025::CsvParser do
let(:log) { build(:sales_log, :completed, :with_uprn) } let(:log) { build(:sales_log, :completed, :with_uprn) }
before do before do
file.write(BulkUpload::SalesLogToCsv.new(log:, col_offset: 0).to_2025_csv_row) file.write(BulkUpload::SalesLogToCsv.new(log:, col_offset: 0).to_year_csv_row(2025))
file.rewind file.rewind
end end
@ -124,7 +124,7 @@ RSpec.describe BulkUpload::Sales::Year2025::CsvParser do
before do before do
file.write(bom) file.write(bom)
file.write(BulkUpload::SalesLogToCsv.new(log:, col_offset: 0).to_2025_csv_row) file.write(BulkUpload::SalesLogToCsv.new(log:, col_offset: 0).to_year_csv_row(2025))
file.close file.close
end end
@ -141,7 +141,7 @@ RSpec.describe BulkUpload::Sales::Year2025::CsvParser do
before do before do
file.write(invalid_sequence) file.write(invalid_sequence)
file.write(BulkUpload::SalesLogToCsv.new(log:, col_offset: 0).to_2025_csv_row) file.write(BulkUpload::SalesLogToCsv.new(log:, col_offset: 0).to_year_csv_row(2025))
file.close file.close
end end
@ -159,8 +159,8 @@ RSpec.describe BulkUpload::Sales::Year2025::CsvParser do
file.write("Can be empty?\n") file.write("Can be empty?\n")
file.write("Type of letting the question applies to\n") file.write("Type of letting the question applies to\n")
file.write("Duplicate check field?\n") file.write("Duplicate check field?\n")
file.write(BulkUpload::SalesLogToCsv.new(log:).default_2025_field_numbers_row) file.write(BulkUpload::SalesLogToCsv.new(log:).default_field_numbers_row_for_year(2025))
file.write(BulkUpload::SalesLogToCsv.new(log:).to_2025_csv_row) file.write(BulkUpload::SalesLogToCsv.new(log:).to_year_csv_row(2025))
file.rewind file.rewind
end end
@ -179,8 +179,8 @@ RSpec.describe BulkUpload::Sales::Year2025::CsvParser do
file.write("Can be empty?\r") file.write("Can be empty?\r")
file.write("Type of letting the question applies to\r\n") file.write("Type of letting the question applies to\r\n")
file.write("Duplicate check field?\r") file.write("Duplicate check field?\r")
file.write(BulkUpload::SalesLogToCsv.new(log:).default_2025_field_numbers_row) file.write(BulkUpload::SalesLogToCsv.new(log:).default_field_numbers_row_for_year(2025))
file.write(BulkUpload::SalesLogToCsv.new(log:).to_2025_csv_row) file.write(BulkUpload::SalesLogToCsv.new(log:).to_year_csv_row(2025))
file.rewind file.rewind
end end

Write Preview
Loading…
Cancel
Save