fix test (#1047)

- we now do a lookup for the expected start year on current form

spec/requests/bulk_upload_lettings_logs_controller_spec.rb

@@ -10,11 +10,13 @@ RSpec.describe BulkUploadLettingsLogsController, type: :request do
 
   describe "GET /lettings-logs/bulk-upload-logs/start" do
     context "when not in crossover period" do
+      let(:expected_year) { FormHandler.instance.forms["current_lettings"].start_date.year }
+
       it "redirects to /prepare-your-file" do
         Timecop.freeze(2022, 1, 1) do
           get "/lettings-logs/bulk-upload-logs/start", params: {}
 
-          expect(response).to redirect_to("/lettings-logs/bulk-upload-logs/prepare-your-file?form%5Byear%5D=2022")
+          expect(response).to redirect_to("/lettings-logs/bulk-upload-logs/prepare-your-file?form%5Byear%5D=#{expected_year}")
         end
       end
     end

spec/requests/bulk_upload_sales_logs_controller_spec.rb

@@ -10,11 +10,13 @@ RSpec.describe BulkUploadSalesLogsController, type: :request do
 
   describe "GET /sales-logs/bulk-upload-logs/start" do
     context "when not in crossover period" do
+      let(:expected_year) { FormHandler.instance.forms["current_sales"].start_date.year }
+
       it "redirects to /prepare-your-file" do
         Timecop.freeze(2022, 1, 1) do
           get "/sales-logs/bulk-upload-logs/start", params: {}
 
-          expect(response).to redirect_to("/sales-logs/bulk-upload-logs/prepare-your-file?form%5Byear%5D=2022")
+          expect(response).to redirect_to("/sales-logs/bulk-upload-logs/prepare-your-file?form%5Byear%5D=#{expected_year}")
         end
       end
     end