Browse Source

Update test selectord and urls

CLDC-3345-update-created-by-values
Kat 10 months ago
parent
commit
dd79527e43
  1. 4
      spec/features/lettings_log_spec.rb
  2. 16
      spec/requests/form_controller_spec.rb

4
spec/features/lettings_log_spec.rb

@ -152,7 +152,7 @@ RSpec.describe "Lettings Log Features" do
click_link("Set up this lettings log") click_link("Set up this lettings log")
select(support_user.organisation.name, from: "lettings-log-owning-organisation-id-field") select(support_user.organisation.name, from: "lettings-log-owning-organisation-id-field")
click_button("Save and continue") click_button("Save and continue")
select("#{support_user.name} (#{support_user.email})", from: "lettings-log-created-by-id-field") select("#{support_user.name} (#{support_user.email})", from: "lettings-log-assigned-to-id-field")
click_button("Save and continue") click_button("Save and continue")
log_id = page.current_path.scan(/\d/).join log_id = page.current_path.scan(/\d/).join
visit("lettings-logs/#{log_id}/setup/check-answers") visit("lettings-logs/#{log_id}/setup/check-answers")
@ -333,7 +333,7 @@ RSpec.describe "Lettings Log Features" do
visit("/lettings-logs") visit("/lettings-logs")
click_button("Create a new lettings log") click_button("Create a new lettings log")
click_link("Set up this lettings log") click_link("Set up this lettings log")
select(user.name, from: "lettings-log-created-by-id-field") select(user.name, from: "lettings-log-assigned-to-id-field")
click_button("Save and continue") click_button("Save and continue")
log_id = page.current_path.scan(/\d/).join log_id = page.current_path.scan(/\d/).join
expect(page).to have_current_path("/lettings-logs/#{log_id}/needs-type") expect(page).to have_current_path("/lettings-logs/#{log_id}/needs-type")

16
spec/requests/form_controller_spec.rb

@ -105,7 +105,7 @@ RSpec.describe FormController, type: :request do
it "resets created by and renders the next page" do it "resets created by and renders the next page" do
post "/lettings-logs/#{lettings_log.id}/net-income", params: params post "/lettings-logs/#{lettings_log.id}/net-income", params: params
expect(response).to redirect_to("/lettings-logs/#{lettings_log.id}/created-by") expect(response).to redirect_to("/lettings-logs/#{lettings_log.id}/assigned-to")
follow_redirect! follow_redirect!
lettings_log.reload lettings_log.reload
expect(lettings_log.assigned_to).to eq(nil) expect(lettings_log.assigned_to).to eq(nil)
@ -130,7 +130,7 @@ RSpec.describe FormController, type: :request do
it "does not reset created by" do it "does not reset created by" do
post "/lettings-logs/#{lettings_log.id}/net-income", params: params post "/lettings-logs/#{lettings_log.id}/net-income", params: params
expect(response).to redirect_to("/lettings-logs/#{lettings_log.id}/created-by") expect(response).to redirect_to("/lettings-logs/#{lettings_log.id}/assigned-to")
follow_redirect! follow_redirect!
lettings_log.reload lettings_log.reload
expect(lettings_log.assigned_to).to eq(user) expect(lettings_log.assigned_to).to eq(user)
@ -155,7 +155,7 @@ RSpec.describe FormController, type: :request do
it "sets managing organisation to owning organisation" do it "sets managing organisation to owning organisation" do
post "/lettings-logs/#{lettings_log.id}/stock-owner", params: params post "/lettings-logs/#{lettings_log.id}/stock-owner", params: params
expect(response).to redirect_to("/lettings-logs/#{lettings_log.id}/created-by") expect(response).to redirect_to("/lettings-logs/#{lettings_log.id}/assigned-to")
follow_redirect! follow_redirect!
lettings_log.reload lettings_log.reload
expect(lettings_log.owning_organisation).to eq(managing_organisation) expect(lettings_log.owning_organisation).to eq(managing_organisation)
@ -182,7 +182,7 @@ RSpec.describe FormController, type: :request do
it "correctly sets owning organisation" do it "correctly sets owning organisation" do
post "/sales-logs/#{sales_log.id}/owning-organisation", params: params post "/sales-logs/#{sales_log.id}/owning-organisation", params: params
expect(response).to redirect_to("/sales-logs/#{sales_log.id}/created-by") expect(response).to redirect_to("/sales-logs/#{sales_log.id}/assigned-to")
follow_redirect! follow_redirect!
sales_log.reload sales_log.reload
expect(sales_log.owning_organisation).to eq(managing_organisation) expect(sales_log.owning_organisation).to eq(managing_organisation)
@ -209,7 +209,7 @@ RSpec.describe FormController, type: :request do
it "does not reset created by" do it "does not reset created by" do
post "/sales-logs/#{sales_log.id}/owning-organisation", params: params post "/sales-logs/#{sales_log.id}/owning-organisation", params: params
expect(response).to redirect_to("/sales-logs/#{sales_log.id}/created-by") expect(response).to redirect_to("/sales-logs/#{sales_log.id}/assigned-to")
follow_redirect! follow_redirect!
sales_log.reload sales_log.reload
expect(sales_log.assigned_to).to eq(assigned_to) expect(sales_log.assigned_to).to eq(assigned_to)
@ -238,7 +238,7 @@ RSpec.describe FormController, type: :request do
it "does not reset created by" do it "does not reset created by" do
post "/sales-logs/#{sales_log.id}/owning-organisation", params: params post "/sales-logs/#{sales_log.id}/owning-organisation", params: params
expect(response).to redirect_to("/sales-logs/#{sales_log.id}/created-by") expect(response).to redirect_to("/sales-logs/#{sales_log.id}/assigned-to")
follow_redirect! follow_redirect!
sales_log.reload sales_log.reload
expect(sales_log.assigned_to).to eq(assigned_to) expect(sales_log.assigned_to).to eq(assigned_to)
@ -527,14 +527,14 @@ RSpec.describe FormController, type: :request do
let(:user) { create(:user, :support) } let(:user) { create(:user, :support) }
it "routes to the page" do it "routes to the page" do
get "/lettings-logs/#{lettings_log.id}/created-by" get "/lettings-logs/#{lettings_log.id}/assigned-to"
expect(response).to have_http_status(:ok) expect(response).to have_http_status(:ok)
end end
end end
context "when the dependency is not met" do context "when the dependency is not met" do
it "redirects to the tasklist page" do it "redirects to the tasklist page" do
get "/lettings-logs/#{lettings_log.id}/created-by" get "/lettings-logs/#{lettings_log.id}/assigned-to"
expect(response).to redirect_to("/lettings-logs/#{lettings_log.id}") expect(response).to redirect_to("/lettings-logs/#{lettings_log.id}")
end end
end end

Loading…
Cancel
Save