Browse Source

Fix download link

pull/441/head
baarkerlounger 3 years ago
parent
commit
e500242933
  1. 2
      app/controllers/case_logs_controller.rb
  2. 2
      app/models/concerns/generate_csv.rb
  3. 2
      app/views/case_logs/_log_list.html.erb
  4. 2
      spec/requests/case_logs_controller_spec.rb

2
app/controllers/case_logs_controller.rb

@ -11,7 +11,7 @@ class CaseLogsController < ApplicationController
respond_to do |format| respond_to do |format|
format.html format.html
format.csv { send_data @case_logs.to_csv, filename: "case-logs-#{Time.zone.now}" } format.csv { send_data @case_logs.to_csv, filename: "logs-#{Time.zone.now}.csv" }
end end
end end

2
app/models/concerns/generate_csv.rb

@ -4,7 +4,7 @@ module GenerateCsv
class_methods do class_methods do
def to_csv def to_csv
CSV.generate(headers: true) do |csv| CSV.generate(headers: true) do |csv|
csv << self.attribute_names csv << attribute_names
all.each do |record| all.each do |record|
csv << record.attributes.values csv << record.attributes.values

2
app/views/case_logs/_log_list.html.erb

@ -3,7 +3,7 @@
<span class="govuk-!-margin-right-4"> <span class="govuk-!-margin-right-4">
<strong><%= pagy.count %></strong> total <%= title.downcase %> <strong><%= pagy.count %></strong> total <%= title.downcase %>
</span> </span>
<a class="govuk-link" href="#" download="">Download (CSV)</a> <a class="govuk-link" download href="/logs.csv">Download (CSV)</a>
</figcaption> </figcaption>
<section class="app-table-group" tabindex="0" aria-labelledby="<%= title.dasherize %>"> <section class="app-table-group" tabindex="0" aria-labelledby="<%= title.dasherize %>">
<table class="govuk-table"> <table class="govuk-table">

2
spec/requests/case_logs_controller_spec.rb

@ -208,7 +208,7 @@ RSpec.describe CaseLogsController, type: :request do
end end
it "shows the download csv link" do it "shows the download csv link" do
expect(page).to have_link("Download (CSV)") expect(page).to have_link("Download (CSV)", href: "/logs.csv")
end end
context "when there are more than 20 logs" do context "when there are more than 20 logs" do

Loading…
Cancel
Save