Browse Source

Update logging level in InvalidLogsHelper from debug to info for better visibility

pull/3061/head
Manny Dinssa 1 week ago
parent
commit
e79ed6e8ed
  1. 10
      app/helpers/invalid_logs_helper.rb
  2. 11
      lib/tasks/invalid_logs.rake

10
app/helpers/invalid_logs_helper.rb

@ -1,19 +1,19 @@
module InvalidLogsHelper
def count_and_display_invalid_logs(model, log_type, year)
invalid_logs = fetch_invalid_logs(model, year)
Rails.logger.debug "Number of invalid #{log_type} for year #{year}: #{invalid_logs.size}"
Rails.logger.debug "Invalid #{log_type} IDs: #{invalid_logs.map(&:id).join(', ')}"
Rails.logger.info "Number of invalid #{log_type} for year #{year}: #{invalid_logs.size}"
Rails.logger.info "Invalid #{log_type} IDs: #{invalid_logs.map(&:id).join(', ')}"
end
def surface_invalid_logs(model, log_type, year)
invalid_logs = fetch_invalid_logs(model, year)
if invalid_logs.any?
invalid_logs.each do |log|
Rails.logger.debug "#{log_type} ID: #{log.id}"
log.errors.full_messages.each { |message| Rails.logger.debug " - #{message}" }
Rails.logger.info "#{log_type} ID: #{log.id}"
log.errors.full_messages.each { |message| Rails.logger.info " - #{message}" }
end
else
Rails.logger.debug "No invalid #{log_type} found for year #{year}."
Rails.logger.info "No invalid #{log_type} found for year #{year}."
end
end

11
lib/tasks/invalid_logs.rake

@ -1,11 +1,9 @@
require "helpers/invalid_logs_helper"
namespace :logs do
include CollectionTimeHelper
include InvalidLogsHelper
desc "Count the number of invalid LettingsLog and SalesLog for a given year"
task :count_invalid, [:year] => :environment do |_task, args|
include CollectionTimeHelper
include InvalidLogsHelper
year = args[:year] || current_collection_year
count_and_display_invalid_logs(LettingsLog, "LettingsLog", year)
count_and_display_invalid_logs(SalesLog, "SalesLog", year)
@ -13,9 +11,6 @@ namespace :logs do
desc "Surface all invalid logs and output their error messages for a given year"
task :surface_invalid, [:year] => :environment do |_task, args|
include CollectionTimeHelper
include InvalidLogsHelper
year = args[:year] || current_collection_year
surface_invalid_logs(LettingsLog, "LettingsLog", year)
surface_invalid_logs(SalesLog, "SalesLog", year)

Loading…
Cancel
Save