Browse Source

CLDC-3130 Update first let question for 24/25 (#2160)

* feat: make change for 2024/25 logs

* refactor: lint

* refactor: simplify
pull/2175/head
natdeanlewissoftwire 11 months ago committed by GitHub
parent
commit
ea0fc713a4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 17
      app/models/form/lettings/questions/first_time_property_let_as_social_housing.rb
  2. 39
      spec/models/form/lettings/pages/first_time_property_let_as_social_housing_spec.rb
  3. 47
      spec/models/form/lettings/questions/first_time_property_let_as_social_housing_spec.rb

17
app/models/form/lettings/questions/first_time_property_let_as_social_housing.rb

@ -7,12 +7,21 @@ class Form::Lettings::Questions::FirstTimePropertyLetAsSocialHousing < ::Form::Q
@type = "radio" @type = "radio"
@check_answers_card_number = 0 @check_answers_card_number = 0
@hint_text = "" @hint_text = ""
@answer_options = ANSWER_OPTIONS
@question_number = 14 @question_number = 14
end end
ANSWER_OPTIONS = { def answer_options
"1" => { "value" => "Yes", "hint" => "This is a new let." }, {
"0" => { "value" => "No", "hint" => "This is a re-let of existing social housing." }, "1" => { "value" => "Yes", "hint" => yes_hint },
"0" => { "value" => "No", "hint" => no_hint },
}.freeze }.freeze
end end
def yes_hint
form.start_year_after_2024? ? "This property was previously used for other purposes or is a new-build." : "This is a new let."
end
def no_hint
form.start_year_after_2024? ? "This is a re-let of existing social housing stock." : "This is a re-let of existing social housing."
end
end

39
spec/models/form/lettings/pages/first_time_property_let_as_social_housing_spec.rb

@ -0,0 +1,39 @@
require "rails_helper"
RSpec.describe Form::Lettings::Pages::FirstTimePropertyLetAsSocialHousing, type: :model do
subject(:page) { described_class.new(page_id, page_definition, subsection) }
let(:page_id) { nil }
let(:page_definition) { nil }
let(:subsection) { instance_double(Form::Subsection) }
let(:form) { instance_double(Form) }
before do
allow(form).to receive(:start_year_after_2024?).and_return(false)
allow(subsection).to receive(:form).and_return(form)
end
it "has correct subsection" do
expect(page.subsection).to eq(subsection)
end
it "has correct questions" do
expect(page.questions.map(&:id)).to eq(%w[first_time_property_let_as_social_housing])
end
it "has the correct id" do
expect(page.id).to eq("first_time_property_let_as_social_housing")
end
it "has the correct header" do
expect(page.header).to be_nil
end
it "has the correct description" do
expect(page.description).to be_nil
end
it "has the correct depends_on" do
expect(page.depends_on).to eq([{ "is_renewal?" => false }])
end
end

47
spec/models/form/lettings/questions/first_time_property_let_as_social_housing_spec.rb

@ -0,0 +1,47 @@
require "rails_helper"
RSpec.describe Form::Lettings::Questions::FirstTimePropertyLetAsSocialHousing, type: :model do
subject(:question) { described_class.new(question_id, question_definition, page) }
let(:question_id) { nil }
let(:question_definition) { nil }
let(:page) { instance_double(Form::Page) }
let(:subsection) { instance_double(Form::Subsection) }
let(:form) { instance_double(Form) }
before do
allow(form).to receive(:start_year_after_2024?).and_return(false)
allow(page).to receive(:subsection).and_return(subsection)
allow(subsection).to receive(:form).and_return(form)
end
it "has correct page" do
expect(question.page).to eq(page)
end
it "has the correct id" do
expect(question.id).to eq("first_time_property_let_as_social_housing")
end
context "with 2023/24 form" do
it "has the correct answer_options" do
expect(question.answer_options).to eq({
"1" => { "value" => "Yes", "hint" => "This is a new let." },
"0" => { "value" => "No", "hint" => "This is a re-let of existing social housing." },
})
end
end
context "with 2024/25 form" do
before do
allow(form).to receive(:start_year_after_2024?).and_return(true)
end
it "has the correct answer_options" do
expect(question.answer_options).to eq({
"1" => { "value" => "Yes", "hint" => "This property was previously used for other purposes or is a new-build." },
"0" => { "value" => "No", "hint" => "This is a re-let of existing social housing stock." },
})
end
end
end
Loading…
Cancel
Save