kosiakkatrina
12 months ago
committed by
GitHub
19 changed files with 48 additions and 281 deletions
@ -1,5 +0,0 @@
|
||||
module PlatformHelper |
||||
def self.is_paas? |
||||
!ENV["VCAP_SERVICES"].nil? |
||||
end |
||||
end |
||||
@ -1,23 +0,0 @@
|
||||
module Configuration |
||||
class PaasConfigurationService < ConfigurationService |
||||
private |
||||
|
||||
def config_present? |
||||
!ENV["VCAP_SERVICES"].nil? |
||||
end |
||||
|
||||
def read_config |
||||
unless config_present? |
||||
@logger.warn("Could not find VCAP_SERVICES in the environment variables!") |
||||
return {} |
||||
end |
||||
|
||||
begin |
||||
JSON.parse(ENV["VCAP_SERVICES"], { symbolize_names: true }) |
||||
rescue StandardError |
||||
@logger.warn("Could not parse VCAP_SERVICES!") |
||||
{} |
||||
end |
||||
end |
||||
end |
||||
end |
||||
@ -1,15 +0,0 @@
|
||||
require "rails_helper" |
||||
|
||||
RSpec.describe PlatformHelper do |
||||
describe "is_paas?" do |
||||
it "returns true if the VCAP_SERVICES environment variable exists" do |
||||
allow(ENV).to receive(:[]).with("VCAP_SERVICES").and_return("dummy") |
||||
expect(described_class.is_paas?).to eq(true) |
||||
end |
||||
|
||||
it "returns false if the VCAP_SERVICES environment variable doesn't exist" do |
||||
allow(ENV).to receive(:[]).with("VCAP_SERVICES") |
||||
expect(described_class.is_paas?).to eq(false) |
||||
end |
||||
end |
||||
end |
||||
@ -1,149 +0,0 @@
|
||||
require "rails_helper" |
||||
|
||||
RSpec.describe Configuration::PaasConfigurationService do |
||||
subject(:config_service) { described_class.new(logger) } |
||||
|
||||
let(:logger) { instance_double(ActiveSupport::LogSubscriber) } |
||||
|
||||
context "when the paas configuration is unavailable" do |
||||
before { allow(logger).to receive(:warn) } |
||||
|
||||
it "returns the S3 configuration as not present" do |
||||
expect(config_service.s3_config_present?).to be(false) |
||||
end |
||||
|
||||
it "returns the redis configuration as not present" do |
||||
expect(config_service.redis_config_present?).to be(false) |
||||
end |
||||
|
||||
it "does not retrieve any S3 bucket configuration" do |
||||
expect(config_service.s3_buckets).to be_a(Hash) |
||||
expect(config_service.s3_buckets).to be_empty |
||||
end |
||||
|
||||
it "does not retrieve any redis configuration" do |
||||
expect(config_service.redis_uris).to be_a(Hash) |
||||
expect(config_service.redis_uris).to be_empty |
||||
end |
||||
end |
||||
|
||||
context "when the paas configuration is present but empty" do |
||||
before do |
||||
allow(ENV).to receive(:[]).with("VCAP_SERVICES").and_return("{}") |
||||
end |
||||
|
||||
it "returns the S3 configuration as not present" do |
||||
expect(config_service.s3_config_present?).to be(false) |
||||
end |
||||
|
||||
it "returns the redis configuration as not present" do |
||||
expect(config_service.redis_config_present?).to be(false) |
||||
end |
||||
|
||||
it "does not retrieve any S3 bucket configuration" do |
||||
expect(config_service.s3_buckets).to be_a(Hash) |
||||
expect(config_service.s3_buckets).to be_empty |
||||
end |
||||
|
||||
it "does not retrieve any redis configuration" do |
||||
expect(config_service.redis_uris).to be_a(Hash) |
||||
expect(config_service.redis_uris).to be_empty |
||||
end |
||||
end |
||||
|
||||
context "when the paas configuration is present but invalid" do |
||||
let(:vcap_services) { "random text" } |
||||
|
||||
before do |
||||
allow(ENV).to receive(:[]).with("VCAP_SERVICES").and_return(vcap_services) |
||||
allow(logger).to receive(:warn) |
||||
end |
||||
|
||||
it "logs an error when checking if the S3 config is present" do |
||||
expect(logger).to receive(:warn).with("Could not parse VCAP_SERVICES!") |
||||
config_service.s3_config_present? |
||||
end |
||||
|
||||
it "logs an error when checking if the Redis config is present" do |
||||
expect(logger).to receive(:warn).with("Could not parse VCAP_SERVICES!") |
||||
config_service.redis_config_present? |
||||
end |
||||
end |
||||
|
||||
context "when the paas configuration is present with S3 configured" do |
||||
let(:vcap_services) do |
||||
<<~JSON |
||||
{"aws-s3-bucket": |
||||
[{ |
||||
"instance_name": "bucket_1", |
||||
"credentials": { |
||||
"aws_access_key_id": "123", |
||||
"aws_secret_access_key": "456", |
||||
"aws_region": "eu-west-1", |
||||
"bucket_name": "my-bucket" |
||||
} |
||||
}, |
||||
{ |
||||
"instance_name": "bucket_2", |
||||
"credentials": { |
||||
"aws_access_key_id": "789", |
||||
"aws_secret_access_key": "012", |
||||
"aws_region": "eu-west-2", |
||||
"bucket_name": "my-bucket2" |
||||
} |
||||
}] |
||||
} |
||||
JSON |
||||
end |
||||
|
||||
before do |
||||
allow(ENV).to receive(:[]).with("VCAP_SERVICES").and_return(vcap_services) |
||||
end |
||||
|
||||
it "returns the S3 configuration as present" do |
||||
expect(config_service.s3_config_present?).to be(true) |
||||
end |
||||
|
||||
it "returns the redis configuration as not present" do |
||||
expect(config_service.redis_config_present?).to be(false) |
||||
end |
||||
|
||||
it "does retrieve the S3 bucket configurations" do |
||||
s3_buckets = config_service.s3_buckets |
||||
|
||||
expect(s3_buckets).not_to be_empty |
||||
expect(s3_buckets.count).to be(2) |
||||
expect(s3_buckets).to have_key(:bucket_1) |
||||
expect(s3_buckets).to have_key(:bucket_2) |
||||
end |
||||
end |
||||
|
||||
context "when the paas configuration is present with redis configured" do |
||||
let(:vcap_services) do |
||||
<<-JSON |
||||
{"redis": [{"instance_name": "redis_1", "credentials": {"uri": "redis_uri" }}]} |
||||
JSON |
||||
end |
||||
|
||||
before do |
||||
allow(ENV).to receive(:[]).with("VCAP_SERVICES").and_return(vcap_services) |
||||
end |
||||
|
||||
it "returns the redis configuration as present" do |
||||
expect(config_service.redis_config_present?).to be(true) |
||||
end |
||||
|
||||
it "returns the S3 configuration as not present" do |
||||
expect(config_service.s3_config_present?).to be(false) |
||||
end |
||||
|
||||
it "does retrieve the redis configurations" do |
||||
redis_uris = config_service.redis_uris |
||||
|
||||
expect(redis_uris).not_to be_empty |
||||
expect(redis_uris.count).to be(1) |
||||
expect(redis_uris).to have_key(:redis_1) |
||||
expect(redis_uris[:redis_1]).to eq("redis_uri") |
||||
end |
||||
end |
||||
end |
||||
Loading…
Reference in new issue