Browse Source

CLDC-2071 Add intermediate rent error to BU (#2053)

* Add intermediate rent error

* Make sure field 12 as an error
pull/2079/head
kosiakkatrina 1 year ago committed by GitHub
parent
commit
eb7f301974
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 8
      app/services/bulk_upload/lettings/year2023/row_parser.rb
  2. 17
      spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb

8
app/services/bulk_upload/lettings/year2023/row_parser.rb

@ -329,6 +329,14 @@ class BulkUpload::Lettings::Year2023::RowParser
},
on: :after_log
validates :field_11,
presence: {
if: proc { renttype == :intermediate },
message: I18n.t("validations.not_answered", question: "intermediate rent type"),
category: :setup,
},
on: :after_log
validates :field_15,
presence: {
if: proc { supported_housing? && log_uses_old_scheme_id? },

17
spec/services/bulk_upload/lettings/year2023/row_parser_spec.rb

@ -809,6 +809,23 @@ RSpec.describe BulkUpload::Lettings::Year2023::RowParser do
end
end
context "when intermediate rent and field_11 (Which type of Intermediate Rent) is not given" do
let(:attributes) { { bulk_upload:, field_5: "9", field_11: nil } }
it "adds error on field_11" do
expect(parser.errors[:field_5]).to be_present
expect(parser.errors[:field_11]).to eq(["You must answer intermediate rent type"])
end
end
context "when intermediate rent other and field_12 is not given" do
let(:attributes) { { bulk_upload:, field_5: "9", field_11: "3", field_12: nil } }
it "adds error on field_12" do
expect(parser.errors[:field_12]).to eq(["You must answer product name"])
end
end
context "when bulk upload is for general needs" do
context "when general needs option selected" do
let(:attributes) { { bulk_upload:, field_5: "1", field_4: "1" } }

Loading…
Cancel
Save