Browse Source

Age known believe import fixes (#545)

* amend fixture to make test fail

* fix failing test

* lint fixes
pull/619/head
Dushan 3 years ago committed by baarkerlounger
parent
commit
f4401869de
  1. 11
      app/services/imports/case_logs_import_service.rb
  2. 4
      spec/fixtures/softwire_imports/case_logs/0ead17cb-1668-442d-898c-0d52879ff592.xml

11
app/services/imports/case_logs_import_service.rb

@ -345,12 +345,15 @@ module Imports
return nil if hhmemb.present? && index > hhmemb
age_refused = string_or_nil(xml_doc, "P#{index}AR")
if age_refused == "AGE_REFUSED"
1 # No
if age_refused.present?
if age_refused.casecmp("AGE_REFUSED").zero?
return 1 # No
else
0 # Yes
return 0 # Yes
end
end
0
end
def details_known(index, attributes)
return nil if attributes["hhmemb"].nil? || index > attributes["hhmemb"]
@ -501,7 +504,7 @@ module Imports
end
def people_with_details(xml_doc)
((2..8).map { |x| string_or_nil(xml_doc, "P#{x}Rel") } + [string_or_nil(xml_doc, "P1Age")]).compact
((2..8).map { |x| string_or_nil(xml_doc, "P#{x}Rel") } + [string_or_nil(xml_doc, "P1Sex")]).compact
end
end
end

4
spec/fixtures/softwire_imports/case_logs/0ead17cb-1668-442d-898c-0d52879ff592.xml vendored

@ -48,8 +48,8 @@
<_2cYears/>
</Group>
<Group>
<P1Age override-field="">23</P1Age>
<P1AR/>
<P1Age override-field=""/>
<P1AR>Age_Refused</P1AR>
<P1Sex override-field="">Female</P1Sex>
<P1Eco>6) Not Seeking Work</P1Eco>
<P1Eth>17 Refused</P1Eth>

Loading…
Cancel
Save