Delete not started logs (#1656)

app/policies/lettings_log_policy.rb

@@ -12,9 +12,6 @@ class LettingsLogPolicy
     # Can only delete editable logs
     return false unless log.collection_period_open?
 
-    # Only delete logs with answered questions
-    return false unless log.in_progress? || log.completed?
-
     # Support users can delete any log
     return true if user.support?
 

app/policies/sales_log_policy.rb

@@ -12,9 +12,6 @@ class SalesLogPolicy
     # Can only delete editable logs
     return false unless log.collection_period_open?
 
-    # Only delete logs with answered questions
-    return false unless log.in_progress? || log.completed?
-
     # Support users can delete any log
     return true if user.support?
 

spec/policies/lettings_log_policy_spec.rb

@@ -44,16 +44,8 @@ RSpec.describe LettingsLogPolicy do
       end
 
       context "when not started" do
-        before do
-          allow(log).to receive(:in_progress?).and_return(false)
-          allow(log).to receive(:completed?).and_return(false)
-        end
-
-        it "does not allow deletion of log" do
-          expect(log).to receive(:in_progress?)
-          expect(log).to receive(:collection_period_open?)
-
-          expect(policy).not_to permit(build(:user, :support), log)
+        it "allows deletion of log" do
+          expect(policy).to permit(build(:user, :support), create(:lettings_log))
         end
       end
 
@@ -83,9 +75,7 @@ RSpec.describe LettingsLogPolicy do
           context "when user is support" do
             let(:user) { create(:user, :support) }
 
-            it "does allow deletion of log" do
-              expect(log).to receive(:collection_period_open?)
-
+            it "allows deletion of log" do
               expect(policy).to permit(user, log)
             end
           end

spec/policies/sales_log_policy_spec.rb

@@ -44,16 +44,8 @@ RSpec.describe SalesLogPolicy do
       end
 
       context "when not started" do
-        before do
-          allow(log).to receive(:in_progress?).and_return(false)
-          allow(log).to receive(:completed?).and_return(false)
-        end
-
-        it "does not allow deletion of log" do
-          expect(log).to receive(:in_progress?)
-          expect(log).to receive(:collection_period_open?)
-
-          expect(policy).not_to permit(build(:user, :support), log)
+        it "allows deletion of log" do
+          expect(policy).to permit(build(:user, :support), create(:sales_log))
         end
       end