@ -4,8 +4,8 @@ RSpec.describe Validations::SharedValidations do
subject ( :shared_validator ) { validator_class . new }
let ( :validator_class ) { Class . new { include Validations :: SharedValidations } }
let ( :lettings_log ) { FactoryBot . create ( :lettings_log ) }
let ( :sales_log ) { FactoryBot . create ( :sales_log , :completed ) }
let ( :record ) { FactoryBot . create ( :lettings_log ) }
let ( :sales_record ) { FactoryBot . create ( :sales_log , :completed ) }
let ( :fake_2021_2022_form ) { Form . new ( " spec/fixtures/forms/2021_2022.json " ) }
describe " numeric min max validations " do
@ -15,164 +15,102 @@ RSpec.describe Validations::SharedValidations do
context " when validating age " do
it " validates that person 1's age is a number " do
lettings_log . age1 = " random "
shared_validator . validate_numeric_min_max ( lettings_log )
expect ( lettings_log . errors [ " age1 " ] )
record . age1 = " random "
shared_validator . validate_numeric_min_max ( record )
expect ( record . errors [ " age1 " ] )
. to include ( match I18n . t ( " validations.numeric.within_range " , field : " Lead tenant’s age " , min : 16 , max : 120 ) )
end
it " validates that other household member ages are a number " do
lettings_log . age2 = " random "
shared_validator . validate_numeric_min_max ( lettings_log )
expect ( lettings_log . errors [ " age2 " ] )
record . age2 = " random "
shared_validator . validate_numeric_min_max ( record )
expect ( record . errors [ " age2 " ] )
. to include ( match I18n . t ( " validations.numeric.within_range " , field : " Person 2’s age " , min : 1 , max : 120 ) )
end
it " validates that person 1's age is greater than 16 " do
lettings_log . age1 = 15
shared_validator . validate_numeric_min_max ( lettings_log )
expect ( lettings_log . errors [ " age1 " ] )
record . age1 = 15
shared_validator . validate_numeric_min_max ( record )
expect ( record . errors [ " age1 " ] )
. to include ( match I18n . t ( " validations.numeric.within_range " , field : " Lead tenant’s age " , min : 16 , max : 120 ) )
end
it " validates that other household member ages are greater than 1 " do
lettings_log . age2 = 0
shared_validator . validate_numeric_min_max ( lettings_log )
expect ( lettings_log . errors [ " age2 " ] )
record . age2 = 0
shared_validator . validate_numeric_min_max ( record )
expect ( record . errors [ " age2 " ] )
. to include ( match I18n . t ( " validations.numeric.within_range " , field : " Person 2’s age " , min : 1 , max : 120 ) )
end
it " validates that person 1's age is less than 121 " do
lettings_log . age1 = 121
shared_validator . validate_numeric_min_max ( lettings_log )
expect ( lettings_log . errors [ " age1 " ] )
record . age1 = 121
shared_validator . validate_numeric_min_max ( record )
expect ( record . errors [ " age1 " ] )
. to include ( match I18n . t ( " validations.numeric.within_range " , field : " Lead tenant’s age " , min : 16 , max : 120 ) )
end
it " validates that other household member ages are greater than 121 " do
lettings_log . age2 = 123
shared_validator . validate_numeric_min_max ( lettings_log )
expect ( lettings_log . errors [ " age2 " ] )
record . age2 = 123
shared_validator . validate_numeric_min_max ( record )
expect ( record . errors [ " age2 " ] )
. to include ( match I18n . t ( " validations.numeric.within_range " , field : " Person 2’s age " , min : 1 , max : 120 ) )
end
it " validates that person 1's age is between 16 and 120 " do
lettings_log . age1 = 63
shared_validator . validate_numeric_min_max ( lettings_log )
expect ( lettings_log . errors [ " age1 " ] ) . to be_empty
record . age1 = 63
shared_validator . validate_numeric_min_max ( record )
expect ( record . errors [ " age1 " ] ) . to be_empty
end
it " validates that other household member ages are between 1 and 120 " do
lettings_log . age6 = 45
shared_validator . validate_numeric_min_max ( lettings_log )
expect ( lettings_log . errors [ " age6 " ] ) . to be_empty
record . age6 = 45
shared_validator . validate_numeric_min_max ( record )
expect ( record . errors [ " age6 " ] ) . to be_empty
end
context " with sales log " do
it " validates that person 2's age is between 0 and 110 for non joint purchase " do
sales_log . jointpur = 2
sales_log . hholdcount = 1
sales_log . details_known_2 = 1
sales_log . age2 = 130
shared_validator . validate_numeric_min_max ( sales_log )
expect ( sales_log . errors [ " age2 " ] . first ) . to eq ( " Person 2’s age must be between 0 and 110 " )
sales_record . jointpur = 2
sales_record . hholdcount = 1
sales_record . details_known_2 = 1
sales_record . age2 = 130
shared_validator . validate_numeric_min_max ( sales_record )
expect ( sales_record . errors [ " age2 " ] . first ) . to eq ( " Person 2’s age must be between 0 and 110 " )
end
it " validates that buyer 2's age is between 0 and 110 for joint purchase " do
sales_log . jointpur = 1
sales_log . age2 = 130
shared_validator . validate_numeric_min_max ( sales_log )
expect ( sales_log . errors [ " age2 " ] . first ) . to eq ( " Buyer 2’s age must be between 0 and 110 " )
sales_record . jointpur = 1
sales_record . age2 = 130
shared_validator . validate_numeric_min_max ( sales_record )
expect ( sales_record . errors [ " age2 " ] . first ) . to eq ( " Buyer 2’s age must be between 0 and 110 " )
end
end
end
it " adds the correct validation text when a question has a min but not a max " do
sales_log . savings = - 10
shared_validator . validate_numeric_min_max ( sales_log )
expect ( sales_log . errors [ " savings " ] ) . to include ( match I18n . t ( " validations.numeric.above_min " , field : " Buyer’s total savings before any deposit paid " , min : " £0 " ) )
sales_record . savings = - 10
shared_validator . validate_numeric_min_max ( sales_record )
expect ( sales_record . errors [ " savings " ] ) . to include ( match I18n . t ( " validations.numeric.above_min " , field : " Buyer’s total savings (to nearest £10) before any deposit paid " , min : " £0 " ) )
end
context " when validating percent " do
it " validates that suffixes are added in the error message " do
sales_log . ownershipsch = 1
sales_log . staircase = 1
sales_log . stairbought = 150
shared_validator . validate_numeric_min_max ( sales_log )
expect ( sales_log . errors [ " stairbought " ] )
sales_record . ownershipsch = 1
sales_record . staircase = 1
sales_record . stairbought = 150
shared_validator . validate_numeric_min_max ( sales_record )
expect ( sales_record . errors [ " stairbought " ] )
. to include ( match I18n . t ( " validations.numeric.within_range " , field : " Percentage bought in this staircasing transaction " , min : " 0% " , max : " 100% " ) )
end
end
context " when validating price " do
it " validates that prefix £ and delimeter ' ,' is added in the error message " do
sales_log . income1 = - 5
shared_validator . validate_numeric_min_max ( sales_log )
expect ( sales_log . errors [ " income1 " ] )
it " validates that £ prefix and , is added in the error message " do
sales_record . income1 = - 5
shared_validator . validate_numeric_min_max ( sales_record )
expect ( sales_record . errors [ " income1 " ] )
. to include ( match I18n . t ( " validations.numeric.within_range " , field : " Buyer 1’s gross annual income " , min : " £0 " , max : " £999,999 " ) )
end
end
end
describe " validating level of accuracy or rounding for numeric questions " do
context " when validating a question with a step of 1 " do
it " adds an error if input is a decimal " do
sales_log . income1 = 30_000 . 5
shared_validator . validate_numeric_step ( sales_log )
expect ( sales_log . errors [ :income1 ] ) . to include I18n . t ( " validations.numeric.whole_number " , field : " Buyer 1’s gross annual income " )
end
it " adds an error if the user attempts to input a number in exponent format " do
sales_log . income1 = " 3e5 "
shared_validator . validate_numeric_step ( sales_log )
expect ( sales_log . errors [ :income1 ] ) . to include I18n . t ( " validations.numeric.whole_number " , field : " Buyer 1’s gross annual income " )
end
it " does not add an error if input is an integer " do
sales_log . income1 = 30_000
shared_validator . validate_numeric_step ( sales_log )
expect ( sales_log . errors ) . to be_empty
end
end
context " when validating a question with a step of 10 " do
it " adds an error if input is not a multiple of ten " do
sales_log . savings = 30_005
shared_validator . validate_numeric_step ( sales_log )
expect ( sales_log . errors [ :savings ] ) . to include I18n . t ( " validations.numeric.nearest_ten " , field : " Buyer’s total savings before any deposit paid " )
end
it " adds an error if the user attempts to input a number in exponent format " do
sales_log . savings = " 3e5 "
shared_validator . validate_numeric_step ( sales_log )
expect ( sales_log . errors [ :savings ] ) . to include I18n . t ( " validations.numeric.nearest_ten " , field : " Buyer’s total savings before any deposit paid " )
end
it " does not add an error if input is a multiple of ten " do
sales_log . savings = 30_000
shared_validator . validate_numeric_step ( sales_log )
expect ( sales_log . errors ) . to be_empty
end
end
context " when validating a question with a step of 0.01 " do
it " adds an error if input has more than 2 decimal places " do
sales_log . mscharge = 30 . 7418
shared_validator . validate_numeric_step ( sales_log )
expect ( sales_log . errors [ :mscharge ] ) . to include I18n . t ( " validations.numeric.nearest_hundredth " , field : " Monthly leasehold charges " )
end
it " does not add an error if the user attempts to input a number in exponent format " do
sales_log . mscharge = " 3e1 "
shared_validator . validate_numeric_step ( sales_log )
expect ( sales_log . errors ) . to be_empty
end
it " does not add an error if input has 2 or fewer decimal places " do
sales_log . mscharge = 30 . 74
shared_validator . validate_numeric_step ( sales_log )
expect ( sales_log . errors ) . to be_empty
end
end
end
end
Arthur Campbell
2 years ago
committed by
GitHub