Fix other tests and lint

spec/controllers/admin/case_logs_controller_spec.rb

@@ -1,7 +1,11 @@
 require "rails_helper"
 require_relative "../../support/devise"
+require_relative "../../request_helper"
 
 describe Admin::CaseLogsController, type: :controller do
+  before do
+    RequestHelper.stub_http_requests
+  end
   render_views
   let(:page) { Capybara::Node::Simple.new(response.body) }
   let(:resource_title) { "Logs" }

spec/controllers/admin/dashboard_controller_spec.rb

@@ -1,7 +1,11 @@
 require "rails_helper"
 require_relative "../../support/devise"
+require_relative "../../request_helper"
 
 describe Admin::DashboardController, type: :controller do
+  before do
+    RequestHelper.stub_http_requests
+  end
   render_views
   let(:page) { Capybara::Node::Simple.new(response.body) }
   let(:resource_title) { "Dashboard" }

spec/features/form/check_answers_page_spec.rb

@@ -1,5 +1,6 @@
 require "rails_helper"
 require_relative "helpers"
+require_relative "../../request_helper"
 
 RSpec.describe "Form Check Answers Page" do
   include Helpers
@@ -22,6 +23,7 @@ RSpec.describe "Form Check Answers Page" do
   let(:id) { case_log.id }
 
   before do
+    RequestHelper.stub_http_requests
     sign_in user
   end
 

spec/features/form/conditional_questions_spec.rb

@@ -1,5 +1,6 @@
 require "rails_helper"
 require_relative "helpers"
+require_relative "../../request_helper"
 
 RSpec.describe "Form Conditional Questions" do
   include Helpers
@@ -15,6 +16,7 @@ RSpec.describe "Form Conditional Questions" do
   let(:id) { case_log.id }
 
   before do
+    RequestHelper.stub_http_requests
     sign_in user
   end
 

spec/features/form/form_navigation_spec.rb

@@ -1,5 +1,6 @@
 require "rails_helper"
 require_relative "helpers"
+require_relative "../../request_helper"
 
 RSpec.describe "Form Navigation" do
   include Helpers
@@ -23,6 +24,7 @@ RSpec.describe "Form Navigation" do
   end
 
   before do
+    RequestHelper.stub_http_requests
     sign_in user
   end
 

spec/features/form/page_routing_spec.rb

@@ -1,5 +1,6 @@
 require "rails_helper"
 require_relative "helpers"
+require_relative "../../request_helper"
 
 RSpec.describe "Form Page Routing" do
   include Helpers
@@ -15,6 +16,7 @@ RSpec.describe "Form Page Routing" do
   let(:id) { case_log.id }
 
   before do
+    RequestHelper.stub_http_requests
     allow_any_instance_of(CaseLogValidator).to receive(:validate_pregnancy).and_return(true)
     sign_in user
   end

spec/features/form/saving_data_spec.rb

@@ -1,5 +1,6 @@
 require "rails_helper"
 require_relative "helpers"
+require_relative "../../request_helper"
 
 RSpec.describe "Form Saving Data" do
   include Helpers
@@ -31,6 +32,7 @@ RSpec.describe "Form Saving Data" do
   end
 
   before do
+    RequestHelper.stub_http_requests
     sign_in user
   end
 

spec/features/form/validations_spec.rb

@@ -1,7 +1,13 @@
 require "rails_helper"
 require_relative "helpers"
+require_relative "../../request_helper"
 
 RSpec.describe "validations" do
+  before do
+    RequestHelper.stub_http_requests
+    sign_in user
+  end
+
   include Helpers
   let(:user) { FactoryBot.create(:user) }
   let(:case_log) do
@@ -21,10 +27,6 @@ RSpec.describe "validations" do
   end
   let(:id) { case_log.id }
 
-  before do
-    sign_in user
-  end
-
   describe "Question validation" do
     context "given an invalid tenant age" do
       it " of less than 0 it shows validation" do

spec/helpers/tasklist_helper_spec.rb

@@ -1,6 +1,10 @@
 require "rails_helper"
+require_relative "../request_helper"
 
 RSpec.describe TasklistHelper do
+  before do
+    RequestHelper.stub_http_requests
+  end
   let(:empty_case_log) { FactoryBot.create(:case_log) }
   let(:case_log) { FactoryBot.create(:case_log, :in_progress) }
   form_handler = FormHandler.instance

spec/models/organisation_spec.rb

@@ -1,6 +1,10 @@
 require "rails_helper"
+require_relative "../request_helper"
 
 RSpec.describe Organisation, type: :model do
+  before do
+    RequestHelper.stub_http_requests
+  end
   describe "#new" do
     let(:user) { FactoryBot.create(:user) }
     let(:organisation) { user.organisation }

spec/models/user_spec.rb

@@ -1,6 +1,10 @@
 require "rails_helper"
+require_relative "../request_helper"
 
 RSpec.describe User, type: :model do
+  before do
+    RequestHelper.stub_http_requests
+  end
   describe "#new" do
     let(:user) { FactoryBot.create(:user) }
     let(:other_organisation) { FactoryBot.create(:organisation) }

spec/requests/case_log_controller_spec.rb

@@ -1,4 +1,5 @@
 require "rails_helper"
+require_relative "../request_helper"
 
 RSpec.describe CaseLogsController, type: :request do
   let(:owning_organisation) { FactoryBot.create(:organisation) }
@@ -19,6 +20,7 @@ RSpec.describe CaseLogsController, type: :request do
   end
 
   before do
+    RequestHelper.stub_http_requests
     allow(ENV).to receive(:[])
     allow(ENV).to receive(:[]).with("API_USER").and_return(api_username)
     allow(ENV).to receive(:[]).with("API_KEY").and_return(api_password)
@@ -136,6 +138,7 @@ RSpec.describe CaseLogsController, type: :request do
       let(:headers) { { "Accept" => "text/html" } }
 
       before do
+        RequestHelper.stub_http_requests
         sign_in user
         get "/logs", headers: headers, params: {}
       end

spec/requests/soft_validations_controller_spec.rb

@@ -1,10 +1,15 @@
 require "rails_helper"
+require_relative "../request_helper"
 
 RSpec.describe SoftValidationsController, type: :request do
   let(:params) { { case_log_id: case_log.id } }
   let(:url) { "/logs/#{case_log.id}/net-income/soft-validations" }
   let(:user) { FactoryBot.create(:user) }
 
+  before do
+    RequestHelper.stub_http_requests
+  end
+
   context "a not signed in user" do
     let(:case_log) { FactoryBot.create(:case_log, :in_progress) }
 

spec/views/case_log_index_view_spec.rb

@@ -1,5 +1,11 @@
 require "rails_helper"
+require_relative "../request_helper"
+
 RSpec.describe "case_logs/index" do
+  before do
+    RequestHelper.stub_http_requests
+  end
+
   let(:in_progress_log) { FactoryBot.create(:case_log, :in_progress) }
   let(:completed_log) { FactoryBot.create(:case_log, :completed) }