Browse Source

Capture failed bulk uploads (#2667)

* Capture failed bulk uploads

* Update capture exception to capture message
pull/2543/head^2
kosiakkatrina 3 months ago committed by GitHub
parent
commit
f99bd9756c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 17
      app/services/bulk_upload/lettings/validator.rb
  2. 17
      app/services/bulk_upload/sales/validator.rb

17
app/services/bulk_upload/lettings/validator.rb

@ -42,14 +42,25 @@ class BulkUpload::Lettings::Validator
def create_logs?
return false if any_setup_errors?
return false if row_parsers.any?(&:block_log_creation?)
return false if any_logs_already_exist? && FeatureToggle.bulk_upload_duplicate_log_check_enabled?
if row_parsers.any?(&:block_log_creation?)
Sentry.capture_message("Bulk upload log creation blocked: #{bulk_upload.id}.")
return false
end
if any_logs_already_exist? && FeatureToggle.bulk_upload_duplicate_log_check_enabled?
Sentry.capture_message("Bulk upload log creation blocked due to duplicate logs: #{bulk_upload.id}.")
return false
end
row_parsers.each do |row_parser|
row_parser.log.blank_invalid_non_setup_fields!
end
return false if any_logs_invalid?
if any_logs_invalid?
Sentry.capture_message("Bulk upload log creation blocked due to invalid logs after blanking non setup fields: #{bulk_upload.id}.")
return false
end
true
end

17
app/services/bulk_upload/sales/validator.rb

@ -41,14 +41,25 @@ class BulkUpload::Sales::Validator
def create_logs?
return false if any_setup_errors?
return false if row_parsers.any?(&:block_log_creation?)
return false if any_logs_already_exist? && FeatureToggle.bulk_upload_duplicate_log_check_enabled?
if row_parsers.any?(&:block_log_creation?)
Sentry.capture_exception("Bulk upload log creation blocked: #{bulk_upload.id}.")
return false
end
if any_logs_already_exist? && FeatureToggle.bulk_upload_duplicate_log_check_enabled?
Sentry.capture_exception("Bulk upload log creation blocked due to duplicate logs: #{bulk_upload.id}.")
return false
end
row_parsers.each do |row_parser|
row_parser.log.blank_invalid_non_setup_fields!
end
return false if any_logs_invalid?
if any_logs_invalid?
Sentry.capture_exception("Bulk upload log creation blocked due to invalid logs after blanking non setup fields: #{bulk_upload.id}.")
return false
end
true
end

Loading…
Cancel
Save