01c5d0876e
test: don't create vars inside other vars (for tests edited/created in this branch)
3 years ago
b9469f1090
test: explicitly reference org rels in "coordinator user's org doesn't hold stock" managing org test
3 years ago
fa30f9b20a
test: remove if statement from "coordinator user's org does hold stock" >=1 managing orgs managing org test
...
plus refactor previous test
3 years ago
3cc29b79b5
test: remove if statement from "coordinator user's org does hold stock" no managing orgs managing org test
3 years ago
5e02bff44f
test: remove if statement from "coordinator user's org doesn't hold stock" managing org test
3 years ago
960e507644
test: change let! to let where possible in spec/models/form/lettings/questions/stock_owner_spec.rb
3 years ago
01f17c4ec9
test: change let! to let where possible in spec/models/form/lettings/questions/managing_organisation_spec.rb
3 years ago
4478bb57ae
test: change let! to let where possible in spec/features/lettings_log_spec.rb
3 years ago
a5dc9d892b
test: finish overhauling owning and managing org tests in lettings_log_spec
3 years ago
10d8ef8dd0
test: improve test context descriptions in lettings_log_spec
3 years ago
b7082c6212
feat: don't set log owning org as user's org if that org doesn't hold stock
3 years ago
0d2bc50c4d
test: artificially reference org_rel2 to avoid lint offense
3 years ago
09a052ef40
test: add line breaks and start context descriptions with and (not if)
3 years ago
5ab11218b9
test: check owning & managing orgs set correctly when a log is created
3 years ago
ac0022b9e7
test: update lettings log feature tests
...
to differentiate between different numbers of stock owners when acting as a data coordinator
3 years ago
2e32567a8b
lint
3 years ago
37d843915f
fix: define log and current_user instance vars in label_from_value (housing prov.)
3 years ago
f377bc0c16
test: check housing prov. still selectable after deleting relationship
3 years ago
72650683a5
test: refactor housing providers opts tests (not support user)
3 years ago
99858867b3
test: make context definition more human-readable
3 years ago
aa311b4674
style: add space after user definition
3 years ago
443239f3d5
feat: update housing provider answer opts to include current HP in db
3 years ago
78dd4b2961
test: update housing provider opts tests for non-support user
3 years ago
7fda40e1e5
test: pass in log and user in housing provider opts test for support user
3 years ago
cacb18265a
lint
3 years ago
1c5eb09290
refactor: ensure label_from_value always accepts log & nil as args
3 years ago
308bc9f090
style: reorder instance vars and remove old comments in managing_organisation.rb
3 years ago
18f1ede496
fix: don't call user in get_answer_label in CYA component
3 years ago
bb04ed0d9a
test: refactor managing orgs opts tests for support user case
3 years ago
b0c899032f
test: add "(with hint)" to managing org opts test descriptions
3 years ago
8ae8775b44
test: make relationship deletion test consistent with other tests
3 years ago
a609102553
test: improve managing orgs opts tests when support
3 years ago
e2077dbe16
test: improve managing orgs opts test when not support
3 years ago
0fa8337e9f
wip
3 years ago
ee469ccd29
feat: check if managing org exists before trying to show it
3 years ago
17ba578f49
feat: add current managing org to answer opts
3 years ago
6aa4fd587d
test: check managing org not gone from answer opts when relationship deleted
3 years ago
d4e8e64c28
CLDC-863 Add practical completion/handover date validations ( #1198 )
...
* [CLDC-863] Add hard validation for hodate
* Add soft validation
3 years ago
d9a57ec1cb
CLDC-1627 Enable multiple inferred answers ( #1077 )
...
* Enable multiple inferred check answers values
* lint and add new conditions to check answers for age1
* Rename method
* Refactor inferred answer value
* rebase update
* update inferred_check_answers_value after rebase
* Move the method to private
* Add a missing test
* rebase changes
* Add prefers not to say as the displayed value for all household members
* update [0] to .first
* replace [0] with .first
3 years ago
9e9ff8a4e2
CLDC-850 Add relationship to buyer 1 validation to sales log ( #1178 )
...
* feat: add sales partner count validation
* test: update tests
* test: add new test
* refactor: DRYing
* feat: DRY general household member validation
* feat: add tests
* db: update
* feat: update shared validations
* test: update tests
* feat: add more validations
* feat: add more validation and update tests
* feat: add update method test
* test: update sales_log factory
* refactor: linting
* feat: remove numbering
* test: update tests
* feat: rename i18n vars, add validations everywhere
* tests: add new tests for new validation occurences
* db: update
* feat: add partner number validation to relevant fields rather than base
* test: update tests
* tests: refactor
* test: update
3 years ago
96b3aa4765
Gem upgrades ( #1206 )
...
* Update rack
* update globalid
* Update rails
3 years ago
ced6457a19
CLDC-1878 Add hint to mortgage amount question ( #1203 )
3 years ago
47ddf87282
CLDC-1858 Add new collection resources design ( #1204 )
...
* feat: update collection resources with new lettings log link and design
* refactor: linting
* feat: update size (previously was using in browser size not post-download)
3 years ago
45710ed661
CLDC 911 add hard validation to cash deposit ( #1186 )
...
* Tidy up test file
* Add hard validation to cash deposit
* Load validations
3 years ago
826eaf22f1
CLDC-1746 Show Handover question also on not on resale ( #1183 )
3 years ago
c07dde6794
fix: correct no-stock user names + update emails to prevent duplicates ( #1185 )
3 years ago
0099f7f46f
feat: remove association ( #1196 )
3 years ago
ecdc4d99c5
CLDC-1726 Update scheme and location display pages ( #1190 )
...
* feat: update scheme and log displays
* test: update tests
* test: update tests
3 years ago
daed7965e2
CLDC-1751 add extra borrowing question ( #1165 )
...
* feat: add page, tests, and update db
* feat: add depends on behaviour
* refactor: linting
* db: update
* db: update
3 years ago
1ae79eefa3
CLDC-1741 Remove scheme support provider question ( #1173 )
...
* feat: remove support services provider question page
* tests: update tests
* tests: update tests
* tests: update tests
* refactor: linting
* test: update tests
* db: migration to remove field
* test: update tests and more removal of managing_organisation from schemes
* refactor: linting
* db: update
3 years ago
Sam Seed
Phil Lee
Jack
kosiakkatrina
natdeanlewissoftwire
SamSeed-Softwire