submit-social-housing-lettings-and-sales-data

2031 Commits

225 Branches

266 Tags

68 MiB

Tree: 04b522d9b8

Commit Graph

Author	SHA1	Message	Date
Phil Lee	197e2ae4cb	[1778] Bulk upload errors (#1091 ) * lockdown bulk upload routes * able to view lettings bulk upload errors * add error count to bulk upload results * coverage for bulk upload filename on results * group bulk upload errors by row on results * able to view bulk upload sales results * scope lettings and sales bulk upload results * fix linting * call service correctly in test * add bulk upload sales questions mapping * appease linter * bulk upload error shows correct question - depending on log type it will show relevant question for the field concerned * use local disk for bulk upload for dev env - this saves the need to connect to S3 to play with bulk upload in dev environment * improve namespacing of classes * add job to process bulk uploads * use local disk storage for dev file upload * fix test * use inline active job queue_adapter for dev * use test active job queue adapter for test env * remove rubocop violation * delete bulk upload from disk after processing * populate errors with cell, row + metadata * update error message with something meaningful * shim in sales validator * able to parse sales bulk uploads * change migration to add purchase_code to errors * bulk upload error component renders purchaser code - when a sales log * populate purchaser_code for bulk upload errors - when log type is sales * remove superfluous private method	2 years ago
Phil Lee	add39e9611	[1716] [1717] Bulk upload part four (#1043 ) * add start of bulk upload logs journey * split upload controller into 2 * add year page to bulk upload journey * bulk upload years now dynamic * add placeholder for upload your file page * handle bulk upload when not in crossover * add bulk upload csv user journey * bulk upload now persists and sends to S3 * swap ruby-filemagic for file command * match csv or text file for validation * in_crossover_period? now uses overlap of forms - also moved from Form to FormHandler * add production env var for CSV bucket * stub kernel call methods * remove duplicate env var * hardcode env var for review apps * move feature toggle to FeatureToggle * crossover period checks now specific to the form * fix typo in bulk upload journey	2 years ago

Author

SHA1

Message

Date

Phil Lee

197e2ae4cb

[1778] Bulk upload errors (#1091 )

* lockdown bulk upload routes

* able to view lettings bulk upload errors

* add error count to bulk upload results

* coverage for bulk upload filename on results

* group bulk upload errors by row on results

* able to view bulk upload sales results

* scope lettings and sales bulk upload results

* fix linting

* call service correctly in test

* add bulk upload sales questions mapping

* appease linter

* bulk upload error shows correct question

- depending on log type it will show relevant question for the field
  concerned

* use local disk for bulk upload for dev env

- this saves the need to connect to S3 to play with bulk upload in dev
  environment

* improve namespacing of classes

* add job to process bulk uploads

* use local disk storage for dev file upload

* fix test

* use inline active job queue_adapter for dev

* use test active job queue adapter for test env

* remove rubocop violation

* delete bulk upload from disk after processing

* populate errors with cell, row + metadata

* update error message with something meaningful

* shim in sales validator

* able to parse sales bulk uploads

* change migration to add purchase_code to errors

* bulk upload error component renders purchaser code

- when a sales log

* populate purchaser_code for bulk upload errors

- when log type is sales

* remove superfluous private method

2 years ago

Phil Lee

add39e9611

[1716] [1717] Bulk upload part four (#1043 )

* add start of bulk upload logs journey

* split upload controller into 2

* add year page to bulk upload journey

* bulk upload years now dynamic

* add placeholder for upload your file page

* handle bulk upload when not in crossover

* add bulk upload csv user journey

* bulk upload now persists and sends to S3

* swap ruby-filemagic for file command

* match csv or text file for validation

* in_crossover_period? now uses overlap of forms

- also moved from Form to FormHandler

* add production env var for CSV bucket

* stub kernel call methods

* remove duplicate env var

* hardcode env var for review apps

* move feature toggle to FeatureToggle

* crossover period checks now specific to the form

* fix typo in bulk upload journey

2 years ago

1 Commits (04b522d9b8509d812c323331eb101f450b9aa2dc)