submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
natdeanlewissoftwire	d254ef8c62	CLDC-868 Add purchase price validations (#1225 ) * feat: wip behaviour * feat: hide in cya * feat: show in cya * feat: purchase price range service and rake task * feat: fix hodate validation and use purchase price ranges * db:update * feat: more saledate -> exdate fixing * feat: add min and max conditional text * refactor: linting * refactor: remove duplicated behaviour * refactor: linting * feat: update tests * test: add validation tests * test: add purchase price rangeimport service tests * refactor: linting * feat: allow translation text and title text to display currency formatting even when not a log field * feat: use i18n * feat: update i18n * refactor: pratical -> practical * refactor: linting * refactor: revert unnecessary change * feat: respond to PR comments * tests: update after merge * feat: improve currency interruption screen display * feat: update docs * feat: fix typo * feat: missing end after merge * feat: respond to PR comments * feat: add soft validation to beds and la pages * db:update * feat: revert saledate/exdate work * feat: revert saledate/exdate work * feat: revert saledate/exdate work * feat: revert saledate/exdate work * feat: revert saledate/exdate work * feat: PO comment responses * tests: update * refactor: linting * refactor: simplification * refactor: railsification * test: fix * refactor: use number_to_currency units * refactor: remove duplicated copy * db:update	2 years ago
Arthur Campbell	8fd31f3bfb	CLDC-886 add validations for discounts (#1214 ) * fix rebase conflicts * fix rebase conflicts * feat: update validation * fix rebase conflicts * fix rebase conflicts * test: update * fix rebase conflicts * fix rebase conflicts * fix rebase conflicts * fix rebase conflicts * fix rebase conflicts * implement before validation check to ensure that if the user declares no mortgage will be used, mortgage value is set to 0 * fix rebase conflicts * fix rebase conflicts * remove comment * fix rebase conflicts * Update config/locales/en.yml Co-authored-by: James Rose <james@jbpr.net> * alter order of before validation methods on sales log so that derived fields are calculated after invalidated dependent fields are cleared, fix tests broken by this change * add mortgage to derived variables so that mortgage value is set to 0 if a mortgage is not being used in the sale * remove hard validation of range for discount question and allow shared validation of numeric questions to handle this case * amend tests after rebasing * fix tests after rebasing * fix test and ensure schema correct after rebase --------- Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com> Co-authored-by: James Rose <james@jbpr.net>	2 years ago
Phil Lee	9513e1179d	CLDC-1764 Bulk upload filter (#1223 ) * refactor with extract method * can filter logs by bulk upload * hide log creation button when viewing bulk upload - this affects the logs index page filtering logs from a specific bulk upload * add info banner to bulk upload logs * placeholder for bulk upload logs header * when resuming bulk upload set filters * fill place holder with remaining logs to fix * add interstitial to resume if logs resolved * after resolving bulk upload logs show interstitial * fix linting error * extract view variable to helper method	2 years ago
natdeanlewissoftwire	4e15a119b9	CLDC-1765 Remove managing organisation for sales log from ui and backend (#1169 ) * feat: remove sales log managing_organisation_id * feat: move shared managing org behaviour from general log to lettings log, update tests * refator: linting * revert change to create * feat: tech review comments * db:update * tests: respond to comment * feat: revert change to avoid nil issue * test: update * feat: add validation and update db * feat: revert last commit * db:update * refactor: use safe navigation and lettings? * refactor: move safe navigator and add shared org_params to log	2 years ago
kosiakkatrina	7e176bba34	CLDC-845 Add sales household details validations (#1191 ) * Add min and max for age 1 validation * Add retirement value check column to the sales table * Add retirement value check question and page * Add retirement value check pages to household characteristics * Reuse soft validations for retirement in sales * Update person_indexes * Add old_persons_shared_ownership validation * Display the retirement value check in correct places depending on the joinpur value * Update page IDs * It's always joint purchase if age 2 is displayed * lint * lint	2 years ago
Phil Lee	0009d535fe	CLDC-1896 Bulk upload line endings (#1208 ) * add class to create logs from bulk upload * create logs when processing bulk uploads * remove bulk_upload_id from csv output * create bulk upload logs only if all valid - this will be changed later to allow for partial logs - and only to create logs when a threshold has been met * add method to blank invalid non setup fields * bulk upload log creation blanks invalid fields * fix incorrect logic for bulk upload renewal * fix linting * bulk upload log creation fail logs to sentry * fix bulk upload line ending parsing * extract bulk uploading csv parsing to class * use csv parser in log creator * change handle line endings mechanism - we now strip all windows line endings for unix based line endings - this normalises things making it simpler	2 years ago
kosiakkatrina	352dae8efe	CLDC-1468 Add property postcode questions to sales (#1187 ) * Add postcode fields * Add postcode page and questions * Add postcode page to the property information subsection * Only display local authority question if the la is not inferred * Fix migration * Move postcode validation * Infer LA fields from postcode * infer partial postcodes	2 years ago
kosiakkatrina	7d02752d82	Cldc 1440 household situation section (#1132 ) * feat: add question page and subsection (#1120) * feat: add question page and subsection * refactor: linting * feat: remove schema rows from other branch * feat: slight refactor, fix tag behaviour and add section tests * test: update and add tests * feat: update status behaviour * feat: update subsection status tag * refactor: linting * [CLDC-857] Add household wheelchair check (#1122) * [CLDC-857] Add household wheelchair check * Hide only if answered * Cldc 1497 ever served armed forces (#1124) * feat: add question and page * test: update tests * refactor: linting and slight test updates * test: fix tests * Cldc 1498 still serving armed forces (#1123) * feat: new question and tests * test: update subsection spec * test: update tests * feat: (future) conflict resolving * feat: more conflict resolution * feat: update db field * test: update id * test: updates * Cldc 1488 last accomodation (#1125) * Add postcode fields * Add previous postcode page and questions * Add last accommodation page to household situation subsection * add previous la known to the db * infer correct location fields * styling * Reorder disability questions (#1127) * [CLDC-1487] Add buyer1 previous tenure question (#1133) * use collection_start_year instead of the startdate (#1128) * [CLDC-1487] Add buyer 1 previous tenure Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com> * feat: fix routing (#1141) * Add last accommodation la question (#1142) * move hint text (#1146) Co-authored-by: natdeanlewissoftwire <94526761+natdeanlewissoftwire@users.noreply.github.com> Co-authored-by: Jack S <113976590+bibblobcode@users.noreply.github.com>	2 years ago
kosiakkatrina	6102b50ebe	Cldc 1776 sales information sections (#1106 ) * Mark subsection as completed if it is not displayed in the tasklist and hide it from the UI * Add sale_information section * add sales information subsections * Cldc 1531 staircasing (#1109) * Add staircase field to sales_logs table * Add staircase question and page * add staircase page to the shared ownership scheme subsection fix file name * Cldc 1539 previous bedrooms (#1108) * add frombeds field * Add previous_bedrooms page and question * add Previous Bedrooms page to the shared ownership subsection * Cldc 1532 about staircasing (#1110) * Add stairboughts and stairowned fields to the database * Add about staircasing page and questions * Add about staircasing page to the shared wnership scheme subsection * Add a space before percent * Cldc 1546 monthly rent (#1111) * Add monthly rent column to sales logs table * Add monthly rent question and page * Add monthly rent page to the shared ownership scheme subsection * Cldc 1535 exchange contracts (#1112) * Add exdate to sales logs table * Add exchange date page and question * Add exchange contracts page to the shared ownership subsection * derive exday, exmonth and exyear, tests and lint * rebase tests * Cldc 1538 la nominations (#1115) * Add la nominations column to sales logs table * Add La nominations page and questions * Add la nominations to the shared ownership subsection * Add accidentally removed files * Cldc 1545 about the deposit (#1113) * feat: add question(s) without depends_on behaviour * feat: separate ids for diff sections * test: update tests * test: add tests * tests: test tweaks * refactor: linting * Cldc 1538 la nominations (#1115) * Add la nominations column to sales logs table * Add La nominations page and questions * Add la nominations to the shared ownership subsection * Add accidentally removed files * feat: add question(s) without depends_on behaviour Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com> * Cldc 1533 is resale (#1118) * feat: add resale question and page * tests: add new tests * test: update previous tests * refactor: linting * refactor: linting * Cldc 1576 buyer prp (#1117) * Add soctenant field to sales logs * Add buyer previous page and question * Add buyer previous page to shared ownership scheme subsection * rebase migrate * rebase too * Cldc 1540 about price (#1121) * add price fields to the sales logs table * Add about proce questions * add about proce pages * Add about price pages to sale information sections * rebase changes * happy new year * Switch the order of sales log sections * Cldc 1540 fixes (#1130) * Update order of pages and remove wrong id's * Add spacing to the hint text * Cldc 1521 living before purchase (#1129) * feat: add new page and question and update db * test: add and update tests * feat: reset db * Only display from beds for social housing (#1131) * Cldc 1544 mortgage amount (#1136) * feat: add sales log seeds * feat: add question and page and update db * tests: add and update tests * Cldc 1540 fixes part two (#1135) * Change about_price_social_housing to about_price_shared_ownership and display it in all shared ownership cases * Change about_price to purchase_price and display it for outright sale * lint * Move exchange contracts date page (#1143) * feat: PO fix and tests (#1144) * feat: PO fix and tests * feat: simmplification * refactor: linting * feat: copy tweak Co-authored-by: natdeanlewissoftwire <94526761+natdeanlewissoftwire@users.noreply.github.com> Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>	2 years ago
kosiakkatrina	297ba50e78	Validate the user belongs to either the managing or owning organisation (#1055 ) * Validate that the user belongs to either the managing or owning organisation * do not reset created_by and remove user_organisation_chosen? * Do not default managing organisation to owning organisation * validate user belongs to organisation * update tests to specify created_by * clear create_by for support users * refactor * typo * rebase lint * Add `updated_by` to logs to track who was the last person to update a log - Reset `created_by` automatically when a form is updated and the owner does not belong to the managing or owning organisation * move reset_invalidated_dependent_fields!, update schema file and fix tests Co-authored-by: James Rose <james@jbpr.net>	2 years ago
kosiakkatrina	a1bd59552d	Cldc 1211 close collection period (#1044 ) * Conditionally display a correct review log text * do not allow the aswers from previous collection windows to be changed * does not let the user navigate to questions for previous collection year logs * Fix tests * Add some docs * Extract collection period check into a before_action and change path to rails route * update the tasklist message	2 years ago
kosiakkatrina	497f16ba9b	Cldc 1668 update impacted logs (#1035 ) * Mark log as impacted by deactivation when location is deactivated * Display affected logs in the table * Route affected logs to tenancy start date question * Update routes to get the tenancy start date page from form * update next_page_redirect_path * rename column * Fix tests * Add next_unresolved_page_id to pages * Update unresulved when the log is corrected * Mark logs as unresolved when scheme gets deactivated * display correct content when there are no unresolved logs * mark logs resolved after the user leaves check answers page * Display link in success banner and reset banner when the link is clicked * display inset hint text for unresolved log questions * Display unresolved logs banner * update banner message * Persist the link in the banner * update inset text * Update success banner text * Add unresolved and created_by scopes * rename method * add unresolved_log_redirect_page_id to form + typo and route * Add UnresolvedLogHelper and extract flack notice message * pluralize and return early * remove flash[:notice] = nil * to keep it consistent for sales log * Extract unresolved path and fix a link * extract resolve method and fix attribute nme * update path * typo	2 years ago
kosiakkatrina	ecf1fa1a28	Update enabled method (#990 ) * Change enabled? subsection method to check depends on using log questions and methods instead of a subsection status * Update sales subsections * Update rent validation tests to check all the affected fields * Update setup_completed? to check all the setup sections	2 years ago
Jack S	43b9c44c00	[CLDC-1486] Add ethnic group and background questions (#922 ) * Add derived variables to sales log * Add ethnic background question * Add inferred question response * Test inferred check questions of lettings logs	2 years ago
James Rose	d3075e4e43	Revert to `f4e6d6d6bb` (#887 )	2 years ago
natdeanlewissoftwire	f162f880ae	Revert "Merge remote-tracking branch 'origin/main' into CLDC-1429-output-la-code" This reverts commit `626e2bd1a6`, reversing changes made to `f86e13cea7`.	2 years ago
baarkerlounger	c937c1218d	Logs type refactoring (#871 ) * Log where generic * Move question invalidation to form class * Rubocop	2 years ago
Dushan	67ce147fc9	Extract base log and create sales log (#858 ) * Add abstract log class and sales log class Created a parent log class for sales log and lettings log. Any bits common to both sales and lettings can live in the parent class. As the sales log functionality is built up any commonalities with lettings log can be extracted into the parent log class. The sales log model is set up without a json form and instead the form is defined in code - like the setup section of the lettings log. * update sales logs controller * update lettings controller specs * update filter method name * update organisations controller * use lettings method * Add deleted tests back * lint Co-authored-by: Kat <katrina@madetech.com> Co-authored-by: Kat <kosiak.katrina@gmail.com>	2 years ago

18 Commits (1bc63c9fabd55a5699c2197b8ca2501b2ff9faf2)