Manny Dinssa
1da04df30f
CLDC-3411 correct 24 25 bulk upload error messages on lettings and sales ( #2556 )
...
* Update error messages and sales parser
3 months ago
Manny Dinssa
c3b85f2b50
CLDC-3411: Correct 24/25 bulk upload error messages on lettings and sales ( #2553 )
3 months ago
Rachael Booth
e66d5ea1d0
CLDC-3566: Clear duplicate set ids when a log ceases to be a duplicate through normal update flow ( #2534 )
...
* CLDC-3566: Clear duplicate set ids when a log ceases to be a duplicate in normal updates
* Refactor
* Ensure post not run twice in form controller tests
* Remove deduplication flow feature toggle
* Ensure class_name is defined in redirect path function
* Add tests for sales logs
3 months ago
Rachael Booth
6a42978fab
CLDC-3546: Add error to managing org when it does not have relevant rent period ( #2538 )
...
* CLDC-3546: Add error to managing org when it does not have relevant rent period
* Add test for :skip_bu_error
* Fix managing org question id
3 months ago
Manny Dinssa
ae190b268d
CLDC-3357-Previously-applied-filters-not-clearing ( #2528 )
3 months ago
kosiakkatrina
ba2cf8b4a9
Update location scopes ( #2537 )
3 months ago
Manny Dinssa
9b0cbac406
CLDC 2954 handle schemes with only deactivated locations ( #2510 )
3 months ago
Rachael Booth
975f072d2f
CLDC-3547: Validate against incomplete schemes being used in logs ( #2498 )
...
* CLDC-3547: Validate against incomplete schemes being used in logs
* Fix ordering issue in tests
3 months ago
kosiakkatrina
0f4bc32d6e
CLDC-3465 Update hard validations flow ( #2472 )
...
* Add check your errors page with clear links
* Update answer links
* Link to check your errors page
* Refactor check errors page
* Allow clearing answers
* Update styling and lint
* Add routing for sales
* lint
* Update page routing test
* Remove unused code
* CLDC-3465 Handle additional errors (#2480 )
* Keep check errors query params
* Add success banner
* Update confirm and continue button
* CLDC-3465 Allow clearing all error questions (#2483 )
* Allow clearing all error questions
* Update setup question link
* Update clear all to ignore setup questions
* Update correct_validation_action_href
* Extract some vriables
* CLDC-3465 Do not display non persisted values in check errors page (#2484 )
* Do not display non persisted values on check_errors page
* Remove govuk button styling from link
* Update warning message
* Update copy
3 months ago
kosiakkatrina
201ce23906
CLDC-1718 Update numeric questions to text fields ( #2527 )
...
* Update numeric questions to text fields
* Add test case
3 months ago
Manny Dinssa
8af9c255e3
CLDC-3567-Remove-DLUHC-references-from-CORE-pages ( #2530 )
3 months ago
kosiakkatrina
523f931770
Set the bulk upload value for correct log type ( #2533 )
3 months ago
kosiakkatrina
b9f900c98e
CLDC-3550 Fix rent_type 2024 BU mapping ( #2501 )
...
* Fix rent_type 2024 BU mapping
* Correct rent_type values
* Reuse rent_type mapping
* Track updated bulk uploads
* Fix test
3 months ago
kosiakkatrina
a4a83908ae
Refactor locations/index page ( #2523 )
3 months ago
kosiakkatrina
93cf84edca
CLDC-3027 Remove unused admin user code ( #2524 )
...
* Remove leftover admin user code
* Fix flaky tests
3 months ago
Manny Dinssa
fb89b47b6f
CLDC-3520 order scheme locations ( #2499 )
...
* List in alphabetical order using second line of address (.i.e. hint/name)
3 months ago
kosiakkatrina
a92c401a4d
Make sure archived filters are removed after crossover ( #2522 )
...
* Make sure archived filters are removed after crossover
* Fix feature tests
3 months ago
kosiakkatrina
6c03a6d203
CLDC-3562 Add scheme ID to the hint text ( #2519 )
...
* Add scheme ID to the hint text
* Fix flaky tests
3 months ago
Manny Dinssa
6273a076cb
CLDC-3414&5 Close 2023/24 - No new/No editing of entries ( #2520 )
...
* Close 2023/24
3 months ago
kosiakkatrina
a08f6a6ca8
Allow discarding users for merged orgs ( #2518 )
3 months ago
kosiakkatrina
f9cb42fbad
CLDC-2831 Remove mini-profiler from staging ( #2517 )
...
* Revert "Add mini profiler (#2513 )"
This reverts commit c19291c948
.
* Revert "CLDC-2831 Update profiler storage (#2514 )"
This reverts commit 2203577fee
.
3 months ago
Rachael Booth
d2964d73db
CLDC-3549: Ensure location page routing is updated when log is changed ( #2502 )
3 months ago
kosiakkatrina
e639c5c861
CLDC-3558 Display correct orgs data protection confirmation ( #2511 )
...
* Display correct orgs data protection confirmation
* Remove binding
4 months ago
kosiakkatrina
c19291c948
Add mini profiler ( #2513 )
4 months ago
kosiakkatrina
8ce22d37c0
CLDC-3289 Avoid freezing time (part 3) ( #2445 )
...
* Refactor tests #1
* Update tasklist helper tests
* Update task list helper
* Fix test
* Rabase fixes
* Update model/validations tests
* Update som sales log specs
* Remove missing addresses csv tasks
* Update some tests for 2023 collection close
* More fixes
* Revert sales shared examples change
* Fix test
* Update test nemes, remove time stub
4 months ago
Manny Dinssa
9e35b26dcf
Just use visible locations ( #2506 )
4 months ago
kosiakkatrina
ab4915c2aa
CLDC-2480 Allow deleting organisations ( #2459 )
...
* Add delete confirmation page
* Allow deleting organisation
* Add delete button
* Do not display deleted organisations as an option
* Update policy
* Display informative text and delete org resources
* lint
* Update organisation labels to show when deleted
* Refactor organisation label
* Update more labels
* Remove deleted orgs from schemes and autorize delete_confirmation
* Fix tests
4 months ago
kosiakkatrina
8dcd80e4f8
Strip scheme ID ( #2487 )
4 months ago
Rachael Booth
356d652db1
CLDC-3532: Make BU guidance back link depend on referrer ( #2482 )
...
* CLDC-3532: Make BU guidance back link depend on referrer
* Add tests for back_path
* Add guidance to homepage
* CLDC-3526: Update back_path
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
4 months ago
kosiakkatrina
905f869460
CLDC-2939 Link to organisations from user pages ( #2489 )
...
* Link to organisations from user pages
* Fix test
4 months ago
Rachael Booth
22522fb907
CLDC-3265: Duplicate whitespace row fix to sales BU ( #2481 )
...
* CLDC-3265: Duplicate whitespace row fix to sales BU
* CLDC-3265: Fix bu test that accidentally had whitespace only row
4 months ago
kosiakkatrina
9dc4f0bbb6
CLDC-3523 Only count visible logs on CSV downloads page ( #2477 )
...
* Only count visible logs
* Refactor
* Update csv count for sales
4 months ago
kosiakkatrina
4c0c0d15eb
CLDC-3508 Search both datasets for UPRN ( #2479 )
...
* Search both datasets for UPRN
* Update presenter
* Update request stubs
4 months ago
Rachael Booth
0718c10847
CLDC-3522: Correct logic around BU address search and address not found errors ( #2476 )
...
* CLDC-3522: Correct logic around BU address search and address not found errors
* Fix lint errors
4 months ago
kosiakkatrina
4b218e759f
Update upcoming deadlines dates ( #2462 )
4 months ago
Arthur Campbell
e566ff09a0
refactor property validations specs to avoid breaking on collection year change ( #2478 )
4 months ago
kosiakkatrina
07750ef26c
CLDC-3289 Avoid freezing time in tests (part 1) ( #2421 )
...
* Refactor tests #1
* Refactor helper tests
* Refactor model form tests
* Remove Timecop.returns
* Update tasklist helper tests
* Update task list helper
* Fix test
* Fix flaky search test
* Refactor
4 months ago
Arthur Campbell
5696e4b81e
Cldc 3452 remove dont know option from mortgage used when invalid ( #2470 )
...
* initial spec file refactor
remove create for build, extract form to own variable, remove non-valuable tests
run time from 0.29s to0.11s
* refactor to ensure that the questions ownershipsch instance variable and the value of ownershipsch on the log is the same in tests
* delete page test file which is not testing anything meaningful
* add error messages to the I18n yml
* update tests for the validations
* update validation logic
* update tests for the mortgage used question
* update the mortgage used question displayed answer options
* update bulk upload specs to reflect error message updates
* make use of brackets consistent within validation method
4 months ago
Arthur Campbell
d95e08cca2
Cldc 3492 oustide rent range soft validation not clearing for bedsit ( #2473 )
...
* mark the beds question as derived when the log is a bedsit to stop it from being cleared
* delete spec file not testing anything worthwhile
4 months ago
kosiakkatrina
a85fed42b1
CLDC-3504 Update period question options and error message ( #2463 )
...
* Update displayed_answer_options for period
* Update invalid rent period error message
4 months ago
Arthur Campbell
9e99f62e1d
ensure dates for beginning and end of collection year are correct in the crossover period ( #2469 )
5 months ago
Rachael Booth
34faa74a6c
CLDC-3447: Allow decimal discount percentage and increased validation tolerance ( #2427 )
...
* CLDC-3447: Allow decimal discount percentage and increased validation tolerance
* Update tests to use decimal discount
* Disable extra borrowing soft validation for 2024 onwards
* CLDC-3447: Make tolerance inclusive
* Fix linting error
* Fix method call
* Only change strictness when discount is present
* Remove blank line
5 months ago
kosiakkatrina
8edca7e34b
Update routing for major repairs question ( #2464 )
5 months ago
kosiakkatrina
75e8349c31
Update privacy notice links ( #2460 )
5 months ago
kosiakkatrina
9f623e0cb2
CLDC-3274 Display organisation merges for a longer period ( #2456 )
...
* Display organisation merges for a longer period
* Refactor
5 months ago
kosiakkatrina
dbca9323ae
Do not display deleted schemes in homepage count ( #2458 )
5 months ago
Rachael Booth
4a5a912816
CLDC-3483: Prevent/fix missing letting allocation values ( #2453 )
...
* CLDC-3483: Enforce that all lettings allocation method fields are present for bulk uploads
* CLDC-3483: Add task to fix existing nil letting allocation values
* Better capitalisation
* Keep previous punctuation
* Use find_each for task
5 months ago
Arthur Campbell
00c8567538
add paper trail to organisation rent periods in case of any further bugs ( #2461 )
5 months ago
kosiakkatrina
7d871edf74
CLDC-3482 Correct routing to property LA ( #2449 )
...
* Correct routing to property LA
* Add rake task to update LAs
5 months ago
kosiakkatrina
9ed93efc58
CLDC-3474 Correctly construct dates for template validation ( #2447 )
...
* Correctly construct dates
* Update tests
5 months ago