459420d7ee
CLDC-3541 Update sales financial validations ( #2546 )
...
* CLDC-3569 Update social homebuy errors (#2541 )
* Split questions
* Update the error message
* Add guidance
* Add back the headers
* Refactor depends_on
* Refactor further
* CLDC-3569 Update missed errors (#2548 )
* Update some skipped error messages
* Remove repeating deposit question
* CLDC-3571 Discounted ownership validation (#2547 )
* Rename discount to deposit discount
* Split about price rtb questions
* Update error message
* Update guidance partial
* Fix top_guidance_partial method
* Split about_price_not_rtb
* Update guidance partial and validation
* Fix bulk upload test
* Update deposit routed_to and guidance
* Refactor guidance links into a helper (#2551 )
* Refactor guidance links into a helper
* Refactor discounted ownership guidance
* CLDC-3570 Validations all other shared ownership types (#2550 )
* Update "all other shared ownership" errors
* CLDC-3571 Update outright sale financial validations (#2549 )
* Update outright sale validation message
* Add outright sale guidance
* Update duplicate page id
* User guidance helper
* Fix up financial equations content (#2552 )
* Tweak shared ownership validation wording
* Add top_guidance_partial to missed shared ownership questions
* Update discounted ownership validation message when there's no grant
* Update discounted sale guidance and errors
* Lint and update test
* Update BU test
* Update test
* CLDC-3569 Update guidance for shared ownership without mortgage (#2562 )
* Update how we display errors for BU
* Update guidance for shared ownership
* Add header to mortgage used question
* Update shared ownership guidance
* Update spacing (#2569 )
* Fix spacing again (#2570 )
* Update discounted ownership guidance (#2582 )
* Update discounted ownership guidance
* Add top guidance partial to outright sale
* Update outright sale guidance content
* Update model test
---------
Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
1 year ago
3773dd7d9b
Yarn package upgrades ( #2590 )
...
* Upgrade yarn packages to clear dependabot warnings
* Add prettier
* Run prettier
* Update docs
* Update babel config for moved plugins
* Add node_modules and similar to prettierignore, since on CI it's not run from same directory as gitignore
1 year ago
331ee8f0e8
CLDC-3575: Remove reference to dluhc on GitHub ( #2581 )
...
* Update github README.md picture
* Change name
* Remove old image & change private to public beta text
1 year ago
bee90d6f99
CLDC-2588++update soft validation errors in bulk upload ( #2577 )
...
* Change table column width with govuk class
* Add html_safe to error message fields
1 year ago
85bbbe6108
CLDC-3556: Ignore address data in bulk upload for supported housing logs ( #2540 )
...
* Only set address data in BU for general needs logs
* Don't route to uprn selection page for supported housing logs
* Fix tests
1 year ago
72890e516e
CLDC-3564 Update filter search ( #2535 )
...
* Add search controller
* Update on confirm
* lint
* Update search endpoint
* remove assigned to filter options
* Explicitly define host in the url
* Update search controller
* Allow searching organisations
* Allow filtering by user without js
* Allow filtering by org without js
* Add filter_type to method calls
* Update filter helpers
* Hide text search input when js is enabled
* Some feature test updates
* fix model test
* Delete a random file 👀
* lint
* Update more tests
* Update inner text for filter
* Keep csv filters the same
* Clear free text filters for csv dowloads
* User path helper
* Update scheme filters and log scopes
* Update which users we can filter by
1 year ago
53ae216bae
Revert "CLDC-3566: Clear duplicate set ids when a log ceases to be a duplicate through normal update flow ( #2534 )" ( #2563 )
...
This reverts commit e66d5ea1d0
1 year ago
c7bf7a037d
CLDC-2588-Separate soft and hard validation errors in bulk upload ( #2545 )
...
* Separate soft and hard validation errors in bulk upload
1 year ago
979e2a6ba2
Filter out location questions before checking the routing ( #2557 )
1 year ago
1da04df30f
CLDC-3411 correct 24 25 bulk upload error messages on lettings and sales ( #2556 )
...
* Update error messages and sales parser
1 year ago
c3b85f2b50
CLDC-3411: Correct 24/25 bulk upload error messages on lettings and sales ( #2553 )
1 year ago
e66d5ea1d0
CLDC-3566: Clear duplicate set ids when a log ceases to be a duplicate through normal update flow ( #2534 )
...
* CLDC-3566: Clear duplicate set ids when a log ceases to be a duplicate in normal updates
* Refactor
* Ensure post not run twice in form controller tests
* Remove deduplication flow feature toggle
* Ensure class_name is defined in redirect path function
* Add tests for sales logs
1 year ago
6a42978fab
CLDC-3546: Add error to managing org when it does not have relevant rent period ( #2538 )
...
* CLDC-3546: Add error to managing org when it does not have relevant rent period
* Add test for :skip_bu_error
* Fix managing org question id
1 year ago
ae190b268d
CLDC-3357-Previously-applied-filters-not-clearing ( #2528 )
1 year ago
ba2cf8b4a9
Update location scopes ( #2537 )
1 year ago
9b0cbac406
CLDC 2954 handle schemes with only deactivated locations ( #2510 )
1 year ago
975f072d2f
CLDC-3547: Validate against incomplete schemes being used in logs ( #2498 )
...
* CLDC-3547: Validate against incomplete schemes being used in logs
* Fix ordering issue in tests
1 year ago
0f4bc32d6e
CLDC-3465 Update hard validations flow ( #2472 )
...
* Add check your errors page with clear links
* Update answer links
* Link to check your errors page
* Refactor check errors page
* Allow clearing answers
* Update styling and lint
* Add routing for sales
* lint
* Update page routing test
* Remove unused code
* CLDC-3465 Handle additional errors (#2480 )
* Keep check errors query params
* Add success banner
* Update confirm and continue button
* CLDC-3465 Allow clearing all error questions (#2483 )
* Allow clearing all error questions
* Update setup question link
* Update clear all to ignore setup questions
* Update correct_validation_action_href
* Extract some vriables
* CLDC-3465 Do not display non persisted values in check errors page (#2484 )
* Do not display non persisted values on check_errors page
* Remove govuk button styling from link
* Update warning message
* Update copy
1 year ago
201ce23906
CLDC-1718 Update numeric questions to text fields ( #2527 )
...
* Update numeric questions to text fields
* Add test case
1 year ago
8af9c255e3
CLDC-3567-Remove-DLUHC-references-from-CORE-pages ( #2530 )
1 year ago
523f931770
Set the bulk upload value for correct log type ( #2533 )
1 year ago
b9f900c98e
CLDC-3550 Fix rent_type 2024 BU mapping ( #2501 )
...
* Fix rent_type 2024 BU mapping
* Correct rent_type values
* Reuse rent_type mapping
* Track updated bulk uploads
* Fix test
1 year ago
a4a83908ae
Refactor locations/index page ( #2523 )
1 year ago
93cf84edca
CLDC-3027 Remove unused admin user code ( #2524 )
...
* Remove leftover admin user code
* Fix flaky tests
1 year ago
fb89b47b6f
CLDC-3520 order scheme locations ( #2499 )
...
* List in alphabetical order using second line of address (.i.e. hint/name)
1 year ago
a92c401a4d
Make sure archived filters are removed after crossover ( #2522 )
...
* Make sure archived filters are removed after crossover
* Fix feature tests
1 year ago
6c03a6d203
CLDC-3562 Add scheme ID to the hint text ( #2519 )
...
* Add scheme ID to the hint text
* Fix flaky tests
1 year ago
6273a076cb
CLDC-3414&5 Close 2023/24 - No new/No editing of entries ( #2520 )
...
* Close 2023/24
1 year ago
a08f6a6ca8
Allow discarding users for merged orgs ( #2518 )
1 year ago
f9cb42fbad
CLDC-2831 Remove mini-profiler from staging ( #2517 )
...
* Revert "Add mini profiler (#2513 )"
This reverts commit c19291c948#2514 )"
This reverts commit 2203577fee
1 year ago
d2964d73db
CLDC-3549: Ensure location page routing is updated when log is changed ( #2502 )
1 year ago
e639c5c861
CLDC-3558 Display correct orgs data protection confirmation ( #2511 )
...
* Display correct orgs data protection confirmation
* Remove binding
1 year ago
c19291c948
Add mini profiler ( #2513 )
1 year ago
8ce22d37c0
CLDC-3289 Avoid freezing time (part 3) ( #2445 )
...
* Refactor tests #1
* Update tasklist helper tests
* Update task list helper
* Fix test
* Rabase fixes
* Update model/validations tests
* Update som sales log specs
* Remove missing addresses csv tasks
* Update some tests for 2023 collection close
* More fixes
* Revert sales shared examples change
* Fix test
* Update test nemes, remove time stub
1 year ago
9e35b26dcf
Just use visible locations ( #2506 )
1 year ago
ab4915c2aa
CLDC-2480 Allow deleting organisations ( #2459 )
...
* Add delete confirmation page
* Allow deleting organisation
* Add delete button
* Do not display deleted organisations as an option
* Update policy
* Display informative text and delete org resources
* lint
* Update organisation labels to show when deleted
* Refactor organisation label
* Update more labels
* Remove deleted orgs from schemes and autorize delete_confirmation
* Fix tests
1 year ago
8dcd80e4f8
Strip scheme ID ( #2487 )
1 year ago
356d652db1
CLDC-3532: Make BU guidance back link depend on referrer ( #2482 )
...
* CLDC-3532: Make BU guidance back link depend on referrer
* Add tests for back_path
* Add guidance to homepage
* CLDC-3526: Update back_path
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
1 year ago
905f869460
CLDC-2939 Link to organisations from user pages ( #2489 )
...
* Link to organisations from user pages
* Fix test
1 year ago
22522fb907
CLDC-3265: Duplicate whitespace row fix to sales BU ( #2481 )
...
* CLDC-3265: Duplicate whitespace row fix to sales BU
* CLDC-3265: Fix bu test that accidentally had whitespace only row
1 year ago
9dc4f0bbb6
CLDC-3523 Only count visible logs on CSV downloads page ( #2477 )
...
* Only count visible logs
* Refactor
* Update csv count for sales
1 year ago
4c0c0d15eb
CLDC-3508 Search both datasets for UPRN ( #2479 )
...
* Search both datasets for UPRN
* Update presenter
* Update request stubs
1 year ago
0718c10847
CLDC-3522: Correct logic around BU address search and address not found errors ( #2476 )
...
* CLDC-3522: Correct logic around BU address search and address not found errors
* Fix lint errors
1 year ago
4b218e759f
Update upcoming deadlines dates ( #2462 )
1 year ago
e566ff09a0
refactor property validations specs to avoid breaking on collection year change ( #2478 )
1 year ago
07750ef26c
CLDC-3289 Avoid freezing time in tests (part 1) ( #2421 )
...
* Refactor tests #1
* Refactor helper tests
* Refactor model form tests
* Remove Timecop.returns
* Update tasklist helper tests
* Update task list helper
* Fix test
* Fix flaky search test
* Refactor
1 year ago
5696e4b81e
Cldc 3452 remove dont know option from mortgage used when invalid ( #2470 )
...
* initial spec file refactor
remove create for build, extract form to own variable, remove non-valuable tests
run time from 0.29s to0.11s
* refactor to ensure that the questions ownershipsch instance variable and the value of ownershipsch on the log is the same in tests
* delete page test file which is not testing anything meaningful
* add error messages to the I18n yml
* update tests for the validations
* update validation logic
* update tests for the mortgage used question
* update the mortgage used question displayed answer options
* update bulk upload specs to reflect error message updates
* make use of brackets consistent within validation method
1 year ago
d95e08cca2
Cldc 3492 oustide rent range soft validation not clearing for bedsit ( #2473 )
...
* mark the beds question as derived when the log is a bedsit to stop it from being cleared
* delete spec file not testing anything worthwhile
1 year ago
a85fed42b1
CLDC-3504 Update period question options and error message ( #2463 )
...
* Update displayed_answer_options for period
* Update invalid rent period error message
1 year ago
9e99f62e1d
ensure dates for beginning and end of collection year are correct in the crossover period ( #2469 )
1 year ago
kosiakkatrina
Rachael Booth
Manny Dinssa
Arthur Campbell