Nat Dean-Lewis
64ee34c7db
CLDC-4297: final validation test tweaks
2 months ago
Nat Dean-Lewis
af29f0576f
CLDC-4297: refactor and simplify
2 months ago
Nat Dean-Lewis
a510ce78fc
CLDC-4297: test 0.0 and r explicitly
2 months ago
Nat Dean-Lewis
0d0388f53b
CLDC-4297: don't allow 0.0
2 months ago
Nat Dean-Lewis
972ac9a950
CLDC-4297: update case insensitive field tests
2 months ago
Nat Dean-Lewis
f582e99931
CLDC-4297: don't allow 0 for mscharge and update tests
2 months ago
Nat Dean-Lewis
01d798d304
CLDC-4297: specify same value errors
2 months ago
Nat Dean-Lewis
5f09a46eff
CLDC-4297: misc cleanup
2 months ago
Nat Dean-Lewis
5ffa8ff2ba
CLDC-4297: test negatives and unify order
2 months ago
Nat Dean-Lewis
47a532017c
CLDC-4297: test improvements
2 months ago
Nat Dean-Lewis
86354a2fef
CLDC-4297: allow 0 for newservicecharges
2 months ago
Nat Dean-Lewis
a3a04998b0
CLDC-4297: comment update
2 months ago
Nat Dean-Lewis
4a399c4668
CLDC-4297: test updates
2 months ago
Nat Dean-Lewis
3f2afa3950
CLDC-4297: add warning comment on block_log_creation!
2 months ago
Nat Dean-Lewis
f07867ecd7
CLDC-4297: updated error handling
2 months ago
Nat Dean-Lewis
e0d63b112f
CLDC-4297: add R behaviour back in
2 months ago
Nat Dean-Lewis
cdf72a17b8
CLDC-4297: remove R tests
2 months ago
Nat Dean-Lewis
bb1a799c3b
CLDC-4297: add test override
2 months ago
Nat Dean-Lewis
af9d89b9f0
CLDC-4297: add tests for inferences and confirm R inference
2 months ago
Nat Dean-Lewis
723fd8eba3
CLDC-4297: clarify test naming
2 months ago
Nat Dean-Lewis
ae6babd460
CLDC-4263: update tests
2 months ago
Nat Dean-Lewis
491652dc12
CLDC-4263: fix "no" mapping and allow decimal mscharge
2 months ago
Nat Dean-Lewis
97845df2f0
CLDC-4263: align new service charge questions with bu spec
2 months ago
samyou-softwire
1044bf8163
Merge branch 'main' into CLDC-4270-fix-text-being-coerced-to-0-on-integer-fields
2 months ago
Nat Dean-Lewis
d87aba906b
CLDC-4236: Deploy review apps manually using PR labels ( #3238 )
...
* CLDC-4263: implement minimal label-based approach
* CLDC-4263: add descriptive comment
* CLDC-4263: separate comment workflow
* CLDC-4263: add label check to code workflow
* CLDC-4263: always hint initially
* CLDC-4263: copy change test
* Revert "CLDC-4263: copy change test"
This reverts commit 09df8ab28f .
* CLDC-4263: rename review app workflows for clarity
* CLDC-4263: remove broken workflow_dispatches
* CLDC-4263: rename label
* CLDC-4236: renaming and commenting
2 months ago
Carolyn Barker
de4e0945a1
CLDC-4146 infer no other partners ( #3152 )
...
* CLDC-4146 infer no to multiple partners
* CLDC-4146 try removing factory change
* Simplify inference logic
* Fix not equals logic
* Improve person_partner tests
* Add tests for new not equals logic
* Improve person_lead_partner tests
* Fix inference logic
* Revert to simpler inference logic
* Correct hidden_in_check_answers logic
* Fixed derived?
* Improve lettings log variables tests
* Pull out resetting partner fields into method
* Convert 'else next' to guard clause
* Refactor infer_only_partner!
* Match updated requirements
* Fix tests
* Small tweaks
* Remove redundant logic from infer_at_most_one_relationship!
* Remove redundant `disable_clearing_if_not_routed_or_dynamic_answer_options`
* Add tests for question number
* Remove puts
* Refactor derived fields tests
* Fix lint
* After build, set nil values for `details_known` to 0
* Add details_known to tests
* Add question mark to method name
* Rewrite `is_another_person_partner?` to be `is_any_person_partner?`
* Move skip in form flow method from page to question
* Fix tests
* Fix tests after merge
---------
Co-authored-by: Carolyn <carolyn.barker@softwire.com>
Co-authored-by: oscar-richardson-softwire <oscar.richardson@softwire.com>
2 months ago
dependabot[bot]
c494890dea
Bump devise from 4.9.3 to 5.0.3 ( #3244 )
...
Bumps [devise](https://github.com/heartcombo/devise ) from 4.9.3 to 5.0.3.
- [Release notes](https://github.com/heartcombo/devise/releases )
- [Changelog](https://github.com/heartcombo/devise/blob/main/CHANGELOG.md )
- [Commits](https://github.com/heartcombo/devise/compare/v4.9.3...v5.0.3 )
---
updated-dependencies:
- dependency-name: devise
dependency-version: 5.0.3
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 months ago
Nat Dean-Lewis
384435fdc6
Revert "CLDC-4246: Starter tenancy type copy updates ( #3229 )" ( #3242 )
...
This reverts commit 66dfdbfbb3 .
2 months ago
samyou-softwire
a859c104a5
CLDC-4270: Add ? to boolean method
2 months ago
samyou-softwire
00c1a2cbc7
fixup! CLDC-4270: Add tests
2 months ago
Samuel Young
3bcc6627c0
Revert "CLDC-4179: Amend sales duplicate log check ( #3207 )" ( #3241 )
...
This reverts commit c085cbb572 .
2 months ago
samyou-softwire
9ecb926858
CLDC-4270: Fix tests post merge
2 months ago
samyou-softwire
f44ace7d7f
Merge branch 'main' into CLDC-4270-fix-text-being-coerced-to-0-on-integer-fields
2 months ago
samyou-softwire
4fe2e5b4bc
fixup! CLDC-4270: Port changes to other years' parsers
2 months ago
samyou-softwire
35cbe23973
fixup! CLDC-4270: Add an error for fields with the wrong type for 2026 lettings
2 months ago
Samuel Young
61eb52516d
CLDC-4204: Update bulk upload fields sales ( #3223 )
...
* CLDC-4204: Renumber fields to match spec
* CLDC-4204: Update log to csv for 2026
* CLDC-4204: Cleanup BU todo commments
* CLDC-4204: Replace BU example file
* CLDC-4204: Update row parser question titles to match form
* fixup! CLDC-4204: Update row parser question titles to match form
fix sales log typo
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
* fixup! CLDC-4204: Renumber fields to match spec
update dupe fields comment
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
* fixup! CLDC-4204: Renumber fields to match spec
check the same field as before
---------
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
2 months ago
Nat Dean-Lewis
c95e33bf35
CLDC-4295: hhtype export updates ( #3232 )
...
* CLDC-4295: use correct hhtype header for 26 sales export specs
* CLDC-4295: update log var defs spec
2 months ago
samyou-softwire
42c5653198
Merge branch 'main' into CLDC-4270-fix-text-being-coerced-to-0-on-integer-fields
2 months ago
samyou-softwire
c270ba3d10
CLDC-4270: Port changes to other years' parsers
...
sales 2025 2026
lettings 2026
2 months ago
samyou-softwire
34cd70f2ea
CLDC-4270: Add tests
2 months ago
samyou-softwire
37faca4a12
CLDC-4270: Add an error for fields with the wrong type for 2026 lettings
2 months ago
Samuel Young
599307029d
CLDC-4215, CLDC-4216: Add mortgage used Don't Know option ( #3208 )
...
* CLDC-4215: Show Don't Know on all paths of mortgageused
* CLDC-4215: Update tests
* fixup! CLDC-4215: Show Don't Know on all paths of mortgageused
* fixup! CLDC-4215: Update tests
cover all cases
* fixup! CLDC-4215: Show Don't Know on all paths of mortgageused
* fixup! CLDC-4215: Update tests
2 months ago
Nat Dean-Lewis
1c4cfe5d1d
CLDC-4169, CLDC-4170, CLDC-4171, CLDC-4172: Remove VRTB discounted ownership type option from question and copy ( #3202 )
...
* CLDC-4169: remove VRTB option functionality
* CLDC-4169: remove VRTB option from copy
* CLDC-4169: update tests
* CLDC-4169: copy updates
* CLDC-4169: test updates
* CLDC-4169: test bu file updates
* CLDC-4169: test bu file updates
2 months ago
Nat Dean-Lewis
cd51f7c2c4
CLDC-4166: How many live in property updates ( #3194 )
...
* CLDC-4166: question updaets
* CLDC-4166: question updates
* CLDC-4166: test updates
* CLDC-4166: test updates
* CLDC-4166: test updates
* CLDC-4226: Index logs by org and ID (#3199 )
* CLDC-4226: index logs by org and id
* CLDC-4226: include teamwide non-functional schema change
* CLDC-4226: schema update
* CLDC-4176: fix failing tests
* CLDC-4176: renumber case insensitive fields test
* CLDC-4166: update csv export spec
* CLDC-4166: linting
* CLDC-4166: copy updates in fixtures
* CLDC-4166: copy updates in fixtures
* CLDC-4166: copy updates in fixtures
* CLDC-4166: var defs count update
* CLDC-4166: fixtures tweak for hhtype
* CLDC-4166: fixtures tweak for hhtype
* CLDC-4166: fixtures tweak for hhtype
* CLDC-4166: export update
* CLDC-4166: whitespace linting
* CLDC-4166: update number_of_others_in_property_spec.rb
* CLDC-4166: update log_variable_definitions_spec.rb
* CLDC-4166: update sales_log_csv_service_spec.rb
* CLDC-4166: update tests
* CLDC-4166: update tests
2 months ago
Samuel Young
f5f0e663e0
CLDC-4184: Update question numbers for sales ( #3221 )
...
* CLDC-4184: Consolidate logic for questions that appear in multiple subsections
* CLDC-4184: Ensure all 2025 questions have a number
* CLDC-4184: Add 2026 question numbers
* CLDC-4184: Update question numbers to match paper form
* CLDC-4184: Use the standard question hash function
* CLDC-4184: Lint
* CLDC-4184: Update tests
* fixup! CLDC-4184: Update question numbers to match paper form
* CLDC-4184: Commonise person question logic in sales
* fixup! CLDC-4184: Update question numbers to match paper form
add missing 2026 question
* fixup! CLDC-4184: Use the standard question hash function
missed nationality
* fixup! CLDC-4184: Update question numbers to match paper form
fix q111
* fixup! CLDC-4184: Update question numbers to match paper form
some missed questions
* CLDC-4184: Lint
* CLDC-4184: Fix test
2 months ago
Nat Dean-Lewis
ed2fdf344e
CLDC-4181: Add new sale range file ( #3228 )
...
* CLDc-4181: add 2026 sale ranges
* CLDc-4181: file cleanup
2 months ago
Nat Dean-Lewis
66dfdbfbb3
CLDC-4246: Starter tenancy type copy updates ( #3229 )
...
* CLDC-4249: reorder answer options
* CLDC-4246: reword question and add hint text for 25/26 and 26/27
* Revert "CLDC-4249: reorder answer options"
This reverts commit 26edc51615 .
* CLDC-4246: update tenancy type cya text and other copy
* CLDC-4246: update tenancy type cya text and other copy in 2025
2 months ago
Samuel Young
c085cbb572
CLDC-4179: Amend sales duplicate log check ( #3207 )
...
* CLDC-4179: Add sexrab & postcode to frontend duplicate log checks
* CLDC-4179: Add sexrab & postcode to BU duplicate log checks
* CLDC-4179: Update tests
2 months ago
Samuel Young
d2927f3e7a
CLDC-4212, CLDC-4213, CLDC-4214: Add 0.1% tolerance to all calculations that involve %s of a value ( #3214 )
...
* CLDC-4212: Add 0.1% tolerance to % calculations
this is to specifically allow 0.1% more or less than the calculation expects, for those that contain %s in them
this removes difficulties on adding 66.6% equity (or should it be 66.7%?)
* CLDC-4212: Remove discount soft validation
was replaced by a hard validation in CLDC-1899 so no longer serves a purpose
* CLDC-4212: Add tests
* fixup! CLDC-4212: Add 0.1% tolerance to % calculations
calculate a tolerance instead
* fixup! CLDC-4212: Add 0.1% tolerance to % calculations
update comment
2 months ago
Samuel Young
5ce2d0cb47
CLDC-4164, CLDC-4165: Update purchase price minimum to £15,000 for 2026 onwards ( #3198 )
...
* CLDC-4164: Update purchase price minimum to £15,000 for 2026 onwards
* CLDC-4164: Apply £15,000 minimum validation to shared ownership purchase price
* CLDC-4164: Update tests
* fixup! CLDC-4164: Update tests
add min tests for 25 and 26
2 months ago