submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
Manny Dinssa	8af9c255e3	CLDC-3567-Remove-DLUHC-references-from-CORE-pages (#2530 )	5 months ago
kosiakkatrina	42f89680e5	CLDC-3495 Reduce persisted models in tests (#2507 ) * Remove legacy user from user factory * Build instead of creating in some model tests * Do not create a new DPO for orgs created within user factories * Add original setup doc * Update documentation with updated factories * Fix up DSA creations	6 months ago
Arthur Campbell	a24bafe5df	Cldc 3114 enable support control of rent periods per organisation (#2442 ) * write helper method to support having the correct rent period checkboxes checked * update new and create in organisations controller and view to enable creation of relevant organisation rent periods write tests for this * small changes to models * enable editing rent period in the UI display change button on org details page display rent periods question on edit page * enable updating org rent periods update logic in #update related tests * alter redirect after support user creates an organisation * adjust various UI elements: ordering of rows, copy changes, label size and associated tests * rework the #rent_period_labels method to return All under the correct conditions, rework tests related to that. + fix assorted tests that were either flakey or breaking due to addition of rent periods logic to create and update * amend failing tests and resolve linting complaints * changes following review * disable checkboxes for rent periods if they are in use so that users are not able to make existing logs invalid hint text added to the question to explain this I have also added all rent periods to a hidden field to remove the need to fetch them again form the db in the update method * update validation to reflect the fact that an org having no associated rent periods no longer means they accept all rent periods update tests adding both cases and removing unnecessary additional db additions * rake task to create rent period associations for orgs that have none * revert mistaken copy changes in designs * create rent periods in factories as default, with an option to skip. skip automatic creation in tests specifically related to rent periods * stub api call for factory value, update csv tests and fixtures accordingly * extract a good chunk of tests out of lettings_log_spec and into a dedicated derived fields spec file. in many cases refactor tests * remove before(:context) and associated patterns. use assign_attributes in various places for cleaner code * escape . in regex for API call stubs to satisfy codeQL remove destroy_all call at the start of a test that was dealing with leftover modesl in the test db * further refactoring of various tests to reduce database interactions and improve speed * remove outdated distinction between unitletas mappings from before 23/24 * remove tests that seem to be testing active record and/or ruby Date class	7 months ago
Arthur Campbell	1ebf71129e	Revert "Cldc 3114 enable support control of rent periods per organisation (#2…" (#2439 ) This reverts commit `eda367afb0`.	7 months ago
Arthur Campbell	eda367afb0	Cldc 3114 enable support control of rent periods per organisation (#2389 ) * write helper method to support having the correct rent period checkboxes checked * update new and create in organisations controller and view to enable creation of relevant organisation rent periods write tests for this * small changes to models * enable editing rent period in the UI display change button on org details page display rent periods question on edit page * enable updating org rent periods update logic in #update related tests * alter redirect after support user creates an organisation * adjust various UI elements: ordering of rows, copy changes, label size and associated tests * rework the #rent_period_labels method to return All under the correct conditions, rework tests related to that. + fix assorted tests that were either flakey or breaking due to addition of rent periods logic to create and update * amend failing tests and resolve linting complaints * changes following review * disable checkboxes for rent periods if they are in use so that users are not able to make existing logs invalid hint text added to the question to explain this I have also added all rent periods to a hidden field to remove the need to fetch them again form the db in the update method * update validation to reflect the fact that an org having no associated rent periods no longer means they accept all rent periods update tests adding both cases and removing unnecessary additional db additions * rake task to create rent period associations for orgs that have none * revert mistaken copy changes in designs * create rent periods in factories as default, with an option to skip. skip automatic creation in tests specifically related to rent periods * stub api call for factory value, update csv tests and fixtures accordingly * extract a good chunk of tests out of lettings_log_spec and into a dedicated derived fields spec file. in many cases refactor tests * remove before(:context) and associated patterns. use assign_attributes in various places for cleaner code * escape . in regex for API call stubs to satisfy codeQL remove destroy_all call at the start of a test that was dealing with leftover modesl in the test db * further refactoring of various tests to reduce database interactions and improve speed * remove outdated distinction between unitletas mappings from before 23/24 * remove tests that seem to be testing active record and/or ruby Date class	7 months ago
Robert Sullivan	d2518d7c38	CLDC-2481: Add ability to disable organisations (#2293 ) * CLDC-2481: Add ability to disable organisations. * CLDC-2481: Add ability to disable organisations * Tidy up tests * CLDC-2481: Review markups * CLDC-2481: Fix location and scheme filters * Add banners for stock owners and managing agents * Update view test --------- Co-authored-by: Kat <katrina@kosiak.co.uk>	9 months ago
kosiakkatrina	29c01fa959	CLDC-2695 Display signed at date instead of created at date for DSAs (#1941 ) * Dislplay signed at date instead of created at date * Add signed at and dpo details to DPC seed	1 year ago
kosiakkatrina	824451eca1	CLDC-2246 Add schemes status filters (#1796 ) * Filter schemes * Add status filter to schemes pages * Filter schemes deactivating in more than 6 monts as active * Always serialize session filters for schemes * Remove ordering in search, fix tests * Update incomplete scope	1 year ago
Jack	d5b02ddee1	Use DPC persisted data and signed_at (#1771 )	1 year ago
Jack	a1095f9526	CLDC-2490 Tidy up DSA model (#1766 ) * Remove new_data_protection_confirmation? flag * Update schema - drop index - add org and user data to dpc table * Persist org and user data at import * Do not show invalid emails * Persist user and org data while signing agreement * Add migration to persist org and user data on DPC * Rebase fix * fix typo	1 year ago
Jack	6d7ce8af16	CLDC-2319 prevent log creation (#1684 ) * Remove bulk_upload_lettings_logs flag * Add spacing above actions in data sharing agreement * Add banner * Add model validation * fix log component * Fix factory * Put validation behind feature flag * start adapting to data protection confirmation * Make tests more generic * Add tests for display_organisation_attributes * Use data_protection_confirmed? method * Address code review * rubocop * Prevent access to bulk upload pages when DPC not signed * Address PO review	2 years ago
Jack	a3b945d8e3	CLDC-2322 read and sign data sharing agreement (#1686 ) * Add data sharing agreement * Add data sharing agreement view * Add controller actions * Update details page * Rubocop fix * Fill in placeholders and persist data in table * Update agreement template	2 years ago
Phil Lee	3e0d10f176	CLDC-1732 Provider and read only schemes (#1642 ) # Context - https://digital.dclg.gov.uk/jira/browse/CLDC-1732 - data providers are given read-only able access to schemes and locations # Changes - introduce `pundit` policies to schemes and locations. the old scope mechanism has been removed - apply policies at view level so hide write access based functionality from data providers	2 years ago

13 Commits (6a954a42a4d6f05c285b14f0fb3d10bc8fda8999)