submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
natdeanlewissoftwire	fb389414a0	CLDC-2504 Add owning org select to sales if there are stock owning absorbed orgs (#1815 ) * feat: wip update sales org select * feat: update routing and hidden in check answers methods * feat: set sales org id as derived * feat: update tests * refactor: linting * feat: update tests and radio options * feat: update test * feat: add value helper test for non-constant value question * refactor: lint * feat: freeze time in unrelated test * refactor: linting	1 year ago
Jack	87a5265c05	CLDC-2168 Bugfix - handle empty file (#1795 ) * Bugfix - handle empty file * Count rows without headers * Add host to sentry tags * Add test for blank file with headers * Fix sales validator * Validate also content of rows * Use compact * Add 2023-2024 lettings empty file spec * Update sales template	1 year ago
kosiakkatrina	724a59ee04	CLDC-2391 Update content on bulk upload pages (#1777 ) * Save total logs count for bulk upload * Update content of fix choice and confirm pages * update bulk upload banner * Rebase changes * Extract fix choice summary into method * Add comma	1 year ago
natdeanlewissoftwire	825076a522	CLDC-2456 Sales collection year test fixes (#1689 ) * feat: setup to replicate failures to fix * feat: wip test fixes * feat: remainder of current state test fixes * feat: set form date to past to trigger errors to fix * feat: revert, don't want this in final diff * feat: fix row_parser tests * feat: sales log importer and validator fixes * feat: remainder of test fixes * refactor: lint	2 years ago
Phil Lee	c5842122d7	CLDC-2369 Spreadsheet dupe (#1663 ) * remove dead code * handle spreadsheet dupes in lettings * handle spreadsheet dupes in sales * update error message * use feature flag	2 years ago
kosiakkatrina	fad105302a	CLDC-2386 Validate the correct template for the year (#1665 ) * Validate that correct template for the year is used for sales (with headers) * Check the correct template is being used without headers * Check correct template for lettings * Update csv parser on sales * Remove redundant methods * Extract form years * Reverse year check mathod	2 years ago
Phil Lee	903cf81749	CLDC-2305 Bulk upload setup fields validations (#1633 ) # Context - https://digital.dclg.gov.uk/jira/browse/CLDC-2305 - This is rework to add missing validations for sales setup fields for bulk upload # Changes - There is code that clears log fields if they are not a valid option. in order to generate errors for these we check certain fields for content prior to `log.valid?` being called. Unfortunately there does not appear to be an easy way to access to valid options therefore these values have been hard coded - Privacy notice must be accepted other considered a setup error - The `type` question can actually be one of three questions with the same identifier. these are excluded as part of `validate_valid_radio_option` and instead validated with a different mechanism. The rationale being that `log.valid?` will clear data before we get there - Remove tests associated to upload threshold which are no longer required	2 years ago
Phil Lee	cf9d9550e9	CLDC-2344 Remove bulk upload minimum column check (#1621 ) # Context - https://digital.dclg.gov.uk/jira/browse/CLDC-2344 - So the reported bug and these change do not match 100% - As the reported bug should have already been resolved in an earlier change as the error message that was reported has already been removed from the system - These changes remove the check from sales plus a few minor tidy ups # Changes - Remove dead code around error threshold which is no longer used or needed - Inverted negative predicate to positive one, `incorrect_field_count` => `correct_field_count` - Remove `validate_min_columns` from sales bulk upload	2 years ago
Phil Lee	45128b7250	Refactor with split of log to CSV by log type (#1593 ) # Context - Partially related to https://digital.dclg.gov.uk/jira/browse/CLDC-2316 - Comprehending sales or lettings bulk upload CSV is enough, comprehending both simultaneously is rather challenging # Changes - Split out test helper class by log type ie lettings/sales	2 years ago
kosiakkatrina	d1f21a5890	CLDC-2031 Sales bulk upload (#1574 ) * Add sales csv parser * Create log creator and update row parser for sales * Add validations * Add status_cache to sales logs * Parse completed log * Add basic validations to the row parser * Fix details known and proplen mapping * Add setup section errors * Update sales log validator * tests * Add sales resume and summary pages * send the correct emails	2 years ago
Phil Lee	197e2ae4cb	[1778] Bulk upload errors (#1091 ) * lockdown bulk upload routes * able to view lettings bulk upload errors * add error count to bulk upload results * coverage for bulk upload filename on results * group bulk upload errors by row on results * able to view bulk upload sales results * scope lettings and sales bulk upload results * fix linting * call service correctly in test * add bulk upload sales questions mapping * appease linter * bulk upload error shows correct question - depending on log type it will show relevant question for the field concerned * use local disk for bulk upload for dev env - this saves the need to connect to S3 to play with bulk upload in dev environment * improve namespacing of classes * add job to process bulk uploads * use local disk storage for dev file upload * fix test * use inline active job queue_adapter for dev * use test active job queue adapter for test env * remove rubocop violation * delete bulk upload from disk after processing * populate errors with cell, row + metadata * update error message with something meaningful * shim in sales validator * able to parse sales bulk uploads * change migration to add purchase_code to errors * bulk upload error component renders purchaser code - when a sales log * populate purchaser_code for bulk upload errors - when log type is sales * remove superfluous private method	2 years ago

11 Commits (6b9b94399fd40e29ee6671d05f5b3cb0d4e4fe8f)