makes the current_collection_after_crossover_start_date method a bit more useful, returns the date in the current collection year that crossover will end, rather than the crossover end date of the current period (which will be next year)
* CLDC-4356: Add hyphen to builtype Purpose-built in lettings
* CLDC-4356: Add hyphen to building type Purpose-built in sales
* CLDC-4356: Update CSV export tests
* CLDC-4356: Update model tests
* CLDC-4363: Set date to 1st August
* CLDC-4363: Update lettings log csv service spec
* CLDC-4363: Update collection resources controller spec
* CLDC-4363: Update lettings log derived fields
* CLDC-4363: Update remaining model tests
* CLDC-4363: Test August 2nd
* CLDC-4363: Test July 31st
* CLDC-4363: Test back in present
* fixup! CLDC-4363: Update remaining model tests
wrong field
* CLDC-4114: Silence DPO warning if DSA is signed
also restructure redundant logic in the file
* CLDC-4114: Update tests
* fixup! CLDC-4114: Silence DPO warning if DSA is signed
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
* CLDC-4114: Restructure data protection confirmation banner tests
* fixup! CLDC-4114: Restructure data protection confirmation banner tests
* fixup! CLDC-4114: Restructure data protection confirmation banner tests
fix typo
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
* CLDC-4114: Lint after merge
since rubocop updated
---------
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
* CLDC-4333: update purchase price soft vals to take stairbought into account
* CLDC-4333: set hard min to 0 for staircasing
* CLDC-4333: add dynamic hard min based on stairbought
* CLDC-4333: step value input width up to next option
* CLDC-4333: update value spec
* CLDC-4333: update hint text instead to ensure value is 100% of equity
* CLDC-4333: update hint text instead to ensure value is 100% of equity
* CLDC-4333: revert q text change to align with spec
* CLDC-4333: revert spec changes
* CLDC-4333: revert 2025 changes
* CLDC-4333: clarify 2026 question
* CLDC-4333: revert question fix
* CLDC-4333: revert initial purchase hint text update
* CLDC-4340: Account for nil location name on location select
use postcode as a fallback, which should never be nil
* CLDC-4340: Add a verifying test
* CLDC-4340: Put all postcode locations at the end
* CLDC-4340: Sort locations by postcode
* Revert "CLDC-4235, CLDC-4280: staging go-live testing prep (#3262)"
This reverts commit 21367a7e3e.
* CLDC-4280: continue to block future form use on staging
* CLDC-4235: set allow_future_form_use false in staging
* CLDC-4280: add time travel behaviour for staging (and check on test first)
* CLDC-4280: actually check on review
* CLDC-4280: time travel on staging now review works
* CLDC-4280: temp add review to diff again
* CLDC-4280: send notify emails in real time in all environments to avoid auth/time skew errors
* CLDC-4280: also apply with_timecop to s3
* CLDC-4280: undo changes to review
* CLDC-4325: Set date to 2026
* CLDC-4325: Fix sale information % tests
I'm not sure why I turned off strict post 2026, it's wanted in the same scenarios as before as shown by the failing tests
* CLDC-4325: Fix check answers spec
* CLDC-4325: Fix old rake task tests
* CLDC-4325: Fix sales soft validations
* CLDC-4325: Fix collection resources controller spec
* CLDC-4325: Only add noms and org to CSV row if prp
in most cases this was done by default but some tests construct an invalid log
* CLDC-4325: Fix lettings household validations spec
* CLDC-4221: Add 2026 collection deadlines
* CLDC-4325: Fix remaining model specs
* CLDC-4325: Fix form controller spec
* CLDC-4325: Fix hhmemb spec
* CLDC-4325: Fix duplicate logs controller spec
also introduce a new helper for a dynamic way of setting year
* CLDC-4325: Fix sales BU validator spec
* CLDC-4325: Fix check answers summary component
* CLDC-4325: Remove 2024 rake
* CLDC-4325: Use or later in all touched tests
* CLDC-4325: Fix guidance helper spec
* CLDC-4325: Run all tests now and in 2026
* CLDC-4325: Turn off 2026 override
* CLDC-4325: Add a corresponding return to timecop missing one
* CLDC-4325: Fix sales log spec in 2025
need to use let rather than let! so the timecop can run first
* CLDC-4325: Fix lettings log derived spec in 2025
timecop required for the start dates to work
* CLDC-4325: Turn the 2026 override on again
* fixup! CLDC-4325: Fix check answers summary component
* CLDC-4325: Delete recalculate_reasonpref_dontknow rake
only needed for 2024 logs
* fixup! CLDC-4325: Fix lettings household validations spec
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
* fixup! CLDC-4325: Fix sales log spec in 2025
* fixup! CLDC-4325: Fix sales log spec in 2025
* CLDC-4325: Make start controller spec not year specific
* CLDC-4325: Run tests in current day
* CLDC-4325: Run tests on 31st march
* CLDC-4325: Run tests on 2nd april
* CLDC-4325: Properly run tests on current day
* fixup! CLDC-4325: Fix sales soft validations
* fixup! CLDC-4325: Make start controller spec not year specific
* CLDC-4325: Run tests on 31st march
* CLDC-4325: Run tests on 1st april
* CLDC-4325: Run tests on 2nd april
* CLDC-4325: Revert time travel
---------
Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>
* CLDC-4270: Add an error for fields with the wrong type for 2026 lettings
* CLDC-4270: Add tests
* CLDC-4270: Port changes to other years' parsers
sales 2025 2026
lettings 2026
* fixup! CLDC-4270: Add an error for fields with the wrong type for 2026 lettings
* fixup! CLDC-4270: Port changes to other years' parsers
* CLDC-4270: Fix tests post merge
* fixup! CLDC-4270: Add tests
* CLDC-4270: Add ? to boolean method
* CLDC-4263: align new service charge questions with bu spec
* CLDC-4263: fix "no" mapping and allow decimal mscharge
* CLDC-4263: update tests
* CLDC-4297: clarify test naming
* CLDC-4297: add tests for inferences and confirm R inference
* CLDC-4297: add test override
* CLDC-4297: remove R tests
* CLDC-4297: add R behaviour back in
* CLDC-4297: updated error handling
* CLDC-4297: add warning comment on block_log_creation!
* CLDC-4297: test updates
* CLDC-4297: comment update
* CLDC-4297: allow 0 for newservicecharges
* CLDC-4297: test improvements
* CLDC-4297: test negatives and unify order
* CLDC-4297: misc cleanup
* CLDC-4297: specify same value errors
* CLDC-4297: don't allow 0 for mscharge and update tests
* CLDC-4297: update case insensitive field tests
* CLDC-4297: don't allow 0.0
* CLDC-4297: test 0.0 and r explicitly
* CLDC-4297: refactor and simplify
* CLDC-4297: final validation test tweaks
---------
Co-authored-by: samyou-softwire <samuel.young@softwire.com>
* CLDC-4270: Add an error for fields with the wrong type for 2026 lettings
* CLDC-4270: Add tests
* CLDC-4270: Port changes to other years' parsers
sales 2025 2026
lettings 2026
* fixup! CLDC-4270: Add an error for fields with the wrong type for 2026 lettings
* fixup! CLDC-4270: Port changes to other years' parsers
* CLDC-4270: Fix tests post merge
* fixup! CLDC-4270: Add tests
* CLDC-4270: Add ? to boolean method
samyou-softwire
Nat Dean-Lewis
Frank Ma