Manny Dinssa
839846325d
Update tests to use translation
8 months ago
Manny Dinssa
1bc04b6e2c
Update about price value test
8 months ago
Manny Dinssa
edf86dbf1c
Update uprn confirmation test
8 months ago
Manny Dinssa
45cf14533e
Revert "Remove tests"
...
This reverts commit 8c9bd26f4d
.
8 months ago
Manny Dinssa
bfb5249a0a
Update tests
8 months ago
Manny Dinssa
9c304043f3
Update tests
8 months ago
Manny Dinssa
33e63a60cd
Update tests
8 months ago
Manny Dinssa
cbd4409c19
Update test
8 months ago
kosiakkatrina
ace6a599b0
CLDC-3664 Extract income and benefits copy ( #2709 )
...
* Refactor sales household pages and questions
* Refactor sales income and benefits soft validations
* Update subsection test
* Fix income copy keys
* Update subsection test
* Add missing question to translations
* Fix typo
* Add prevshared for 2024
8 months ago
Manny Dinssa
755b4b9228
Extract title text and informative text for soft validations
8 months ago
Manny Dinssa
8c9bd26f4d
Remove tests
8 months ago
Manny Dinssa
2d780a845b
Revert spec back to original
8 months ago
Manny Dinssa
be1a59e6d9
Fix lint
8 months ago
Manny Dinssa
66b8f2c508
Remove 2022-only property questions and pages
8 months ago
Manny Dinssa
50fe1958a5
Remove comment
8 months ago
Manny Dinssa
f5a2d95b07
Add subsection method to page instance
8 months ago
Rachael Booth
731dcc9325
CLDC-3650: Move copy for sales setup section to translation files ( #2672 )
8 months ago
Manny Dinssa
e43c86e236
Fix lint
8 months ago
Manny Dinssa
331b308818
Remove 2022-only property questions and pages
8 months ago
Manny Dinssa
d7a2e19215
Remove comment
8 months ago
Manny Dinssa
3840baafea
Add subsection method to page instance
8 months ago
Manny Dinssa
b1ad8a1520
CLDC-3633++ Full stops in error messages & capitalisation within messages ( #2674 )
8 months ago
Rachael Booth
2dd204d0be
Fix tests
8 months ago
Rachael Booth
0cb0add7a7
Fix lint
8 months ago
Rachael Booth
9a4f2bc52d
Add tests where there is logic on page/question to decide copy key
8 months ago
Rachael Booth
10e96cc165
Add tests for copy key and copy to page and question specs
8 months ago
Rachael Booth
9f9d755131
Remove text tests from pages and questions
8 months ago
Rachael Booth
dc2c7d5d8d
...and again
9 months ago
Rachael Booth
b48f5ab422
And again...
9 months ago
Rachael Booth
594fb9c2e8
More test fixes
9 months ago
Rachael Booth
4901547d03
Tidy
9 months ago
Rachael Booth
f892f75631
More fixes
9 months ago
Rachael Booth
bd69ec56d4
More fixes
9 months ago
Rachael Booth
961f1b7f93
CLDC-3423: Add sales soft validation for person over retirement age not retired ( #2644 )
...
* CLDC-3423: Add sales soft validation for person over retirement age not retired
* Add rake task to recalculate log status when new validation is triggered
9 months ago
Manny Dinssa
53c3b3e61a
CLDC-3633 Full stops in error messages ( #2628 )
...
* Make full stops consistent in error messages
* Fix test
* Update few hardcoded errors
* Update join in remaining row parsers
* Update some more tests
* Update more hard coded BU errors
* Fix typo I introduced - bedrooms to bedroom
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>
9 months ago
kosiakkatrina
8516aa1f23
Don't hide person known question in CYA ( #2641 )
9 months ago
kosiakkatrina
d5f2424247
CLDC-3576 Update soft pregnancy validation ( #2640 )
...
* Update soft pregnancy validation
* Fix tests
9 months ago
kosiakkatrina
459420d7ee
CLDC-3541 Update sales financial validations ( #2546 )
...
* CLDC-3569 Update social homebuy errors (#2541 )
* Split questions
* Update the error message
* Add guidance
* Add back the headers
* Refactor depends_on
* Refactor further
* CLDC-3569 Update missed errors (#2548 )
* Update some skipped error messages
* Remove repeating deposit question
* CLDC-3571 Discounted ownership validation (#2547 )
* Rename discount to deposit discount
* Split about price rtb questions
* Update error message
* Update guidance partial
* Fix top_guidance_partial method
* Split about_price_not_rtb
* Update guidance partial and validation
* Fix bulk upload test
* Update deposit routed_to and guidance
* Refactor guidance links into a helper (#2551 )
* Refactor guidance links into a helper
* Refactor discounted ownership guidance
* CLDC-3570 Validations all other shared ownership types (#2550 )
* Update "all other shared ownership" errors
* CLDC-3571 Update outright sale financial validations (#2549 )
* Update outright sale validation message
* Add outright sale guidance
* Update duplicate page id
* User guidance helper
* Fix up financial equations content (#2552 )
* Tweak shared ownership validation wording
* Add top_guidance_partial to missed shared ownership questions
* Update discounted ownership validation message when there's no grant
* Update discounted sale guidance and errors
* Lint and update test
* Update BU test
* Update test
* CLDC-3569 Update guidance for shared ownership without mortgage (#2562 )
* Update how we display errors for BU
* Update guidance for shared ownership
* Add header to mortgage used question
* Update shared ownership guidance
* Update spacing (#2569 )
* Fix spacing again (#2570 )
* Update discounted ownership guidance (#2582 )
* Update discounted ownership guidance
* Add top guidance partial to outright sale
* Update outright sale guidance content
* Update model test
---------
Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
10 months ago
Manny Dinssa
1da04df30f
CLDC-3411 correct 24 25 bulk upload error messages on lettings and sales ( #2556 )
...
* Update error messages and sales parser
11 months ago
Manny Dinssa
c3b85f2b50
CLDC-3411: Correct 24/25 bulk upload error messages on lettings and sales ( #2553 )
11 months ago
Manny Dinssa
8af9c255e3
CLDC-3567-Remove-DLUHC-references-from-CORE-pages ( #2530 )
11 months ago
Manny Dinssa
fb89b47b6f
CLDC-3520 order scheme locations ( #2499 )
...
* List in alphabetical order using second line of address (.i.e. hint/name)
11 months ago
kosiakkatrina
8ce22d37c0
CLDC-3289 Avoid freezing time (part 3) ( #2445 )
...
* Refactor tests #1
* Update tasklist helper tests
* Update task list helper
* Fix test
* Rabase fixes
* Update model/validations tests
* Update som sales log specs
* Remove missing addresses csv tasks
* Update some tests for 2023 collection close
* More fixes
* Revert sales shared examples change
* Fix test
* Update test nemes, remove time stub
11 months ago
Arthur Campbell
3adfb29143
CLDC-3290 Update some test setup ( #2466 )
...
* test prof in test context
* time reduced from ~1.4 to 0.27
* time reduced from ~1.1 to 0.7
* time reduced from ~0.13 to 0.07
* add testprof env variables to spec helper
* reorder gems for linting copmlaint
* Remove test-prof gem
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
11 months ago
Arthur Campbell
f423ec1cd5
CLDC-3505 further fixes to tests for year hard end ( #2493 )
...
* further fixes
* Fix date / crossover issues
* Try changing form end dates
* Revert "Try changing form end dates"
This reverts commit e027e29cf0
.
* Make use of :ignore-validation-errors trait
* Try with end dates in past
* Revert "Try with end dates in past"
This reverts commit 6b87938d70
.
---------
Co-authored-by: Rachael Booth <rachael.booth@softwire.com>
11 months ago
kosiakkatrina
42f89680e5
CLDC-3495 Reduce persisted models in tests ( #2507 )
...
* Remove legacy user from user factory
* Build instead of creating in some model tests
* Do not create a new DPO for orgs created within user factories
* Add original setup doc
* Update documentation with updated factories
* Fix up DSA creations
11 months ago
kosiakkatrina
ab4915c2aa
CLDC-2480 Allow deleting organisations ( #2459 )
...
* Add delete confirmation page
* Allow deleting organisation
* Add delete button
* Do not display deleted organisations as an option
* Update policy
* Display informative text and delete org resources
* lint
* Update organisation labels to show when deleted
* Refactor organisation label
* Update more labels
* Remove deleted orgs from schemes and autorize delete_confirmation
* Fix tests
11 months ago
kosiakkatrina
5947a2027a
CLDC-3496 Move period creation to log ( #2490 )
...
* Move period creation to log
* Allow adding rent periods to organisations
* Update more tests
12 months ago
kosiakkatrina
30b86f5a86
CLDC-3289 Avoid freezing time in tests (part 2) ( #2432 )
...
* Refactor tests #1
* Refactor model form tests
* Update tasklist helper tests
* Update task list helper
* Fix test
* Udate model/forms tests
* Update model/validations tests
* Update a few more model specs
* Update bulk request tests
* Update policy tests
* lint
* Refactor
* More fixes
* Rabase fixes
* Refactor
* lint
12 months ago
Arthur Campbell
8f65fd35fd
Cldc 3505 fix tests that will break on rollover ( #2485 )
...
* update factory completed traits using an after build hook so that trait does what it says regardless of start or sale date of log
* use completed trait rather than completed2024 trait from factories
skip validation on saving logs from previous years so that logs created too far in the past do not trigger validations
* remove sale and start dates from logs in tests where that should not be important
build rather than create to reduce db interactions
in order that the setup is complete, build the necessary user and organisation with ids
* fix a wide range of tests affected by the changes in log factories completed traits
12 months ago