Rachael Booth
e66d5ea1d0
CLDC-3566: Clear duplicate set ids when a log ceases to be a duplicate through normal update flow ( #2534 )
...
* CLDC-3566: Clear duplicate set ids when a log ceases to be a duplicate in normal updates
* Refactor
* Ensure post not run twice in form controller tests
* Remove deduplication flow feature toggle
* Ensure class_name is defined in redirect path function
* Add tests for sales logs
5 months ago
Rachael Booth
6a42978fab
CLDC-3546: Add error to managing org when it does not have relevant rent period ( #2538 )
...
* CLDC-3546: Add error to managing org when it does not have relevant rent period
* Add test for :skip_bu_error
* Fix managing org question id
5 months ago
kosiakkatrina
72cbc7d6fd
Update rexml to 3.3.3 ( #2544 )
5 months ago
Manny Dinssa
ae190b268d
CLDC-3357-Previously-applied-filters-not-clearing ( #2528 )
5 months ago
kosiakkatrina
45d73955c9
CLDC-759 Add accessibility testing ( #2529 )
...
* Add accessibility tests
* Add accessibiliy tests to CI
* Lint and refactor
* Adjust and update paths
* Add some more page tests
5 months ago
Rachael Booth
427099c724
CLDC-3568: Update collection resources for MHCLG name change ( #2536 )
5 months ago
kosiakkatrina
ba2cf8b4a9
Update location scopes ( #2537 )
5 months ago
Manny Dinssa
9b0cbac406
CLDC 2954 handle schemes with only deactivated locations ( #2510 )
5 months ago
Rachael Booth
975f072d2f
CLDC-3547: Validate against incomplete schemes being used in logs ( #2498 )
...
* CLDC-3547: Validate against incomplete schemes being used in logs
* Fix ordering issue in tests
5 months ago
kosiakkatrina
bb270d34c0
Remove noint_fix_status from the database ( #2508 )
5 months ago
kosiakkatrina
0f4bc32d6e
CLDC-3465 Update hard validations flow ( #2472 )
...
* Add check your errors page with clear links
* Update answer links
* Link to check your errors page
* Refactor check errors page
* Allow clearing answers
* Update styling and lint
* Add routing for sales
* lint
* Update page routing test
* Remove unused code
* CLDC-3465 Handle additional errors (#2480 )
* Keep check errors query params
* Add success banner
* Update confirm and continue button
* CLDC-3465 Allow clearing all error questions (#2483 )
* Allow clearing all error questions
* Update setup question link
* Update clear all to ignore setup questions
* Update correct_validation_action_href
* Extract some vriables
* CLDC-3465 Do not display non persisted values in check errors page (#2484 )
* Do not display non persisted values on check_errors page
* Remove govuk button styling from link
* Update warning message
* Update copy
5 months ago
kosiakkatrina
201ce23906
CLDC-1718 Update numeric questions to text fields ( #2527 )
...
* Update numeric questions to text fields
* Add test case
5 months ago
Manny Dinssa
8af9c255e3
CLDC-3567-Remove-DLUHC-references-from-CORE-pages ( #2530 )
5 months ago
kosiakkatrina
523f931770
Set the bulk upload value for correct log type ( #2533 )
5 months ago
kosiakkatrina
b9f900c98e
CLDC-3550 Fix rent_type 2024 BU mapping ( #2501 )
...
* Fix rent_type 2024 BU mapping
* Correct rent_type values
* Reuse rent_type mapping
* Track updated bulk uploads
* Fix test
5 months ago
kosiakkatrina
a4a83908ae
Refactor locations/index page ( #2523 )
5 months ago
kosiakkatrina
93cf84edca
CLDC-3027 Remove unused admin user code ( #2524 )
...
* Remove leftover admin user code
* Fix flaky tests
5 months ago
dependabot[bot]
1da419f1f3
Bump rexml from 3.2.8 to 3.3.2 in /docs ( #2525 )
...
Bumps [rexml](https://github.com/ruby/rexml ) from 3.2.8 to 3.3.2.
- [Release notes](https://github.com/ruby/rexml/releases )
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md )
- [Commits](https://github.com/ruby/rexml/compare/v3.2.8...v3.3.2 )
---
updated-dependencies:
- dependency-name: rexml
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
5 months ago
kosiakkatrina
9d08cf9c85
Update rails-admin ( #2521 )
5 months ago
Manny Dinssa
fb89b47b6f
CLDC-3520 order scheme locations ( #2499 )
...
* List in alphabetical order using second line of address (.i.e. hint/name)
5 months ago
kosiakkatrina
a92c401a4d
Make sure archived filters are removed after crossover ( #2522 )
...
* Make sure archived filters are removed after crossover
* Fix feature tests
5 months ago
kosiakkatrina
6c03a6d203
CLDC-3562 Add scheme ID to the hint text ( #2519 )
...
* Add scheme ID to the hint text
* Fix flaky tests
5 months ago
Manny Dinssa
6273a076cb
CLDC-3414&5 Close 2023/24 - No new/No editing of entries ( #2520 )
...
* Close 2023/24
5 months ago
kosiakkatrina
a08f6a6ca8
Allow discarding users for merged orgs ( #2518 )
5 months ago
Rachael Booth
636e40fc9d
CLDC-3505: Fix tests for hard year end part 4 ( #2509 )
...
* Add in past end dates for testing
* Temporarily disable test marked to delete at year end
* Remove one off reinfer_local_authority task
* Update validator_spec
* Set 2024 date in form_handler_spec to be during crossover period as needed
* Use bulk_upload.year_combo for comparison in request tests to avoid year dependancy
* Update BU log creator specs for 2024
* Use year combo function in bulk upload mailer tests
* Refactor lettings validator_spec
* More fixes
* More work on bu validator specs - mostly sales
* Remove pre 2023 test
* More use of bulk_upload.year_combo in request tests
* Fix lint
* Tweak bulk upload error row component tests for year changes
* Further fixes
* Fix 2023 lettings row parser spec
* Sales log to csv fix
* Refactor BU processor tests
* Fix field number row identifier
* Fix linting
* More years in request spec
* fix
* Don't use db unnecessarily in financial validations spec
* Fix sale date changing 2024 -> 2023 test
* Add tests for bulk_upload.year_combo
* Update bu factory year specification
* Refactoring
* Linting
* Don't use helper in factory
* Remove new 2023 specific test
* Remove dummy end dates
5 months ago
kosiakkatrina
f9cb42fbad
CLDC-2831 Remove mini-profiler from staging ( #2517 )
...
* Revert "Add mini profiler (#2513 )"
This reverts commit c19291c948
.
* Revert "CLDC-2831 Update profiler storage (#2514 )"
This reverts commit 2203577fee
.
5 months ago
Rachael Booth
d2964d73db
CLDC-3549: Ensure location page routing is updated when log is changed ( #2502 )
5 months ago
kosiakkatrina
e639c5c861
CLDC-3558 Display correct orgs data protection confirmation ( #2511 )
...
* Display correct orgs data protection confirmation
* Remove binding
5 months ago
kosiakkatrina
2203577fee
CLDC-2831 Update profiler storage ( #2514 )
...
* Update profiler storage
* lint
6 months ago
kosiakkatrina
9688a04ac7
Update rexml ( #2515 )
6 months ago
kosiakkatrina
c19291c948
Add mini profiler ( #2513 )
6 months ago
kosiakkatrina
8ce22d37c0
CLDC-3289 Avoid freezing time (part 3) ( #2445 )
...
* Refactor tests #1
* Update tasklist helper tests
* Update task list helper
* Fix test
* Rabase fixes
* Update model/validations tests
* Update som sales log specs
* Remove missing addresses csv tasks
* Update some tests for 2023 collection close
* More fixes
* Revert sales shared examples change
* Fix test
* Update test nemes, remove time stub
6 months ago
Arthur Campbell
3adfb29143
CLDC-3290 Update some test setup ( #2466 )
...
* test prof in test context
* time reduced from ~1.4 to 0.27
* time reduced from ~1.1 to 0.7
* time reduced from ~0.13 to 0.07
* add testprof env variables to spec helper
* reorder gems for linting copmlaint
* Remove test-prof gem
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
6 months ago
Manny Dinssa
9e35b26dcf
Just use visible locations ( #2506 )
6 months ago
kosiakkatrina
fe82a8e8b4
Split tests into more jobs ( #2505 )
...
* Split tests into more jobs
* Make request tests run in parallel
6 months ago
Arthur Campbell
f423ec1cd5
CLDC-3505 further fixes to tests for year hard end ( #2493 )
...
* further fixes
* Fix date / crossover issues
* Try changing form end dates
* Revert "Try changing form end dates"
This reverts commit e027e29cf0
.
* Make use of :ignore-validation-errors trait
* Try with end dates in past
* Revert "Try with end dates in past"
This reverts commit 6b87938d70
.
---------
Co-authored-by: Rachael Booth <rachael.booth@softwire.com>
6 months ago
kosiakkatrina
42f89680e5
CLDC-3495 Reduce persisted models in tests ( #2507 )
...
* Remove legacy user from user factory
* Build instead of creating in some model tests
* Do not create a new DPO for orgs created within user factories
* Add original setup doc
* Update documentation with updated factories
* Fix up DSA creations
6 months ago
kosiakkatrina
ab4915c2aa
CLDC-2480 Allow deleting organisations ( #2459 )
...
* Add delete confirmation page
* Allow deleting organisation
* Add delete button
* Do not display deleted organisations as an option
* Update policy
* Display informative text and delete org resources
* lint
* Update organisation labels to show when deleted
* Refactor organisation label
* Update more labels
* Remove deleted orgs from schemes and autorize delete_confirmation
* Fix tests
6 months ago
kosiakkatrina
8dcd80e4f8
Strip scheme ID ( #2487 )
6 months ago
Rachael Booth
356d652db1
CLDC-3532: Make BU guidance back link depend on referrer ( #2482 )
...
* CLDC-3532: Make BU guidance back link depend on referrer
* Add tests for back_path
* Add guidance to homepage
* CLDC-3526: Update back_path
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
6 months ago
Rachael Booth
032cecf3f8
CLDC-3482: Task to recalculate status for 2023 logs missing la ( #2495 )
6 months ago
Rachael Booth
8d9f30610c
CLDC-3543: Don't validate logs when discarding them in handle unpended logs task ( #2504 )
6 months ago
Rachael Booth
b553ec031a
CLDC-3543: Fix args reference in allow live run of handle unpended logs task ( #2503 )
6 months ago
Rachael Booth
ababb3894c
CLDC-3543: Allow live run of handle unpended logs task ( #2496 )
6 months ago
dependabot[bot]
f6a0cc67e5
Bump rails_admin from 3.1.2 to 3.1.3 ( #2500 )
...
Bumps [rails_admin](https://github.com/sferik/rails_admin ) from 3.1.2 to 3.1.3.
- [Changelog](https://github.com/railsadminteam/rails_admin/blob/v3.1.3/CHANGELOG.md )
- [Commits](https://github.com/sferik/rails_admin/compare/v3.1.2...v3.1.3 )
---
updated-dependencies:
- dependency-name: rails_admin
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
6 months ago
kosiakkatrina
905f869460
CLDC-2939 Link to organisations from user pages ( #2489 )
...
* Link to organisations from user pages
* Fix test
6 months ago
Rachael Booth
0994794b25
CLDC-3543: Task to handle unpended logs - dry runs only ( #2494 )
...
* CLDC-3543: Task to handle unpended logs
* Enforce dry run only
6 months ago
Arthur Campbell
0ecd82bf8f
more tests fixed ( #2491 )
6 months ago
kosiakkatrina
5947a2027a
CLDC-3496 Move period creation to log ( #2490 )
...
* Move period creation to log
* Allow adding rent periods to organisations
* Update more tests
6 months ago
Rachael Booth
22522fb907
CLDC-3265: Duplicate whitespace row fix to sales BU ( #2481 )
...
* CLDC-3265: Duplicate whitespace row fix to sales BU
* CLDC-3265: Fix bu test that accidentally had whitespace only row
6 months ago