Rachael Booth
3424cbc550
CLDC-3366: Use single page for rent soft validation ( #2724 )
...
* CLDC-3366: Use single page for rent soft validation
* Fix tests
2 months ago
kosiakkatrina
ff3f789acc
CLDC-3681 Extract lettings household characteristics copy ( #2728 )
...
* Extract lettings household characteristics copy
* Update cya labels for age known
* Update missing keys and copy
2 months ago
kosiakkatrina
83877dae69
Extract lettings household needs copy ( #2729 )
2 months ago
Manny Dinssa
247b7f212f
CLDC-3679: Copy changes lettings setup questions ( #2723 )
2 months ago
kosiakkatrina
1ffc440342
CLDC-3656 Extract household characteristics question and page copy to translation files ( #2702 )
...
* Extract question and page copy to translation files
* Refactor 2 question pages
* Readd removed answer options
* Fix missing/wrong age mappings
* Update some pages/questions
* Update tests
* CLDC-3656 Extract household characteristics soft validations (#2707 )
* Extract retirement confirmation questions
* Extract old persons shared ownership confirmation questions
* Extract income confirmation questions
* Extract buyer live-in value check page and question copy to translation files
* Extract student not a child confirmation questions and page copy to translation files
* Extract partner under 16 value check page and question copy to translation files
* Extract partner under 16 value check page and question copy to translation files
* Update some missing/wrong keys
* Update some keys on 2023
* Update BU tests
2 months ago
kosiakkatrina
0799ff7a36
CLDC-3658 Extract household needs copy ( #2718 )
...
* Extract household needs subsection copy
* Extract housing needs soft validations copy
* Add new lines at the end of some files
2 months ago
kosiakkatrina
9bd3389c84
CLDC-3655 Extract property information validations ( #2700 )
...
* Extract property information validations
* Refactor possesive variable from errors
2 months ago
kosiakkatrina
ace6a599b0
CLDC-3664 Extract income and benefits copy ( #2709 )
...
* Refactor sales household pages and questions
* Refactor sales income and benefits soft validations
* Update subsection test
* Fix income copy keys
* Update subsection test
* Add missing question to translations
* Fix typo
* Add prevshared for 2024
2 months ago
Rachael Booth
731dcc9325
CLDC-3650: Move copy for sales setup section to translation files ( #2672 )
2 months ago
Manny Dinssa
b1ad8a1520
CLDC-3633++ Full stops in error messages & capitalisation within messages ( #2674 )
3 months ago
Rachael Booth
961f1b7f93
CLDC-3423: Add sales soft validation for person over retirement age not retired ( #2644 )
...
* CLDC-3423: Add sales soft validation for person over retirement age not retired
* Add rake task to recalculate log status when new validation is triggered
3 months ago
kosiakkatrina
8516aa1f23
Don't hide person known question in CYA ( #2641 )
3 months ago
kosiakkatrina
d5f2424247
CLDC-3576 Update soft pregnancy validation ( #2640 )
...
* Update soft pregnancy validation
* Fix tests
3 months ago
kosiakkatrina
459420d7ee
CLDC-3541 Update sales financial validations ( #2546 )
...
* CLDC-3569 Update social homebuy errors (#2541 )
* Split questions
* Update the error message
* Add guidance
* Add back the headers
* Refactor depends_on
* Refactor further
* CLDC-3569 Update missed errors (#2548 )
* Update some skipped error messages
* Remove repeating deposit question
* CLDC-3571 Discounted ownership validation (#2547 )
* Rename discount to deposit discount
* Split about price rtb questions
* Update error message
* Update guidance partial
* Fix top_guidance_partial method
* Split about_price_not_rtb
* Update guidance partial and validation
* Fix bulk upload test
* Update deposit routed_to and guidance
* Refactor guidance links into a helper (#2551 )
* Refactor guidance links into a helper
* Refactor discounted ownership guidance
* CLDC-3570 Validations all other shared ownership types (#2550 )
* Update "all other shared ownership" errors
* CLDC-3571 Update outright sale financial validations (#2549 )
* Update outright sale validation message
* Add outright sale guidance
* Update duplicate page id
* User guidance helper
* Fix up financial equations content (#2552 )
* Tweak shared ownership validation wording
* Add top_guidance_partial to missed shared ownership questions
* Update discounted ownership validation message when there's no grant
* Update discounted sale guidance and errors
* Lint and update test
* Update BU test
* Update test
* CLDC-3569 Update guidance for shared ownership without mortgage (#2562 )
* Update how we display errors for BU
* Update guidance for shared ownership
* Add header to mortgage used question
* Update shared ownership guidance
* Update spacing (#2569 )
* Fix spacing again (#2570 )
* Update discounted ownership guidance (#2582 )
* Update discounted ownership guidance
* Add top guidance partial to outright sale
* Update outright sale guidance content
* Update model test
---------
Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
4 months ago
Rachael Booth
85bbbe6108
CLDC-3556: Ignore address data in bulk upload for supported housing logs ( #2540 )
...
* Only set address data in BU for general needs logs
* Don't route to uprn selection page for supported housing logs
* Fix tests
5 months ago
Manny Dinssa
c3b85f2b50
CLDC-3411: Correct 24/25 bulk upload error messages on lettings and sales ( #2553 )
5 months ago
kosiakkatrina
0f4bc32d6e
CLDC-3465 Update hard validations flow ( #2472 )
...
* Add check your errors page with clear links
* Update answer links
* Link to check your errors page
* Refactor check errors page
* Allow clearing answers
* Update styling and lint
* Add routing for sales
* lint
* Update page routing test
* Remove unused code
* CLDC-3465 Handle additional errors (#2480 )
* Keep check errors query params
* Add success banner
* Update confirm and continue button
* CLDC-3465 Allow clearing all error questions (#2483 )
* Allow clearing all error questions
* Update setup question link
* Update clear all to ignore setup questions
* Update correct_validation_action_href
* Extract some vriables
* CLDC-3465 Do not display non persisted values in check errors page (#2484 )
* Do not display non persisted values on check_errors page
* Remove govuk button styling from link
* Update warning message
* Update copy
5 months ago
Manny Dinssa
8af9c255e3
CLDC-3567-Remove-DLUHC-references-from-CORE-pages ( #2530 )
5 months ago
Manny Dinssa
fb89b47b6f
CLDC-3520 order scheme locations ( #2499 )
...
* List in alphabetical order using second line of address (.i.e. hint/name)
5 months ago
kosiakkatrina
ab4915c2aa
CLDC-2480 Allow deleting organisations ( #2459 )
...
* Add delete confirmation page
* Allow deleting organisation
* Add delete button
* Do not display deleted organisations as an option
* Update policy
* Display informative text and delete org resources
* lint
* Update organisation labels to show when deleted
* Refactor organisation label
* Update more labels
* Remove deleted orgs from schemes and autorize delete_confirmation
* Fix tests
6 months ago
kosiakkatrina
07750ef26c
CLDC-3289 Avoid freezing time in tests (part 1) ( #2421 )
...
* Refactor tests #1
* Refactor helper tests
* Refactor model form tests
* Remove Timecop.returns
* Update tasklist helper tests
* Update task list helper
* Fix test
* Fix flaky search test
* Refactor
6 months ago
Arthur Campbell
5696e4b81e
Cldc 3452 remove dont know option from mortgage used when invalid ( #2470 )
...
* initial spec file refactor
remove create for build, extract form to own variable, remove non-valuable tests
run time from 0.29s to0.11s
* refactor to ensure that the questions ownershipsch instance variable and the value of ownershipsch on the log is the same in tests
* delete page test file which is not testing anything meaningful
* add error messages to the I18n yml
* update tests for the validations
* update validation logic
* update tests for the mortgage used question
* update the mortgage used question displayed answer options
* update bulk upload specs to reflect error message updates
* make use of brackets consistent within validation method
6 months ago
Arthur Campbell
d95e08cca2
Cldc 3492 oustide rent range soft validation not clearing for bedsit ( #2473 )
...
* mark the beds question as derived when the log is a bedsit to stop it from being cleared
* delete spec file not testing anything worthwhile
6 months ago
kosiakkatrina
a85fed42b1
CLDC-3504 Update period question options and error message ( #2463 )
...
* Update displayed_answer_options for period
* Update invalid rent period error message
6 months ago
Rachael Booth
34faa74a6c
CLDC-3447: Allow decimal discount percentage and increased validation tolerance ( #2427 )
...
* CLDC-3447: Allow decimal discount percentage and increased validation tolerance
* Update tests to use decimal discount
* Disable extra borrowing soft validation for 2024 onwards
* CLDC-3447: Make tolerance inclusive
* Fix linting error
* Fix method call
* Only change strictness when discount is present
* Remove blank line
7 months ago
kosiakkatrina
7d871edf74
CLDC-3482 Correct routing to property LA ( #2449 )
...
* Correct routing to property LA
* Add rake task to update LAs
7 months ago
Rachael Booth
730b07ab25
CLDC-3426: Ensure outright sale section can be completed with mortgage used unknown ( #2399 )
...
* CLDC-3426: Ensure outright sale section can be completed with mortgage used unknown
* CLDC-3426: fix test
* CLDC-3426: Refactor tests
* Avoid unnecessarily creating users in sales log factory
* Fix test that inexplicably relies on creation
8 months ago
kosiakkatrina
7e638657fb
CLDC-3354 Show user input on address selection page ( #2374 )
...
* Display input playback on the page
* Add input playback to uprn selection pages
8 months ago
kosiakkatrina
30bb983e78
CLDC-3412 set derived? on mortgage amount ( #2396 )
...
* Set derived on mortgage amount
* Refactor
8 months ago
kosiakkatrina
ad488bb5ce
CLDC-3345 Add assigned_to to the exports ( #2391 )
...
* Empty
* CLDC-3345 Rename created_by to assigned_to (#2372 )
* Rename created_by to assigned_to
* Replace created_by with assigned_to
* Update created_by to assigned_to in exports, remove blank assigned to
* CLDC-3345 Add and set created_by fields (#2373 )
* Add created_by
* Update existing created_by values
* Set created_by on single log
* Set created_by on BU
* Add created_by to exports
* feat: update since last merge
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
* Fix papertrail create version
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
8 months ago
Arthur Campbell
44a0b1acb8
CLDC-3405-update-retirement-age-validation ( #2384 )
...
* update retirement soft validation pages and copy in en.yml to reflect changes in english retirement age
* update soft validation tests to display interruption screens under the correct conditions given changes to state retirement age
reduction of variation in retirement age means lots of code related to determining the retirement age given an individuals gender can also be removed
testing updated
8 months ago
natdeanlewissoftwire
1f1df3e77f
feat: add new period option ( #2375 )
9 months ago
kosiakkatrina
eea2aead2c
CLDC-3397 Remove hint text from lead tenant questions ( #2378 )
...
* Remove hint text from lead tenant questions
* Update working situation answer options
9 months ago
kosiakkatrina
b83be837ee
CLDC-3377 Remove hint text from buyer 1 questions ( #2376 )
...
* Remove hint text from buyer 1 questions
* Update working situation answer options
* Update missed hint text
* Update csv tests
9 months ago
Robert Sullivan
c309a4760b
CLDC-3384 referral tests and inconsistencies ( #2370 )
...
* CLDC-3156: Update 2024 referral options
* CLDC-3156: Add tests for referral question
* CLDC-3156: Update other referral questions
* CLDC-3384: Referral question inconsistencies and tests
* feat: remove option 4 from 24/25 referral
* feat: update tests
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
9 months ago
natdeanlewissoftwire
a0215d45ef
CLDC-3089 Make absolute skip/back links relative ( #2348 )
...
* Empty-Commit
* feat: make skip links relative
* feat: make scheme back links relative
* feat: update tests
9 months ago
Robert Sullivan
c4741ee2ac
CLDC-2670: Improve navigation flow when revisiting questions from CYA page ( #2362 )
...
* CLDC-2670: Improve navigation flow when revisiting questions from CYA page
* CLDC-2670: Fix failing test
* CLDC-2670: fix issue with wrong referrer behaviour on interrupt screens
* CLDC-2670: Fix build errors
* Update validation feature
* CLDC-2670: Do not show already-answered questions when answering new questions from CYA page
* CLDC-2670: Fix linter error and tests
* Fix incorrect URLs in feature test
* feat: fix typo
* feat: make skip links for new answers route to check_answers
* feat: make skip links for new answers route to check_answers
* feat: update tests
* feat: bug fix
* feat: test fix
* feat: skip unanswered questions for interruption screens
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
9 months ago
Robert Sullivan
d2518d7c38
CLDC-2481: Add ability to disable organisations ( #2293 )
...
* CLDC-2481: Add ability to disable organisations.
* CLDC-2481: Add ability to disable organisations
* Tidy up tests
* CLDC-2481: Review markups
* CLDC-2481: Fix location and scheme filters
* Add banners for stock owners and managing agents
* Update view test
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
9 months ago
Robert Sullivan
378388ebc5
CLDC-3156: Update 2024 referral options ( #2366 )
...
* CLDC-3156: Update 2024 referral options
* CLDC-3156: Add tests for referral question
* CLDC-3156: Update other referral questions
9 months ago
kosiakkatrina
a65cc59713
CLDC-2479 Allow deleting users ( #2288 )
...
* Add delete confirmation page
* Add status to the user
* Allow deleting user
* Refactor sign_in user in tests
* Add delete user button and update policy
* Update user policy
* Do not display deleted users as an answer option
* Update user table and details
* Do not show deleted users
* Disable delete user on production
* Update test
9 months ago
Robert Sullivan
2e7cb56c70
CLDC-3351: Clear deposit in situations where it is no longer derived ( #2354 )
...
* CLDC-3351: Clear deposit in situations where it is no longer derived
9 months ago
Robert Sullivan
1d5d736f03
CLDC-3355: Reorder rent types on 2024/5 forms ( #2343 )
9 months ago
natdeanlewissoftwire
da0d27c8f9
feat: update copy ( #2357 )
9 months ago
kosiakkatrina
826b803e4e
CLDC-3305 Update previous postcode routing for renewals ( #2325 )
...
* Derive previous postcode for renewals
* Do not route renewals to previous postcode
* Update test
9 months ago
kosiakkatrina
5bbf0148b5
CLDC-2478 Allow deleting locations ( #2285 )
...
* Add delete confirmation page
* Allow deleting location
* Add delete location button and update policy
* Add delete button to CYA
* Update location policy
* Do not display deleted locationa as an option
* Move delete button into the button group
* Add informative text for locations that have logs
* Refactor query
* CLDC-2478 Allow deleting scheme (#2286 )
* Add delete confirmation page
* Allow deleting scheme
* Add delete scheme button and update policy
* Add delete button to CYA
* Update scheme policy
* Do not display deleted schemes as an option
* Add informative text for schemesrbe that have logs
* Refactor query
* Update tests
* Add feature toggle
9 months ago
kosiakkatrina
41a68eee0a
CLDC-3341 Update nationality all csv labels ( #2328 )
...
* Update nationality all csv labels
* Update csv tests
* Return prefers not to say labels
9 months ago
natdeanlewissoftwire
99ad80aebd
feat: update skip links ( #2342 )
9 months ago
kosiakkatrina
a38d6a265f
CLDC-3334 Improve address search flow ( #2339 )
...
* Refactor page buttons
* Immediately show address search results
9 months ago
Robert Sullivan
cdfca1c023
CLDC-3336: Add hint text to Q77 for renewals ( #2340 )
9 months ago
Robert Sullivan
976d0f6e73
CLDC-3329: Update hint text for schemes question ( #2336 )
9 months ago