baarkerlounger/submit-social-housing-lettings-and-sales-data - submit-social-housing-lettings-and-sales-data - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Rachael Booth	636e40fc9d	CLDC-3505: Fix tests for hard year end part 4 (#2509 ) * Add in past end dates for testing * Temporarily disable test marked to delete at year end * Remove one off reinfer_local_authority task * Update validator_spec * Set 2024 date in form_handler_spec to be during crossover period as needed * Use bulk_upload.year_combo for comparison in request tests to avoid year dependancy * Update BU log creator specs for 2024 * Use year combo function in bulk upload mailer tests * Refactor lettings validator_spec * More fixes * More work on bu validator specs - mostly sales * Remove pre 2023 test * More use of bulk_upload.year_combo in request tests * Fix lint * Tweak bulk upload error row component tests for year changes * Further fixes * Fix 2023 lettings row parser spec * Sales log to csv fix * Refactor BU processor tests * Fix field number row identifier * Fix linting * More years in request spec * fix * Don't use db unnecessarily in financial validations spec * Fix sale date changing 2024 -> 2023 test * Add tests for bulk_upload.year_combo * Update bu factory year specification * Refactoring * Linting * Don't use helper in factory * Remove new 2023 specific test * Remove dummy end dates	9 months ago
kosiakkatrina	52a0b27611	CLDC-2442 Remove 2022/23 BU code (#2153 ) * Remove 2022/23 BU code * Add empty lines to csvs * Update feature tests * More tests * Remove forms and update a test * rebase tests	1 year ago
Phil Lee	c7db5102f6	CLDC-2294 Add authorization to bulk upload results (#1591 ) # Context - https://digital.dclg.gov.uk/jira/browse/CLDC-2294 - When bulk upload returns a results page it would be useful if colleagues of the uploader can see this page to help fix errors - It would also be useful if support users can see these reports to help diagnose bulk upload errors # Changes - Added `pundit` gem to handle authorization - Bulk upload results previously only accessible to the bulk uploader. Now they can be seen by users in the same org as the uploader and also support users	2 years ago
Phil Lee	81bdd1475c	CLDC-1780 Bulk upload summary (#1242 ) * add placeholder for bulk upload error summary * persist column for bulk upload errors * replace bulk upload summary table placeholder	2 years ago
Phil Lee	197e2ae4cb	[1778] Bulk upload errors (#1091 ) * lockdown bulk upload routes * able to view lettings bulk upload errors * add error count to bulk upload results * coverage for bulk upload filename on results * group bulk upload errors by row on results * able to view bulk upload sales results * scope lettings and sales bulk upload results * fix linting * call service correctly in test * add bulk upload sales questions mapping * appease linter * bulk upload error shows correct question - depending on log type it will show relevant question for the field concerned * use local disk for bulk upload for dev env - this saves the need to connect to S3 to play with bulk upload in dev environment * improve namespacing of classes * add job to process bulk uploads * use local disk storage for dev file upload * fix test * use inline active job queue_adapter for dev * use test active job queue adapter for test env * remove rubocop violation * delete bulk upload from disk after processing * populate errors with cell, row + metadata * update error message with something meaningful * shim in sales validator * able to parse sales bulk uploads * change migration to add purchase_code to errors * bulk upload error component renders purchaser code - when a sales log * populate purchaser_code for bulk upload errors - when log type is sales * remove superfluous private method	2 years ago