52cf157242 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2799 Lettings and Sales CSV export updates and sales bug fix ( #1951 )  
							
							... 
							
							
 
							
							* feat: wip commit add person details to sales log csv service
* feat: add comments
* feat: update regex to include agen_known fields
* feat: revert
* feat: reject age_known fields and map codes and values to age fields instead
* feat: add age1_known
* feat: combine age not known and details not known fields
* feat: update tests
* refactor: lint
* feat: update tests
* feat: update lettings tests
* feat: update question test 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								e7b5d701cd 
								
									
								
							
								 
							
						 
						
							
							
								
								Reimport postcodes for 2022 ( #1956 )  
							
							
 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								2ab79b2f3e 
								
									
								
							
								 
							
						 
						
							
							
								
								Keep the logs in memory ( #1955 )  
							
							
 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								7a4edeb17c 
								
									
								
							
								 
							
						 
						
							
							
								
								Reimport lettings log form ID ( #1950 )  
							
							
 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								840e9d050e 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2837 Update import for washup migration 2 ( #1948 )  
							
							... 
							
							
 
							
							* feat: update rake tasks for washup batch 2
* feat: update rake tasks for washup batch 2 and add tests
* feat: revert unrelated test change
* feat: add dpo check before importing user 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								d7538df04b 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2772 Deduplicate logs on import ( #1945 )  
							
							... 
							
							
 
							
							* Do not import logs if a duplicate log exists on the system
* deduplicate sales logs on import
* Only deduplicate logs created on new core
* Update test names 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								a1527e48f7 
								
									
								
							
								 
							
						 
						
							
							
								
								Add duplicate log error if the chcharges are the same ( #1942 )  
							
							
 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								bff55e37d7 
								
									
								
							
								 
							
						 
						
							
							
								
								feat: only send dsa confirm email to new dpo when  it isn't already confirmed ( #1947 )  
							
							
 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								5b85c68be9 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2774 Update lettings materials ( #1939 )  
							
							... 
							
							
 
							
							* feat: update lettings materials
* feat: update tests
* refactor: lint 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								3aee2923a2 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2816 scheme filter bug 2 ( #1946 )  
							
							... 
							
							
 
							
							* feat: move ordering after filtering to avoid ORDER BY using expressions not in SELECT DISTINCT list
* feat: add multiple schemes so tests will fail if this bug appears again
* feat: include schemes and locations with nil confirmed values in incomplete scopes
* refactor: lint 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								29c01fa959 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2695 Display signed at date instead of created at date for DSAs ( #1941 )  
							
							... 
							
							
 
							
							* Dislplay signed at date instead of created at date
* Add signed at and dpo details to DPC seed 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								fd149de15b 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2747 Export details not known values ( #1938 )  
							
							... 
							
							
 
							
							* Adjust xml export to export refused details, update refused to take into account details_unknown
* Recalculate refused values for lettings logs with unknown person details
* Export refused values in the csv
* Update file names 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								47dc8279c2 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2505 Bulk upload email link journey ( #1825 )  
							
							... 
							
							
 
							
							* CLDC-2505: "complete" tag added and implemented to bulk upload status
* CLDC-2505: complete option added to choice
* CLDC-2505: lettings changes made to sales
* CLDC-2505: tests added, bulk_upload model changed, redirect changed
* CLDC-2505: Content update
* CLDC-2505: Tests fixed and moved to correct controller spec
* CLDC-2505: linting
* CLDC-2505: test linting fix
* CLDC-2505: Content fix
* Update content
---------
Co-authored-by: Kat <katrina@kosiak.co.uk> 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								0bbef7ce5e 
								
									
								
							
								 
							
						 
						
							
							
								
								Report on imported logs only ( #1943 )  
							
							
 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								f1e4f9f9ec 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2674 Fix delete duplicates cancel and back buttons ( #1936 )  
							
							... 
							
							
 
							
							* feat: fix duplicate log back behaviour
* feat: fix duplicate log cancel behaviour
* feat: fix duplicate log back behaviour and add tests
* feat: update remaining tests 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								d6ef35eef0 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2816 Fix scheme filter bug ( #1940 )  
							
							... 
							
							
 
							
							* feat: move ordering after filtering to avoid ORDER BY using expressions not in SELECT DISTINCT list
* feat: add multiple schemes so tests will fail if this bug appears again 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								e4c6e42e3d 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2659 complete logs with no location ( #1931 )  
							
							... 
							
							
 
							
							* WIP fix
* feat: update status before validation to prevent issue in future
* feat: reprivatise update_status!
* feat: revert before_save -> before_validation
* feat: add test
* feat: lint
* refactor: lint 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								6c88ddda93 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2795 Only update 2022 and 2023 logs ( #1933 )  
							
							... 
							
							
 
							
							* Only update 2022 and 2023 logs
* Add tests 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								7c553aba83 
								
									
								
							
								 
							
						 
						
							
							
								
								Update lead tenants gender identity ( #1932 )  
							
							
 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								5947d6a191 
								
									
								
							
								 
							
						 
						
							
							
								
								Add users to unassigned when the owner id is not given ( #1929 )  
							
							... 
							
							
 
							
							* Add users to unassigned when the owner id is not given
* test 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								49c596acbc 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2748 Update min age for 2022/23 ( #1930 )  
							
							... 
							
							
 
							
							* Update min age for 2022/23
* comment out flaky tests 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								de5bfe6597 
								
									
								
							
								 
							
						 
						
							
							
								
								Reimport childrens social care referral values ( #1926 )  
							
							
 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								2f67b8a0e9 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2790 Reimport person details ( #1925 )  
							
							... 
							
							
 
							
							* Move single person details if person 2 details are missing
* Allow reimporting details for any single missing person
* Reimport multiple missing person details, skip logs with no extra person details
* Skip update if record does not have hhmemb value
* Refactor
* Rebase change
* Extract method 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								6dc2b2a5d7 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2729 Reimport referral for general needs PRP ( #1923 )  
							
							... 
							
							
 
							
							* Reimport referral for general needs PRP
* test 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								3a165192fa 
								
									
								
							
								 
							
						 
						
							
							
								
								Fix homeless value in reimport ( #1928 )  
							
							
 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								3b575409e1 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2770 Reimport prefers not to say for gender and relationship ( #1922 )  
							
							... 
							
							
 
							
							* Update sex and relat for a single person
* Allow updates for multiple people
* Add option to the rake task 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								44797637fb 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2769 Reimport unassigned logs ( #1919 )  
							
							... 
							
							
 
							
							* Reimport logs with created by missing
* Reimport unassigned sales logs 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								16d2836d08 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2748 Update min value for age ( #1918 )  
							
							... 
							
							
 
							
							* Update min value for age
* Update existing 0 age values to 1 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								f72349f81e 
								
									
								
							
								 
							
						 
						
							
							
								
								Update homeless values ( #1917 )  
							
							
 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								6310a48610 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2795 Confirm scharge, pscharge and supcharge soft validations ( #1915 )  
							
							... 
							
							
 
							
							* Confirm scharge, pscharge and supcharge soft validations for completed logs
* This test seems flaky, likely because of the order, so reducing #of logs 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								647f9fbc59 
								
									
								
							
								 
							
						 
						
							
							
								
								Update internal transfer validation ( #1924 )  
							
							... 
							
							
 
							
							* feat: remove residential care home from internal transfer validation
* feat: update tests
* feat: update tests
* feat: update tests 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								ea9c84e2a1 
								
									
								
							
								 
							
						 
						
							
							
								
								Display old log id in the missing answers examples ( #1914 )  
							
							
 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								2f986fe111 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2795 Update charges validations ( #1912 )  
							
							... 
							
							
 
							
							* Update charges hard maximums
* Add charges value check fields
* Add 2023 charges value check pages and questions
* add scharge_over_soft_max method
* add LA cases
* Add pscharge_over_soft_max method
* Add supcharg_over_soft_max method
* Add pages to subsections (2023) and update content
* Confirm soft validations when importing
* csv tests
* Fix copy for 2022 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								7a64cb7f56 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2776 Add referral option to general needs logs ( #1910 )  
							
							... 
							
							
 
							
							* Add option to referral PRP general needs questions
* Add referral value check
* Add referral value check to 2023
* Update soft validation content
* Add referral value check to 2022
* Confirm soft validation on import
* Tests 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								3da6416950 
								
									
								
							
								 
							
						 
						
							
							
								
								Set income and savings not known for in progress logs ( #1911 )  
							
							
 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								20337fde59 
								
									
								
							
								 
							
						 
						
							
							
								
								Migration use kebab org fields ( #1913 )  
							
							... 
							
							
 
							
							* feat: use kebab case org fields
* feat: update tests 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								d3dec60f39 
								
									
								
							
								 
							
						 
						
							
							
								
								Only set soc tenant fields for 2022 or if they're given ( #1908 )  
							
							... 
							
							
 
							
							* Only set soc tenant fields for 2022 or if they're given
* Refactor 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								a1cc9d7863 
								
									
								
							
								 
							
						 
						
							
							
								
								Move person details if some persons are skipped ( #1903 )  
							
							... 
							
							
 
							
							* Move person details if some persons are skipped
* Check that undesired person details don't get saved
* Make sure we don't repeat people details 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								077390bb5b 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2699 Update values updated at when updating reason field ( #1909 )  
							
							... 
							
							
 
							
							* Update values updated at
* Update tests 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								c80565a54d 
								
									
								
							
								 
							
						 
						
							
							
								
								Make saledate nil safe(r) ( #1904 )  
							
							... 
							
							
 
							
							* feat: allow missing day/month/year values if CompletionDate exists as we don't always receive these from old core
* feat: make safe string as decimal nil safer too
* feat: add test 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								213a4bf229 
								
									
								
							
								 
							
						 
						
							
							
								
								Blank invalid combined income and proplen values on migration ( #1907 )  
							
							... 
							
							
 
							
							* feat: clear invalid combine incomes
* feat: clear out of range proplen values 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								564fa9ebb5 
								
									
								
							
								 
							
						 
						
							
							
								
								Mark hodate value check confirmed ( #1906 )  
							
							... 
							
							
 
							
							* Mark hodate value check confirmed
* Add other missing value_checks for sales 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								c049089684 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2725 Add missing sales data report ( #1893 )  
							
							... 
							
							
 
							
							* Add missing sales answers reporting
* Fix log name 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								bda7bc7d08 
								
									
								
							
								 
							
						 
						
							
							
								
								Only blank tenancy length when it is invalid for tenancy type ( #1902 )  
							
							... 
							
							
 
							
							* Only blank tenancy lenght when it is invalid for tenancy type
* Update spec/services/imports/lettings_logs_import_service_spec.rb
Co-authored-by: natdeanlewissoftwire <94526761+natdeanlewissoftwire@users.noreply.github.com>
---------
Co-authored-by: natdeanlewissoftwire <94526761+natdeanlewissoftwire@users.noreply.github.com> 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								f59c67b651 
								
									
								
							
								 
							
						 
						
							
							
								
								Add reimport reason update_field case ( #1896 )  
							
							
 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								11ca1bbcff 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2724 Add missing data reporting for imported lettings logs ( #1892 )  
							
							... 
							
							
 
							
							* Add generate_missing_answers_report task and method
* Create example report
* change task description
* refactor
* Report old form id instead of old id 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								19ad92c21d 
								
									
								
							
								 
							
						 
						
							
							
								
								feat: don't raise "no matching location" error ( #1900 )  
							
							
 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								41228e2295 
								
									
								
							
								 
							
						 
						
							
							
								
								Fix hundredth error on migration of very small scharge values ( #1898 )  
							
							... 
							
							
 
							
							* feat: round all decimal values to 2dp in safe_string_as_decimal
* refactor: lint 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								e5e6e1e21a 
								
									
								
							
								 
							
						 
						
							
							
								
								Enforce offered as integer ( #1897 )  
							
							... 
							
							
 
							
							* feat: ensure offered is an integer (decimal 0 was triggering validation errors)
* feat: allow decimals but clear when not integer equivalent as per new requirements 
							
						 
						
							2 years ago  
				
					
						
							
							
								 
						
							
							
								c3636c1286 
								
									
								
							
								 
							
						 
						
							
							
								
								CLDC-2696 Add reimport addresses task ( #1891 )  
							
							... 
							
							
 
							
							* Add update address service for lettings
* Only process collections 2023 onwards
* Update app/services/imports/lettings_logs_field_import_service.rb
Co-authored-by: natdeanlewissoftwire <94526761+natdeanlewissoftwire@users.noreply.github.com>
* Refactor postcode_known
* test
---------
Co-authored-by: natdeanlewissoftwire <94526761+natdeanlewissoftwire@users.noreply.github.com> 
							
						 
						
							2 years ago