submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
kosiakkatrina	364fb1e198	CLDC-2554 Update back to all logs link (#1811 ) * Update resume link * Add tests * Update copy	1 year ago
Jack	2c268e225f	Add file in front of filename (#1662 ) * Add file in front of filename * Update more templates	1 year ago
Phil Lee	903cf81749	CLDC-2305 Bulk upload setup fields validations (#1633 ) # Context - https://digital.dclg.gov.uk/jira/browse/CLDC-2305 - This is rework to add missing validations for sales setup fields for bulk upload # Changes - There is code that clears log fields if they are not a valid option. in order to generate errors for these we check certain fields for content prior to `log.valid?` being called. Unfortunately there does not appear to be an easy way to access to valid options therefore these values have been hard coded - Privacy notice must be accepted other considered a setup error - The `type` question can actually be one of three questions with the same identifier. these are excluded as part of `validate_valid_radio_option` and instead validated with a different mechanism. The rationale being that `log.valid?` will clear data before we get there - Remove tests associated to upload threshold which are no longer required	1 year ago
Phil Lee	210a25eaf5	fix bulk upload summary error ordering (#1562 )	2 years ago
Phil Lee	af53a9f0df	CLDC-2184 Fix ordering for bulk upload errors by cell (#1544 ) # Context - https://digital.dclg.gov.uk/jira/browse/CLDC-2184 - bulk upload error reports were not sorting by cells correctly # Changes - there was an issue where `Z100` would come after `AA100` which is not correct - fix ordering issue above - also made change so this is now delegated to the database rather than sorting in ruby	2 years ago
Phil Lee	d0046256cb	CLDC-2170 Bulk upload summary tweaks (#1522 ) * show summary when on error threshold * remove bulk upload mailer template - this template is no longer used * setup errors do not consider threshold - return approprate intro test depending if there are setup errors or not	2 years ago
Phil Lee	7a34f4a6a0	link to bulk upload spec and templates (#1476 )	2 years ago
Phil Lee	d38c2a3867	CLDC-2134 Bulk upload tabs (#1436 ) * tweak bulk upload email copy formatting * change bulk upload summary error report - this is now tabbed with the full report - also summary report has now changed from single table to multiple tables * bulk upload cannot navigate to summary report - as when sent to view full report the user does not have enough errors that need summarising	2 years ago
Phil Lee	af1fe815de	CLDC-2065 Bulk upload error summary minimum limit (#1347 ) * bulk upload error summary min limit - the errors summary table only show errors for column where there at least 16 errors for that column - if there are fewer than 16 errors that can see detailed report to pin point and fix those specific issues * add #errors? to summary component * show full error report if not enough errors - if errors summary table is empty as below threshold - send users to full report - remove the back button so they cannot access summary report * add upload again cta otherwise a dead end	2 years ago
Phil Lee	81bdd1475c	CLDC-1780 Bulk upload summary (#1242 ) * add placeholder for bulk upload error summary * persist column for bulk upload errors * replace bulk upload summary table placeholder	2 years ago
Phil Lee	9513e1179d	CLDC-1764 Bulk upload filter (#1223 ) * refactor with extract method * can filter logs by bulk upload * hide log creation button when viewing bulk upload - this affects the logs index page filtering logs from a specific bulk upload * add info banner to bulk upload logs * placeholder for bulk upload logs header * when resuming bulk upload set filters * fill place holder with remaining logs to fix * add interstitial to resume if logs resolved * after resolving bulk upload logs show interstitial * fix linting error * extract view variable to helper method	2 years ago
Phil Lee	197e2ae4cb	[1778] Bulk upload errors (#1091 ) * lockdown bulk upload routes * able to view lettings bulk upload errors * add error count to bulk upload results * coverage for bulk upload filename on results * group bulk upload errors by row on results * able to view bulk upload sales results * scope lettings and sales bulk upload results * fix linting * call service correctly in test * add bulk upload sales questions mapping * appease linter * bulk upload error shows correct question - depending on log type it will show relevant question for the field concerned * use local disk for bulk upload for dev env - this saves the need to connect to S3 to play with bulk upload in dev environment * improve namespacing of classes * add job to process bulk uploads * use local disk storage for dev file upload * fix test * use inline active job queue_adapter for dev * use test active job queue adapter for test env * remove rubocop violation * delete bulk upload from disk after processing * populate errors with cell, row + metadata * update error message with something meaningful * shim in sales validator * able to parse sales bulk uploads * change migration to add purchase_code to errors * bulk upload error component renders purchaser code - when a sales log * populate purchaser_code for bulk upload errors - when log type is sales * remove superfluous private method	2 years ago

12 Commits (961aefa0956f7907430ada8f63e523b91b3f6c3c)